Skip to contentSkip to conversation

Regression caused by commit 4bdc33ed ("NFSDv4.2: Add NFS v4.2 support to the NFS server")

DISCUSSION Jongman Heo 2 participants 2 messages Sep 27, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

SGksDQoNCj4NCj4tLS0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0tLS0tLQ0KPlNlbmRlciA6IEou IEJydWNlIEZpZWxkczxiZmllbGRzQGZpZWxkc2VzLm9yZz4NCj5EYXRlIDogMjAxMy0wOS0yNyAx MDoxMiAoR01UKzA5OjAwKQ0KPlRpdGxlIDogUmU6IFJlOiBSZTogUmVncmVzc2lvbiBjYXVzZWQg YnkgY29tbWl0IDRiZGMzM2VkICgiTkZTRHY0LjI6IEFkZCBORlMgdjQuMiBzdXBwb3J0IHRvIHRo ZSBORlMgc2VydmVyIikNCj4NCj5PbiBUaHUsIFNlcCAyNiwgMjAxMyBhdCAxMTo1Nzo1N1BNICsw MDAwLCBKb25nbWFuIEhlbyB3cm90ZToNCj4+ID4tLS0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0t LS0tLQ0KPj4gPlNlbmRlciA6IEouIEJydWNlIEZpZWxkcw0KPj4gPlRoaXMgaXMgcHJldHR5IHdl aXJkLS1pdCdzIG5vdCBhdCBhbGwgb2J2aW91cyBob3cgdGhhdCBwYXRjaCB3b3VsZA0KPj4gPmFm ZmVjdCB0aGlzLg0KPj4gPg0KPj4gPllvdSdyZSBhYnNvbHV0ZWx5IHBvc2l0aXZlIHRoYXQgdGhl ICpvbmx5KiB0aGluZyB5b3UncmUgY2hhbmdpbmcgb24gdGhlDQo+PiA+c2VydmVyIGJldHdlZW4g dGhlICJnb29kIiBhbmQgImJhZCIgY2FzZXMgaXMgdGhhdCBvbmUga2VybmVsIHBhdGNoPw0KPj4g PllvdSdyZSBub3QgY2hhbmdpbmcgYW55dGhpbmcgaW4gdXNlcnNwYWNlPw0KPj4gPg0KPj4gDQo+ PiBZZXMsIHByZXR0eSBzdXJlLg0KPj4gDQo+PiA+V2hhdCBkb2VzICJjYXQgL3Byb2MvZnMvbmZz ZC92ZXJzaW9ucyIgcmVwb3J0IGluIHRoZSBnb29kIGFuZCBiYWQgY2FzZXM/DQo+PiA+DQo+PiA+ KEJUVywgb3V0IG9mIGN1cmlvc2l0eTogd2hhdCBraW5kIG9mIGNsaWVudCBpcyB0aGlzIHRoYXQg b25seSBzdXBwb3J0cw0KPj4gPk5GU3YyIGFuZCBORlN2Mz8gIEV2ZW4gZm9yIGFuIGVtYmVkZGVk IHN5c3RlbSB0aGF0J3MgYSBiaXQgc3VycHJpc2luZy4pDQo+PiA+DQo+PiA+LS1iLg0KPj4gPg0K Pj4gDQo+PiBIZXJlIGFyZSAvcHJvYy9mcy9uZnNkL3ZlcnNpb25zIGluZm9ybWF0aW9uIGZvciBn b29kIGFuZCBiYWQgY2FzZXMgOw0KPj4gDQo+PiBnb29kIChjb21taXQgNGJkYzMzZWQgcmV2ZXJ0 ZWQpDQo+PiANCj4+ICMgY2F0IC9wcm9jL2ZzL25mc2QvdmVyc2lvbnMgDQo+PiArMiArMyArNCAr NC4xDQo+PiANCj4+IA0KPj4gYmFkIChjdXJyZW50IGxpbnVzIGdpdCkNCj4+IA0KPj4gIyBjYXQg L3Byb2MvZnMvbmZzZC92ZXJzaW9ucyAgDQo+PiAtMiArMyArNCArNC4xIC00LjINCj4+IA0KPj4g DQo+PiBJIGRvbid0IGtub3cgd2h5IHRoZSBjb21taXQgNGJkYzMzZWQgbWFrZXMgdGhpcyBkaWZm ZXJlbmNlICggZnJvbSArMiB0byAtMiApLg0KPj4gDQo+PiBNeSBORlMgc2VydmVyIGp1c3QgdXNl cyBGZWRvcmEgMTkgKyBsYXRlc3Qga2VybmVsICh3aGljaCBpcyBub3QgYSByYXJlIHNldHVwLi4u KSwgDQo+DQo+VGhlIHRoaW5nIGlzLCBuZnMtdXRpbHMgKmRpZCogbWFrZSBleGFjdGx5IHRoaXMg Y2hhbmdlIHdpdGggY29tbWl0DQo+NmI0ZTQ5NjVhNmI4MmU4ZDQ5Y2VhMWMwMzE2Yjk1MWJhNGU5 ZTgzZSAicnBjLm5mc2Q6IE5vIGxvbmdlciBhZHZlcnRpc2UNCj5ORlMgdjIgc3VwcG9ydC4iIGlu IDEuMi45LXJjNCB3aGljaCBlbnRlcmVkIGYxOSByZWNlbnRseS4gIEFuZCB0aGF0DQo+a2VybmVs IGNvbW1pdCBkb2Vzbid0IGxvb2sgcmVsYXRlZC4gIFNvIEkgc3Ryb25nbHkgc3VzcGVjdCB0aGF0 IHlvdSBnb3QNCj50aGUgbmZzLXV0aWxzIHVwZGF0ZSAob3IgcmVib290ZWQgYWZ0ZXIgdGhlIHVw ZGF0ZSkgYXQgdGhlIHNhbWUgdGltZSBhcw0KPmJpc2VjdGluZywgYW5kIHRoYXQgY29uZnVzZWQg dGhlIGJpc2VjdCByZXN1bHRzLg0KPg0KDQpObywgSSBoYXZlbid0IGNoYW5nZWQvdXBncmFkZWQg bmZzLXV0aWxzIHBhY2thZ2UgZHVyaW5nIGdpdCBiaXNlY3QuDQpBbmQgSSBjYW4gc3RpbGwgcmVw cm9kdWNlIHRoZSBpc3N1ZS4NCg0KIyBycG0gLXFhfGdyZXAgbmZzLXV0aWxzDQpuZnMtdXRpbHMt MS4yLjgtNC4wLmZjMTkuaTY4Ng0KDQojIHJwbSAtcSAtLWNoYW5nZWxvZyBuZnMtdXRpbHN8aGVh ZCAtNg0KKiBNb24gQXVnIDE5IDIwMTMgU3RldmUgRGlja3NvbiA8c3RldmVkQHJlZGhhdC5jb20+ IDEuMi44LTQuMA0KLSBVcGRhdGVkIHRvIGxhdGVzdCB1cHN0cmVhbSBSQyByZWxlYXNlOiBuZnMt dXRpbHMtMS0yLTktcmM0DQoNCiogVHVlIEp1bCAyMyAyMDEzIFN0ZXZlIERpY2tzb24gPHN0ZXZl ZEByZWRoYXQuY29tPiAxLjIuOC0zLjANCi0gVXBkYXRlZCB0byBsYXRlc3QgdXBzdHJlYW0gUkMg cmVsZWFzZTogbmZzLXV0aWxzLTEtMi05LXJjMw0KDQpBcyB5b3Ugbm90aWNlZCwgMS4yLjktcmM0 IGlzIGFwcGxpZWQgdG8gRmVkb3JhIDE5J3MgbmZzLXV0aWxzIHdoYXQgSSdtIHVzaW5nLi4uDQoN CldpdGggdGhlIG5mcy11dGlscywgcmV2ZXJ0aW5nIHRoZSBjb21taXQgbWFrZXMgZGlmZmVyZW5j ZSB0byBtZS4NCg0KDQpBbm90aGVyIHdvcmthcm91bmQgZnJvbSB1c2VyLXNwYWNlIChpbnN0ZWFk IG9mIHJldmVydCkgd29ya3MgZm9yIG1lLg0KDQpMYXRlc3QgbGludXMgZ2l0IGdpdmVzIGZvbGxv d2luZyBORlMgdmVyc2lvbiBzdXBwb3J0ICh3aXRoIG15IHNlcnZlcidzIC5jb25maWcpLg0KDQog ICMgY2F0IC9wcm9jL2ZzL25mc2QvdmVyc2lvbnMgDQogIC0yICszICs0ICs0LjEgLTQuMg0KDQpJ J3ZlIGNoYW5nZWQgL2V0Yy9zeXNjb25maWcvbmZzIGZpbGUgYXMgZm9sbG93aW5nIGRpZmYgOw0K DQpAQCAtMTAsNyArMTAsNyBAQA0KICNMT0NLRF9VRFBQT1JUPTMyNzY5DQogIw0KICMgT3B0aW9u YWwgYXJndW1lbnRzIHBhc3NlZCB0byBycGMubmZzZC4gU2VlIHJwYy5uZnNkKDgpDQotUlBDTkZT REFSR1M9IiINCitSUENORlNEQVJHUz0iLVYgMiINCg0KDQpUaGVuLiBydW4gbmZzIHNlcnZlciBh Z2Fpbi4uLg0KDQojIHN5c3RlbWN0bCByZXN0YXJ0IG5mcy1zZXJ2ZXIuc2VydmljZQ0KIyBjYXQg L3Byb2MvZnMvbmZzZC92ZXJzaW9ucyANCisyICszICs0ICs0LjEgLTQuMg0KDQpOb3cgTkZTIGJv b3QgaXMgd29ya2luZy4gDQpBY3R1YWxseSBJJ20gT0sgd2l0aCB0aGlzLCBzaW5jZSBORlMgYm9v dCBpcyBqdXN0IHVzZWQgZm9yIGRlYnVnZ2luZyBwdXJwb3NlLCBub3QgZm9yIHByb2R1Y3Rpb24g dXNlLCBpbiBteSBjYXNlLg0KDQoNCkZZSSwgaW4gb3RoZXIgTGludXggbWFjaGluZSAoVWJ1bnR1 IDEyLjA0KSwgbmZzLXV0aWxzIHZlcnNpb24gaXMgIjEuMi41LTN1YnVudHUzLjEiLCBhbmQgdGhl IGtlcm5lbCBjb21taXQgZG9lc24ndCBjYXVzZSBORlMgdjIgc3VwcG9ydCBpc3N1ZS4NCg0KIyBj YXQgL3Byb2MvZnMvbmZzZC92ZXJzaW9ucw0KKzIgKzMgKzQgKzQuMSAtNC4yDQoNClNvLCB0aGUg Y2hhbmdlIGluIG5mcy11dGlscyAxLjIuOS1yYzQgc2VlbXMgdG8gYmUgdGhlIHJvb3QgY2F1c2Us IGJ1dCBJIGRvbid0IGtub3cgd2h5IHRoZSBrZXJuZWwgY29tbWl0IHJldmVydCByZXNvbHZlcyB0 aGUgaXNzdWUuDQoNCj4+IHNvIEkgdGhpbmsgc29tZSBwZW9wbGUgY2FuIHZlcmlmeSBpZiB0aGlz IHZlcnNpb24gaW5mb3JtYXRpb24gY2hhbmdlIGhhcHBlbnMgdy8gYW5kIHcvbyB0aGUgY29tbWl0 IHJldmVydC4NCj4+IA0KPj4gRG9uJ3Qga25vdyB0aGUgZGV0YWlsIG9mIE5GUyBwcm90b2NvbCwg YnV0IG91ciBORlMgY2xpZW50IHNlZW1zIG5vdCB0byB0cnkgd2l0aCB2MyBhbmQgdjQgaW4gY2Fz ZSB2MiBmYWlscy4uLg0KPj4gSXMgdGhpcyBhbiB1bmV4cGVjdGVkIChidWdneSkgYmVoYXZpb3Ig b2YgbXkgb2xkIGVtYmVkZGVkIGJveCAoTkZTIGNsaWVudCBvZiBrZXJuZWwgMi42LjM1KSwgb3Ig ZXhwZWN0ZWQgb25lIGZyb20gdGhlIE5GUyBwcm90b2NvbD8NCj4NCj5EaWdnaW5nIGludG8gYSBo aXN0b3JpY2FsIGdpdCByZXBvIGp1c3QgZm9yIGZ1bi4uLi4gSXQgbG9va3MgbGlrZSBORlN2Mw0K PnN1cHBvcnQgd2FzIGFkZGVkIGluIDIuMy45OXByZTQtMywgcHJvYmFibHkgaW4gMjAwMD8gIChU aGUgZGF0ZSBvbiB0aGF0DQo+Y29tbWl0IGlzIDIwMDcsIHNvIG9idmlvdXNseSB0aGlzIHJlcG8g SSBoYXZlIGlzIHZlcnkgY29uZnVzZWQuICBNYXliZSBJDQo+c2hvdWxkIGdvIGZpbmQgaWYgdGhl cmUncyBhIGJldHRlciBvbmUgc29tZXBsYWNlLikNCj4NCj5TbyBhbnl3YXkgaXQncyBlaXRoZXIg Y29uZmlndXJlZCBvdXQgb2YgdGhlIGtlcm5lbCBvciB0aGUgbW91bnQNCj5jb21tYW5kbGluZSdz IGFza2luZyBmb3IgdjIsIG9yIEkgZG9uJ3Qga25vdyB3aGF0Li4uLg0KPg0KPi0tYi4NCj4NCg0K VGhhbmtzLA0KSm9uZ21hbiBIZW8u

#1 lore raw
Quoted 55 lines · Jongman Heo

Hi,

Quoted 43 lines

------- Original Message -------
Sender : J. Bruce Fields<[email protected]>
Date : 2013-09-27 10:12 (GMT+09:00)
Title : Re: Re: Re: Regression caused by commit 4bdc33ed ("NFSDv4.2: Add NFS v4.2 support to the NFS server")

Quoted 36 lines · Jongman Heo
Quoted 9 lines

------- Original Message -------
Sender : J. Bruce Fields
This is pretty weird--it's not at all obvious how that patch would affect this.

You're absolutely positive that the *only* thing you're changing on the server between the "good" and "bad" cases is that one kernel patch? You're not changing anything in userspace?

Yes, pretty sure.

Quoted 7 lines

What does "cat /proc/fs/nfsd/versions" report in the good and bad cases?

(BTW, out of curiosity: what kind of client is this that only supports NFSv2 and NFSv3? Even for an embedded system that's a bit surprising.)

--b.

Here are /proc/fs/nfsd/versions information for good and bad cases ;

good (commit 4bdc33ed reverted)

# cat /proc/fs/nfsd/versions 
+2 +3 +4 +4.1

bad (current linus git)

# cat /proc/fs/nfsd/versions  
-2 +3 +4 +4.1 -4.2

I don't know why the commit 4bdc33ed makes this difference ( from +2 to -2 ).

Quoted 9 lines
Quoted 1 line

My NFS server just uses Fedora 19 + latest kernel (which is not a rare setup...),

The thing is, nfs-utils *did* make exactly this change with commit 6b4e4965a6b82e8d49cea1c0316b951ba4e9e83e "rpc.nfsd: No longer advertise NFS v2 support." in 1.2.9-rc4 which entered f19 recently. And that kernel commit doesn't look related. So I strongly suspect that you got the nfs-utils update (or rebooted after the update) at the same time as bisecting, and that confused the bisect results.

Quoted 1 line

No, I haven't changed/upgraded nfs-utils package during git bisect.

Well, all it would take would be a long-ago yum update that you'd forgotten about by the time you rebooted to a new kernel at which point the new rpc.nfsd behavior would take affect on restarting the nfs server.

Quoted 1 line

And I can still reproduce the issue.

So I'm still really skeptical but if you're positive then I guess I should go try to reproduce and make sure there's not something very screwed up with the nfsd/versions interface.

--b.