Skip to contentSkip to conversation

bitbake.conf: drop obsolete comment referring to the fail-fast over-ride

PATCH Superseded Andre McCurdy 2 participants 2 messages May 14, 2018

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bitbake.conf: drop obsolete comment referring to the fail-fast over-ride

The comment appears to have been accidentally left behind when the fail-fast over-ride was removed by:

http://git.openembedded.org/openembedded-core/commit/?id=83ce96f44516c8a4a44c8c0140949256f8422014

---
 meta/conf/bitbake.conf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/conf/bitbake.conf +2 -2
index a21b728..a74d8cf 100644
@@ -733,8 +733,8 @@ DISTRO_NAME ??= "OpenEmbedded"
 # '<foo>_qemuarm' and then '<foo>' will be overriden with that value from '<foo>_qemuarm'.
 # And finally '<foo>_forcevariable' overrides any standard variable, with the highest priority.
 #
-# This works for  functions as well, they are really just environment variables.
-# Default OVERRIDES to make compilation fail fast in case of build system misconfiguration.
+# This works for functions as well, they are really just environment variables.
+#
 OVERRIDES = "${TARGET_OS}:${TRANSLATED_TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:${CLASSOVERRIDE}:forcevariable"
 CLASSOVERRIDE ?= "class-target"
 DISTROOVERRIDES ?= "${@d.getVar('DISTRO') or ''}"
Signature · 1 line
1.9.1
#1 lore raw
Quoted 16 lines · Andre McCurdy

The comment appears to have been accidentally left behind when the fail-fast over-ride was removed by:

  http://git.openembedded.org/openembedded-core/commit/?id=83ce96f445
16c8a4a44c8c0140949256f8422014

---
 meta/conf/bitbake.conf | 4 ++--

 1 file changed, 2 insertions(+), 2 deletions(-)
meta/conf/bitbake.conf +0 -0
index a21b728..a74d8cf 100644

meta/conf/bitbake.conf DISTRO_NAME ??= "OpenEmbedded" · line 736

Quoted 6 lines
meta/conf/bitbake.conf +1 -2
@@ -733,8 +733,8 @@ DISTRO_NAME ??= "OpenEmbedded"
  # '_qemuarm' and then '' will be overriden with that value from '_qemuarm'.
  # And finally '_forcevariable' overrides any standard variable, with the highest priority.
  #
-# This works for  functions as well, they are really just environment variables.
-# Default OVERRIDES to make compilation fail fast in case of build system misconfiguration.
+# This works for functions as well, they are really just environment variables.

If we're going to fix the comment, could you remove the word "environment" from there too please? :)

Cheers,

Richard