Add MDIO driver model support
v2 cover Add MDIO driver model support
From: Ken Ma <[email protected]>
Changes in v2:
- Fix error printing:
- Change some debug to pr_err;
- mii bus has no parent member and it is not a udevice, so dev_err is changed to pr_err for mii bus error printings.
Ken Ma (2):
dm: mdio: add a uclass for MDIO
mdio: add marvell MDIO driver
MAINTAINERS | 2 + arch/arm/Kconfig | 1 + doc/device-tree-bindings/mdio/marvell-mdio.txt | 18 ++ doc/device-tree-bindings/mdio/mdio-bus.txt | 54 ++++++ drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/mdio/Kconfig | 28 +++ drivers/mdio/Makefile | 7 + drivers/mdio/mdio-uclass.c | 119 +++++++++++++ drivers/mdio/mvmdio.c | 237 +++++++++++++++++++++++++ include/dm/uclass-id.h | 1 + include/mdio.h | 62 +++++++ 12 files changed, 532 insertions(+) create mode 100644 doc/device-tree-bindings/mdio/marvell-mdio.txt create mode 100644 doc/device-tree-bindings/mdio/mdio-bus.txt create mode 100644 drivers/mdio/Kconfig create mode 100644 drivers/mdio/Makefile create mode 100644 drivers/mdio/mdio-uclass.c create mode 100644 drivers/mdio/mvmdio.c create mode 100644 include/mdio.h
Signature · 1 line
1.9.1
PATCH v2 1/2 dm: mdio: add a uclass for MDIO
From: Ken Ma <[email protected]>
Add a uclass which provides access to MDIO busses and includes operations required by MDIO.
The implementation is based on the existing mii/phy/mdio data structures and APIs.
This patch also adds evice tree binding for MDIO bus.
---
Changes in v2: None
MAINTAINERS | 1 + doc/device-tree-bindings/mdio/mdio-bus.txt | 54 +++++++++++++ drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/mdio/Kconfig | 18 +++++ drivers/mdio/Makefile | 6 ++ drivers/mdio/mdio-uclass.c | 119 +++++++++++++++++++++++++++++ include/dm/uclass-id.h | 1 + include/mdio.h | 62 +++++++++++++++ 9 files changed, 264 insertions(+) create mode 100644 doc/device-tree-bindings/mdio/mdio-bus.txt create mode 100644 drivers/mdio/Kconfig create mode 100644 drivers/mdio/Makefile create mode 100644 drivers/mdio/mdio-uclass.c create mode 100644 include/mdio.h
MAINTAINERS +1 -0
@@ -335,6 +335,7 @@ M: Simon Glass <[email protected]> S: Maintained T: git git://git.denx.de/u-boot-dm.git F: drivers/core/ +F: drivers/mdio/ F: include/dm/ F: test/dm/
doc/device-tree-bindings/mdio/mdio-bus.txt new file +54 -0
54 lines not on this page · raw message
drivers/Kconfig +2 -0
@@ -44,6 +44,8 @@ source "drivers/led/Kconfig" source "drivers/mailbox/Kconfig" +source "drivers/mdio/Kconfig" + source "drivers/memory/Kconfig" source "drivers/misc/Kconfig"
drivers/Makefile +1 -0
@@ -82,6 +82,7 @@ obj-y += dfu/ obj-$(CONFIG_X86) += pch/ obj-y += phy/allwinner/ obj-y += phy/marvell/ +obj-y += mdio/ obj-y += rtc/ obj-y += scsi/ obj-y += sound/
drivers/mdio/Kconfig new file +18 -0
@@ -0,0 +1,18 @@ +# +# MDIO infrastructure and drivers +# + +menu "MDIO Support" + +config DM_MDIO + bool "Enable Driver Model for MDIO drivers" + depends on DM + help + Enable driver model for MDIO access. + Drivers provide methods to management data + Input/Output. + MDIO uclass provides interfaces to get mdio + udevice or mii bus from its child phy node or + an ethernet udevice which the phy belongs to. + +endmenu
drivers/mdio/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0+ +# +# Copyright (C) 2018 Marvell International Ltd. +# Author: Ken Ma<[email protected]> + +obj-$(CONFIG_DM_MDIO) += mdio-uclass.o
drivers/mdio/mdio-uclass.c new file +119 -0
119 lines not on this page · raw message
include/dm/uclass-id.h +1 -0
@@ -49,6 +49,7 @@ enum uclass_id {UCLASS_LPC ,/* x86 'low pin count' interface */ UCLASS_MAILBOX ,/* Mailbox controller */ UCLASS_MASS_STORAGE ,/* Mass storage device */ +UCLASS_MDIO ,/* MDIO device */ UCLASS_MISC ,/* Miscellaneous device */ UCLASS_MMC ,/* SD / MMC card or chip */ UCLASS_MOD_EXP, /* RSA Mod Exp device */
include/mdio.h new file +62 -0
62 lines not on this page · raw message
Signature · 1 line
1.9.1
PATCH v2 2/2 mdio: add marvell MDIO driver
In reply to make at marvell.comFrom: Ken Ma <[email protected]>
This patch adds a separate driver for the MDIO interface of the Marvell Ethernet controllers based on driver model. There are two reasons to have a separate driver rather than including it inside the MAC driver itself:
*) The MDIO interface is shared by all Ethernet ports, so a driver
must guarantee non-concurrent accesses to this MDIO interface. The most logical way is to have a separate driver that handles this single MDIO interface, used by all Ethernet ports.
*) The MDIO interface is the same between the existing mv643xx_eth
driver and the new mvneta/mvpp2 driver. Even though it is for now only used by the mvneta/mvpp2 driver, it will in the future be used by the mv643xx_eth driver as well.
This driver supports SMI IEEE for 802.3 Clause 22 and XSMI for IEEE 802.3 Clause 45.
This patch also adds device tree binding for marvell MDIO driver.
---
Changes in v2:
- Fix error printing:
- Change some debug to pr_err;
- mii bus has no parent member and it is not a udevice, so dev_err is changed to pr_err for mii bus error printings.
MAINTAINERS | 1 + arch/arm/Kconfig | 1 + doc/device-tree-bindings/mdio/marvell-mdio.txt | 18 ++ drivers/mdio/Kconfig | 10 ++ drivers/mdio/Makefile | 1 + drivers/mdio/mvmdio.c | 237 +++++++++++++++++++++++++ 6 files changed, 268 insertions(+) create mode 100644 doc/device-tree-bindings/mdio/marvell-mdio.txt create mode 100644 drivers/mdio/mvmdio.c
MAINTAINERS +1 -0
@@ -137,6 +137,7 @@ T: git git://git.denx.de/u-boot-marvell.git F: arch/arm/mach-kirkwood/ F: arch/arm/mach-mvebu/ F: drivers/ata/ahci_mvebu.c +F: drivers/mdio/mvmdio.c ARM MARVELL PXA M: Marek Vasut <[email protected]>
arch/arm/Kconfig +1 -0
@@ -432,6 +432,7 @@ config ARCH_MVEBU select DM_SPI select DM_SPI_FLASH select SPI + select DM_MDIO config TARGET_DEVKIT3250 bool "Support devkit3250"
doc/device-tree-bindings/mdio/marvell-mdio.txt new file +18 -0
@@ -0,0 +1,18 @@ +* Marvell MDIO Ethernet Controller interface + +The Ethernet controllers of the Marvel Armada 3700 and Armada 7k/8k +have an identical unit that provides an interface with the MDIO bus. +This driver handles this MDIO interface. + +Mandatory properties: +SoC specific: + - #address-cells: Must be <1>. + - #size-cells: Must be <0>. + - compatible: Should be "marvell,orion-mdio" (for SMI) + "marvell,xmdio" (for XSMI) + - reg: Base address and size SMI/XMSI bus. + +Optional properties: + - mdio-name - MDIO bus name + +For example, please refer to "mdio-bus.txt".
drivers/mdio/Kconfig +10 -0
@@ -15,4 +15,14 @@ config DM_MDIO udevice or mii bus from its child phy node or an ethernet udevice which the phy belongs to. +config MVMDIO + bool "Marvell MDIO interface support" + depends on DM_MDIO + select PHYLIB + help + This driver supports the MDIO interface found in the network + interface units of the Marvell EBU SoCs (Kirkwood, Orion5x, + Dove, Armada 370, Armada XP, Armada 37xx and Armada7K/8K/8KP). + + This driver is used by the MVPP2 and MVNETA drivers. endmenu
drivers/mdio/Makefile +1 -0
@@ -4,3 +4,4 @@ # Author: Ken Ma<[email protected]> obj-$(CONFIG_DM_MDIO) += mdio-uclass.o +obj-$(CONFIG_MVMDIO) += mvmdio.o
drivers/mdio/mvmdio.c new file +237 -0
237 lines not on this page · raw message
Signature · 1 line
1.9.1