perf intel-pt: Fix packet decoding of CYC packets
Adrian Hunter
reviewerPATCH 1/1 perf intel-pt: Fix packet decoding of CYC packets
Use a 64-bit type so that the cycle count is not limited to 32-bits.
Signed-off-by Adrian Hunter <[email protected]>
--- tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c +1 -1
@@ -366,7 +366,7 @@ static int intel_pt_get_cyc(unsigned int byte, const unsigned char *buf,if (len < offs)return INTEL_PT_NEED_MORE_BYTES ; byte = buf[offs++]; - payload |= (byte >>1 ) << shift; + payload |= ((uint64_t )byte >>1 ) << shift; } packet->type =INTEL_PT_CYC ;
Signature · 1 line
1.9.1
Em Thu, Jun 07, 2018 at 02:30:02PM +0300, Adrian Hunter escreveu:
Quoted 4 lines
Use a 64-bit type so that the cycle count is not limited to 32-bits.
Signed-off-by Adrian Hunter <[email protected]>
Thanks, applied.
- Arnaldo
Quoted 19 lines
--- tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c +1
-1@@ -366,7 +366,7 @@ static int intel_pt_get_cyc(unsigned int byte, const unsigned char *buf,if (len < offs)return INTEL_PT_NEED_MORE_BYTES ; byte = buf[offs++]; - payload |= (byte >>1 ) << shift; + payload |= ((uint64_t )byte >>1 ) << shift; } packet->type =INTEL_PT_CYC ;Signature · 1 line
1.9.1
tip-bot for Adrian Hunter
merge botperf intel-pt: Fix packet decoding of CYC packets
Commit-ID: 621a5a327c1e36ffd7bb567f44a559f64f76358f Gitweb: https://git.kernel.org/tip/621a5a327c1e36ffd7bb567f44a559f64f76358f Author: Adrian Hunter <[email protected]> AuthorDate: Thu, 7 Jun 2018 14:30:02 +0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 25 Jun 2018 11:59:36 -0300
perf intel-pt: Fix packet decoding of CYC packets
Use a 64-bit type so that the cycle count is not limited to 32-bits.
Signed-off-by Adrian Hunter <[email protected]>
Cc Jiri Olsa <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c +1 -1
@@ -366,7 +366,7 @@ static int intel_pt_get_cyc(unsigned int byte, const unsigned char *buf,if (len < offs)return INTEL_PT_NEED_MORE_BYTES ; byte = buf[offs++]; - payload |= (byte >>1 ) << shift; + payload |= ((uint64_t )byte >>1 ) << shift; } packet->type =INTEL_PT_CYC ;