Skip to contentSkip to conversation

drm/i915/psr: Adds psrwake options for all platforms

PATCH In review vathsala nagaraju 4 participants 6 messages Jun 18, 2018 – Jun 19, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/psr: Adds psrwake options for all platforms

From: Vathsala Nagaraju <[email protected]>

Adds new psrwake options defined in the below table.
Platform PSR wake options vbt version
KBL/CFL/WHL All(205+)
BXT Uses old interpretation.
CNL/ICL+ All(205+)
GLK All(205+)
SKL All PV releases (Check for 205+ might help but cannot be foolproof)

We will continue with newer interpretation for SKL from 205.

v2: Jani
Keep the bdb version check.
v3:
Apply newer version for skl from 205+(DK).
Add (version check && platform list) (Jani). Add bdb version for each platform in commit message(DK).

Cc Jani Nikula <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Puthikorn Voravootivat <[email protected]>
Cc Dhinakaran Pandiyan <[email protected]>
Cc Ashutosh D Shukla <[email protected]>
Cc Maulik V Vaghela <[email protected]>
---
 drivers/gpu/drm/i915/intel_bios.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_bios.c +2 -1
index 465dff4..9ef0464 100644
@@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct drm_i915_private *dev_priv,
 	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
 	 * Old decimal value is wake up time in multiples of 100 us.
 	 */
-	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
+	if (bdb->version >= 205 && (IS_GEN9_BC(dev_priv) ||
+	    IS_GEMINILAKE(dev_priv) || (INTEL_GEN(dev_priv) >= 10))) {
 		switch (psr_table->tp1_wakeup_time) {
 		case 0:
 			dev_priv->vbt.psr.tp1_wakeup_time_us = 500;
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: Adds psrwake options for all platforms (rev3)

== Series Details ==

== Series Details ==

Series: drm/i915/psr: Adds psrwake options for all platforms (rev3)
URL : https://patchwork.freedesktop.org/series/44601/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
71a6e6f9fe0e drm/i915/psr: Adds psrwake options for all platforms
-:42: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#42: FILE: drivers/gpu/drm/i915/intel_bios.c:714:
+	if (bdb->version >= 205 && (IS_GEN9_BC(dev_priv) ||
+	    IS_GEMINILAKE(dev_priv) || (INTEL_GEN(dev_priv) >= 10))) {

total: 0 errors, 0 warnings, 1 checks, 9 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.BAT: success for drm/i915/psr: Adds psrwake options for all platforms (rev3)

In reply to vathsala nagaraju
== Series Details ==

== Series Details ==

Series: drm/i915/psr: Adds psrwake options for all platforms (rev3)
URL : https://patchwork.freedesktop.org/series/44601/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4331 -> Patchwork_9345 =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_9345 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9345, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/44601/revisions/3/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9345:

=== IGT changes ===

    ==== Warnings ====

    igt@gem_exec_gttfill@basic:
      fi-pnv-d510:        PASS -> SKIP

== Known issues ==

Here are the changes found in Patchwork_9345 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
      fi-glk-j4005:       PASS -> FAIL (fdo#106765)

    igt@kms_flip@basic-plain-flip:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106000)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-cnl-psr:         PASS -> DMESG-WARN (fdo#104951)

    igt@prime_busy@basic-before-default:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#105719)

    
    ==== Possible fixes ====

    igt@gem_ringfill@basic-default-hang:
      fi-elk-e7500:       DMESG-WARN -> PASS

    igt@kms_chamelium@dp-crc-fast:
      fi-kbl-7500u:       DMESG-FAIL (fdo#103841) -> PASS

    igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
      fi-glk-j4005:       FAIL (fdo#106765) -> PASS

fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951
fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106765 https://bugs.freedesktop.org/show_bug.cgi?id=106765

== Participating hosts (41 -> 35) ==

Additional (1): fi-bxt-dsi
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-ilk-650 fi-ctg-p8600

== Build changes ==

* Linux: CI_DRM_4331 -> Patchwork_9345

CI_DRM_4331: e47233f783ee68a864c2a10216735aca62d642da @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4522: 077c6f7c3786334c5e5c34888ab446fdb4347331 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9345: 71a6e6f9fe0e541daf1a181cb6debc8086d1fa84 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

71a6e6f9fe0e drm/i915/psr: Adds psrwake options for all platforms

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9345/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

✓ Fi.CI.IGT: success for drm/i915/psr: Adds psrwake options for all platforms (rev3)

In reply to vathsala nagaraju
== Series Details ==

== Series Details ==

Series: drm/i915/psr: Adds psrwake options for all platforms (rev3)
URL : https://patchwork.freedesktop.org/series/44601/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4331_full -> Patchwork_9345_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_9345_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9345_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9345_full:

=== IGT changes ===

    ==== Warnings ====

    igt@gem_tiled_blits@interruptible:
      shard-glk:          SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_9345_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_gtt:
      shard-apl:          PASS -> INCOMPLETE (fdo#103927)

    igt@drv_selftest@live_hangcheck:
      shard-glk:          NOTRUN -> DMESG-FAIL (fdo#106947)

    igt@kms_cursor_crc@cursor-64x64-suspend:
      shard-snb:          PASS -> DMESG-WARN (fdo#102365)

    igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
      shard-glk:          PASS -> DMESG-WARN (fdo#105763)

    igt@kms_flip_tiling@flip-y-tiled:
      shard-glk:          PASS -> FAIL (fdo#104724, fdo#103822)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      shard-apl:          PASS -> FAIL (fdo#103375)

    igt@kms_setmode@basic:
      shard-kbl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          FAIL (fdo#106509) -> PASS

    igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_flip_tiling@flip-to-x-tiled:
      shard-glk:          FAIL (fdo#104724, fdo#103822) -> PASS

    igt@kms_flip_tiling@flip-to-y-tiled:
      shard-glk:          FAIL (fdo#104724) -> PASS

    igt@perf@polling:
      shard-hsw:          FAIL (fdo#102252) -> PASS

    
    ==== Warnings ====

    igt@drv_selftest@live_gtt:
      shard-glk:          INCOMPLETE (k.org#198133, fdo#103359) -> FAIL (fdo#105347)

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4331 -> Patchwork_9345

CI_DRM_4331: e47233f783ee68a864c2a10216735aca62d642da @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4522: 077c6f7c3786334c5e5c34888ab446fdb4347331 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9345: 71a6e6f9fe0e541daf1a181cb6debc8086d1fa84 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9345/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#4 lore raw
In reply to vathsala nagaraju
Quoted 11 lines · vathsala nagaraju

From: Vathsala Nagaraju <[email protected]>

Adds new psrwake options defined in the below table.
Platform PSR wake options vbt version
KBL/CFL/WHL All(205+)
BXT Uses old interpretation.
CNL/ICL+ All(205+)
GLK All(205+)
SKL All PV releases (Check for 205+ might help but
cannot be foolproof)

Quoted 1 line

We will continue with newer interpretation for SKL from 205.

Let's hope this works for most machines out there.

It'd be easier to distinguish newer updated patches if you use version numbers.

Quoted 35 lines

v2: Jani
    Keep the bdb version check.
v3:
    Apply newer version for skl from 205+(DK).
    Add (version check && platform list) (Jani). Add bdb version for each platform in commit message(DK).

Cc Jani Nikula <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Puthikorn Voravootivat <[email protected]>
Cc Dhinakaran Pandiyan <[email protected]>
Cc Ashutosh D Shukla <[email protected]>
Cc Maulik V Vaghela <[email protected]>

---
 drivers/gpu/drm/i915/intel_bios.c | 3 ++-

 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_bios.c +2 -1
index 465dff4..9ef0464 100644
@@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct
 drm_i915_private *dev_priv,
  	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
  	 * Old decimal value is wake up time in multiples of 100 us.
  	 */
-	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
+	if (bdb->version >= 205 && (IS_GEN9_BC(dev_priv) ||
+	    IS_GEMINILAKE(dev_priv) || (INTEL_GEN(dev_priv) >= 10)))
 {
  		switch (psr_table->tp1_wakeup_time) {
Quoted 2 lines

  case 0:
  dev_priv->vbt.psr.tp1_wakeup_time_us = 500;

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#5 lore raw
Quoted 12 lines · Dhinakaran Pandiyan
Quoted 11 lines · vathsala nagaraju

From: Vathsala Nagaraju <[email protected]>

Adds new psrwake options defined in the below table.
Platform PSR wake options vbt version
KBL/CFL/WHL All(205+)
BXT Uses old interpretation.
CNL/ICL+ All(205+)
GLK All(205+)
SKL All PV releases (Check for 205+ might help but
cannot be foolproof)

Quoted 7 lines
Quoted 1 line

We will continue with newer interpretation for SKL from 205.

Let's hope this works for most machines out there.

It'd be easier to distinguish newer updated patches if you use version numbers.

Thanks for the patch and review, pushed to dinq with the checkpatch warnings fixed while at it.

BR,
Jani.

Quoted 38 lines
Quoted 38 lines

v2: Jani
    Keep the bdb version check.
v3:
    Apply newer version for skl from 205+(DK).
    Add (version check && platform list) (Jani). Add bdb version for each platform in commit message(DK).

Cc Jani Nikula <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Puthikorn Voravootivat <[email protected]>
Cc Dhinakaran Pandiyan <[email protected]>
Cc Ashutosh D Shukla <[email protected]>
Cc Maulik V Vaghela <[email protected]>

---
 drivers/gpu/drm/i915/intel_bios.c | 3 ++-

 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_bios.c +2 -1
index 465dff4..9ef0464 100644
@@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct
 drm_i915_private *dev_priv,
  	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
  	 * Old decimal value is wake up time in multiples of 100 us.
  	 */
-	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
+	if (bdb->version >= 205 && (IS_GEN9_BC(dev_priv) ||
+	    IS_GEMINILAKE(dev_priv) || (INTEL_GEN(dev_priv) >= 10)))
 {
  		switch (psr_table->tp1_wakeup_time) {

  case 0:
  dev_priv->vbt.psr.tp1_wakeup_time_us = 500;

Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx