Skip to contentSkip to conversation

Staging:rtl8192e Fix Comparison to true is error prone

PATCH New Janani Sankara Babu 1 participant 1 message Jun 18, 2018 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 2/3 Staging:rtl8192e Fix Comparison to true is error prone

This patch removes the comaprison to bool value in the code

---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtl819x_BAProc.c +2 -2
index ccd898a..c6de34a 100644
@@ -365,7 +365,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
 	pAdmittedBA = &pTS->TxAdmittedBARecord;
 
 
-	if (pAdmittedBA->bValid == true) {
+	if (pAdmittedBA->bValid) {
 		netdev_dbg(ieee->dev, "%s(): ADDBA response already admitted\n",
 			   __func__);
 		return -1;
@@ -485,7 +485,7 @@ void TsInitAddBA(struct rtllib_device *ieee, struct tx_ts_record *pTS,
 {
 	struct ba_record *pBA = &pTS->TxPendingBARecord;
 
-	if (pBA->bValid == true && bOverwritePending == false)
+	if (pBA->bValid && !bOverwritePending)
 		return;
 
 	DeActivateBAEntry(ieee, pBA);

--
1.9.1