thunderbolt: fix small typo in variable name
PATCH 1/1 thunderbolt: fix small typo in variable name
From: Nathan Ciobanu <[email protected]>
Fixes small variable name typo and the associated
checkpatch spelling warning
--- drivers/thunderbolt/tb_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thunderbolt/tb_regs.h +1 -1
@@ -202,7 +202,7 @@ struct tb_regs_port_header {/* DWORD 5 */ u32 max_in_hop_id:11; u32 max_out_hop_id:11; - u32 __unkown4:10; + u32 __unknown4:10;/* DWORD 6 */ u32 __unknown5;/* DWORD 7 */
Signature · 1 line
1.9.1
Mika Westerberg
AppliedQuoted 6 lines · On Tue, Jun 26, 2018 at 04:34:20PM -0700, [email protected]…
From: Nathan Ciobanu <[email protected]>
Fixes small variable name typo and the associated
checkpatch spelling warningSigned-off-by Nathan Ciobanu <[email protected]>
Applied to thunderbolt.git/next, thanks!
On Tue, Jun 26, 2018 at 04:34:20PM -0700, [email protected] wrot> Fixes small variable name typo and the associated
Quoted 12 lines
checkpatch spelling warning
Signed-off-by Nathan Ciobanu <[email protected]>--- drivers/thunderbolt/tb_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/thunderbolt/tb_regs.h +0
-0
drivers/thunderbolt/tb_regs.h struct tb_regs_port_header { · line 208
Quoted 8 lines
drivers/thunderbolt/tb_regs.h +1
-1@@ -202,7 +202,7 @@ struct tb_regs_port_header {/* DWORD 5 */ u32 max_in_hop_id:11; u32 max_out_hop_id:11; - u32 __unkown4:10; + u32 __unknown4:10;/* DWORD 6 */ u32 __unknown5;/* DWORD 7 */
This is not an improvement. The bitfield is marked unknown because its meaning hasn't been reverse-engineered yet. But you work for Intel, presumably you don't have to reverse-engineer the bitfield's meaning because you know it or can find out about it.
So please submit a patch that changes the name to the bitfield's actual meaning.
Thanks,
Lukas
Quoted 27 lines · Lukas Wunner
On Tue, Jun 26, 2018 at 04:34:20PM -0700, [email protected] wrot> Fixes small variable name typo and the associated
Quoted 12 lines
checkpatch spelling warning
Signed-off-by Nathan Ciobanu <[email protected]>--- drivers/thunderbolt/tb_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/thunderbolt/tb_regs.h +0
-0drivers/thunderbolt/tb_regs.h struct tb_regs_port_header { · line 208
Quoted 8 lines
drivers/thunderbolt/tb_regs.h +1
-1@@ -202,7 +202,7 @@ struct tb_regs_port_header {/* DWORD 5 */ u32 max_in_hop_id:11; u32 max_out_hop_id:11; - u32 __unkown4:10; + u32 __unknown4:10;/* DWORD 6 */ u32 __unknown5;/* DWORD 7 */ This is not an improvement. The bitfield is marked unknown because its meaning hasn't been reverse-engineered yet. But you work for Intel, presumably you don't have to reverse-engineer the bitfield's meaning because you know it or can find out about it.
Quoted 2 lines
So please submit a patch that changes the name to the bitfield's actual meaning.
It is an improvement since it fixes what it says (the typo). Besides the patch is already applied.