Skip to contentSkip to conversation

FAILED: patch "[PATCH] IB/hfi1: Reorder incorrect send context disable" failed to apply to 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jul 1, 2018

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.9-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From a93a0a31111231bb1949f4a83b17238f0fa32d6a Mon Sep 17 00:00:00 2001

From: "Michael J. Ruhl" <[email protected]>
Date: Wed, 2 May 2018 06:43:07 -0700
Subject: [PATCH] IB/hfi1: Reorder incorrect send context disable

User send context integrity bits are cleared before the context is disabled. If the send context is still processing data, any packets that need those integrity bits will cause an error and halt the send context.

During the disable handling, the driver waits for the context to drain. If the context is halted, the driver will eventually timeout because the context won't drain and then incorrectly bounce the link.

Reorder the bit clearing and the context disable.

Examine the software state and send context status as well as the egress status to determine if a send context is in the halted state.

Promote the check macros to static functions for consistency with the new check and to follow kernel style.

Remove an unused define that refers to the egress timeout.

drivers/infiniband/hw/hfi1/file_ops.c +1 -1
index 1b778fd16a32..c9d23c37a371 100644
@@ -689,8 +689,8 @@ static int hfi1_file_close(struct inode *inode, struct file *fp)
 	 * checks to default and disable the send context.
 	 */
 	if (uctxt->sc) {
-		set_pio_integrity(uctxt->sc);
 		sc_disable(uctxt->sc);
+		set_pio_integrity(uctxt->sc);
 	}
 
 	hfi1_free_ctxt_rcv_groups(uctxt);
drivers/infiniband/hw/hfi1/pio.c +34 -10

65 lines not on this page · raw message