FAILED: patch "[PATCH] pinctrl: samsung: Correct EINTG banks order" failed to apply to 4.9-stable tree
Subsystems (4)
[email protected]
maintainerThe patch below does not apply to the 4.9-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
Quoted 1 line
From
5cf9a338db94cfd570aa2607bef1b30996f188e3Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pawe=C5=82=20Chmiel?= <[email protected]>
Date: Mon, 16 Apr 2018 17:52:45 +0200
Subject: [PATCH] pinctrl: samsung: Correct EINTG banks order
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
All banks with GPIO interrupts should be at beginning of bank array and without any other types of banks between them. This order is expected by exynos_eint_gpio_irq, when doing interrupt group to bank translation. Otherwise, kernel NULL pointer dereference would happen when trying to handle interrupt, due to wrong bank being looked up. Observed on s5pv210, when trying to handle gpj0 interrupt, where kernel was mapping it to gpi bank.
drivers/pinctrl/samsung/pinctrl-exynos-arm.c +2 -2
@@ -105,12 +105,12 @@ static const struct samsung_pin_bank_data s5pv210_pin_bank[] __initconst = {EXYNOS_PIN_BANK_EINTG (7 ,0x1c0 ,"gpg1" ,0x38 ),EXYNOS_PIN_BANK_EINTG (7 ,0x1e0 ,"gpg2" ,0x3c ),EXYNOS_PIN_BANK_EINTG (7 ,0x200 ,"gpg3" ,0x40 ), -EXYNOS_PIN_BANK_EINTN (7 ,0x220 ,"gpi" ),EXYNOS_PIN_BANK_EINTG (8 ,0x240 ,"gpj0" ,0x44 ),EXYNOS_PIN_BANK_EINTG (6 ,0x260 ,"gpj1" ,0x48 ),EXYNOS_PIN_BANK_EINTG (8 ,0x280 ,"gpj2" ,0x4c ),EXYNOS_PIN_BANK_EINTG (8 ,0x2a0 ,"gpj3" ,0x50 ),EXYNOS_PIN_BANK_EINTG (5 ,0x2c0 ,"gpj4" ,0x54 ), +EXYNOS_PIN_BANK_EINTN (7 ,0x220 ,"gpi" ),EXYNOS_PIN_BANK_EINTN (8 ,0x2e0 ,"mp01" ),EXYNOS_PIN_BANK_EINTN (4 ,0x300 ,"mp02" ), EXYNOS_PIN_BANK_EINTN(8, 0x320, "mp03"),
@@ -630,7 +630,6 @@ static const struct samsung_pin_bank_data exynos5410_pin_banks0[] __initconst =EXYNOS_PIN_BANK_EINTG (4 ,0x100 ,"gpc3" ,0x20 ),EXYNOS_PIN_BANK_EINTG (7 ,0x120 ,"gpc1" ,0x24 ),EXYNOS_PIN_BANK_EINTG (7 ,0x140 ,"gpc2" ,0x28 ), -EXYNOS_PIN_BANK_EINTN (2 ,0x160 ,"gpm5" ),EXYNOS_PIN_BANK_EINTG (8 ,0x180 ,"gpd1" ,0x2c ),EXYNOS_PIN_BANK_EINTG (8 ,0x1A0 ,"gpe0" ,0x30 ), EXYNOS_PIN_BANK_EINTG(2, 0x1C0, "gpe1", 0x34),
@@ -641,6 +640,7 @@ static const struct samsung_pin_bank_data exynos5410_pin_banks0[] __initconst =EXYNOS_PIN_BANK_EINTG (2 ,0x260 ,"gpg2" ,0x48 ),EXYNOS_PIN_BANK_EINTG (4 ,0x280 ,"gph0" ,0x4c ),EXYNOS_PIN_BANK_EINTG (8 ,0x2A0 ,"gph1" ,0x50 ), +EXYNOS_PIN_BANK_EINTN (2 ,0x160 ,"gpm5" ),EXYNOS_PIN_BANK_EINTN (8 ,0x2C0 ,"gpm7" ),EXYNOS_PIN_BANK_EINTN (6 ,0x2E0 ,"gpy0" ), EXYNOS_PIN_BANK_EINTN(4, 0x300, "gpy1"),