Skip to contentSkip to conversation

configfs: Replace strncpy with memcpy

PATCH Applied Guenter Roeck 2 participants 2 messages Jul 1, 2018 – Jul 2, 2018 configfs

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configfs: Replace strncpy with memcpy

gcc 8.1.0 complains:

fs/configfs/symlink.c:67:3: warning:
'strncpy' output truncated before terminating nul copying as many bytes from a string as its length
fs/configfs/symlink.c: In function 'configfs_get_link':
fs/configfs/symlink.c:63:13: note: length computed here

Using strncpy() is indeed less than perfect since the length of data to be copied has already been determined with strlen(). Replace strncpy() with memcpy() to address the warning and optimize the code a little.

---
 fs/configfs/symlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/configfs/symlink.c +1 -1
index 78ffc2699993..a5c54af861f7 100644
@@ -64,7 +64,7 @@ static void fill_item_path(struct config_item * item, char * buffer, int length)
 
 		/* back up enough to print this bus id with '/' */
 		length -= cur;
-		strncpy(buffer + length,config_item_name(p),cur);
+		memcpy(buffer + length, config_item_name(p), cur);
 		*(buffer + --length) = '/';
 	}
 }
Signature · 1 line
2.7.4