Skip to contentSkip to conversation

lib: rhashtable: Correct self-assignment in rhashtable.c

PATCH Applied Rishabh Bhatnagar 2 participants 2 messages Jul 2, 2018 – Jul 3, 2018

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib: rhashtable: Correct self-assignment in rhashtable.c

In file lib/rhashtable.c line 777, skip variable is assigned to itself. The following error was observed:

lib/rhashtable.c:777:41: warning: explicitly assigning value of variable of type 'int' to itself [-Wself-assign] error, forbidden
warning: rhashtable.c:777
This error was found when compiling with Clang 6.0. Change it to iter->skip.

---
 lib/rhashtable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/rhashtable.c +1 -1
index 9427b57..3109b2e 100644
@@ -774,7 +774,7 @@ int rhashtable_walk_start_check(struct rhashtable_iter *iter)
 				skip++;
 				if (list == iter->list) {
 					iter->p = p;
-					skip = skip;
+					iter->skip = skip;
 					goto found;
 				}
 			}
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
maintainer Applied
#1 lore raw

From: Rishabh Bhatnagar <[email protected]>
Date: Mon, 2 Jul 2018 09:35:34 -0700

Quoted 11 lines

In file lib/rhashtable.c line 777, skip variable is assigned to itself. The following error was observed:

lib/rhashtable.c:777:41: warning: explicitly assigning value of variable of type 'int' to itself [-Wself-assign] error, forbidden
warning: rhashtable.c:777
This error was found when compiling with Clang 6.0. Change it to iter->skip.

Applied, thanks.