Patch "mtd: cfi_cmdset_0002: Change erase functions to check chip good only" has been added to the 4.14-stable tree
[email protected]
AppliedThis is a note to let you know that I've just added the patch titled
mtd: cfi_cmdset_0002: Change erase functions to check chip good only
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mtd-cfi_cmdset_0002-change-erase-functions-to-check-chip-good-only.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
79ca484b613041ca223f74b34608bb6f5221724bMon Sep 17 00:00:00 2001
From: Tokunori Ikegami <[email protected]>
Date: Wed, 30 May 2018 18:32:29 +0900
Subject: mtd: cfi_cmdset_0002: Change erase functions to check chip good only
From: Tokunori Ikegami <[email protected]>
commit 79ca484b613041ca223f74b34608bb6f5221724b upstream.
Currently the functions use to check both chip ready and good. But the chip ready is not enough to check the operation status. So change this to check the chip good instead of this. About the retry functions to make sure the error handling remain it.
--- drivers/mtd/chips/cfi_cmdset_0002.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-)
drivers/mtd/chips/cfi_cmdset_0002.c +12 -10
@@ -2296,12 +2296,13 @@ static int __xipram do_erase_chip(struct chip->erase_suspended =0 ; } -if (chip_ready (map, adr)) +if (chip_good (map, adr,map_word_ff (map)))break ;if (time_after (jiffies, timeo)) {printk (KERN_WARNING "MTD %s(): software timeout\n" , __func__ ); + ret = -EIO ;break ; }
@@ -2309,15 +2310,15 @@ static int __xipram do_erase_chip(structUDELAY (map, chip, adr,1000000 /HZ ); }/* Did we succeed? */ -if (!chip_good (map, adr,map_word_ff (map))) { +if (ret) {/* reset on all failures. */ map_write ( map,CMD (0xF0 ), chip->start );/* FIXME - should have reset delay before continuing */ -if (++retry_cnt <=MAX_RETRIES ) +if (++retry_cnt <=MAX_RETRIES ) { + ret =0 ; goto retry; - - ret = -EIO ; + } } chip->state =FL_READY ;
@@ -2391,7 +2392,7 @@ static int __xipram do_erase_oneblock(st chip->erase_suspended =0 ; } -if (chip_ready (map, adr)) { +if (chip_good (map, adr,map_word_ff (map))) {xip_enable (map, chip, adr);break ; }
@@ -2400,6 +2401,7 @@ static int __xipram do_erase_oneblock(stxip_enable (map, chip, adr);printk (KERN_WARNING "MTD %s(): software timeout\n" , __func__ ); + ret = -EIO ;break ; }
@@ -2407,15 +2409,15 @@ static int __xipram do_erase_oneblock(stUDELAY (map, chip, adr,1000000 /HZ ); }/* Did we succeed? */ -if (!chip_good (map, adr,map_word_ff (map))) { +if (ret) {/* reset on all failures. */ map_write ( map,CMD (0xF0 ), chip->start );/* FIXME - should have reset delay before continuing */ -if (++retry_cnt <=MAX_RETRIES ) +if (++retry_cnt <=MAX_RETRIES ) { + ret =0 ; goto retry; - - ret = -EIO ; + } } chip->state =FL_READY ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/mtd-cfi_cmdset_0002-change-erase-functions-to-retry-for-error.patch queue-4.14/mtd-cfi_cmdset_0002-change-erase-functions-to-check-chip-good-only.patch queue-4.14/mtd-cfi_cmdset_0002-change-definition-naming-to-retry-write-operation.patch