drm/amd/display: Fix DP HBR2 Eye Diagram Pattern on Carrizo
Subsystems (3)
PATCH 1/1 drm/amd/display: Fix DP HBR2 Eye Diagram Pattern on Carrizo
From: Hersen Wu <[email protected]>
[why] dp hbr2 eye diagram pattern for raven asic is not stabled. workaround is to use tp4 pattern. But this should not be applied to asic before raven.
[how] add new bool varilable in asic caps. for raven asic, use the workaround. for carrizo, vega, do not use workaround.
Change-Id I5e79b8d7b438edf629c6e6e7079de5964e7f95a5
Signed-off-by Hersen Wu <[email protected]>
Reviewed-by Harry Wentland <[email protected]>
Acked-by Leo Li <[email protected]>
--- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 8 +++----- drivers/gpu/drm/amd/display/dc/dc.h | 1 + drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 2 ++ 3 files changed, 6 insertions(+), 5 deletions(-)
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +3 -5
@@ -1781,12 +1781,10 @@ static void dp_test_send_link_training(struct dc_link *link)dp_retrain_link_dp_test (link, &link_settings, false); } -/* TODO hbr2 compliance eye output is unstable +/* TODO Raven hbr2 compliance eye output is unstable * (toggling on and off) with debugger break * This caueses intermittent PHY automation failure * Need to look into the root cause */ -static uint8_t force_tps4_for_cp2520 =1 ; -static void dp_test_send_phy_test_pattern (struct dc_link *link) {union phy_test_pattern dpcd_test_pattern;
@@ -1846,13 +1844,13 @@ static void dp_test_send_phy_test_pattern(struct dc_link *link)break ;case PHY_TEST_PATTERN_CP2520_1 :/* CP2520 pattern is unstable, temporarily use TPS4 instead */ - test_pattern = (force_tps4_for_cp2520 ==1 ) ? + test_pattern = (link->dc->caps.force_dp_tps4_for_cp2520 ==1 ) ?DP_TEST_PATTERN_TRAINING_PATTERN4 :DP_TEST_PATTERN_HBR2_COMPLIANCE_EYE ;break ;case PHY_TEST_PATTERN_CP2520_2 :/* CP2520 pattern is unstable, temporarily use TPS4 instead */ - test_pattern = (force_tps4_for_cp2520 ==1 ) ? + test_pattern = (link->dc->caps.force_dp_tps4_for_cp2520 ==1 ) ?DP_TEST_PATTERN_TRAINING_PATTERN4 :DP_TEST_PATTERN_HBR2_COMPLIANCE_EYE ;break ;
drivers/gpu/drm/amd/display/dc/dc.h +1 -0
@@ -77,6 +77,7 @@ struct dc_caps {bool is_apu;bool dual_link_dvi;bool post_blend_color_processing; +bool force_dp_tps4_for_cp2520; };struct dc_dcc_surface_param {
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c +2 -0
@@ -1127,6 +1127,8 @@ static bool construct( dc->caps.max_slave_planes =1 ; dc->caps.is_apu = true; dc->caps.post_blend_color_processing = false; +/* Raven DP PHY HBR2 eye diagram pattern is not stable. Use TP4 */ + dc->caps.force_dp_tps4_for_cp2520 = true;if (dc->ctx->dce_environment ==DCE_ENV_PRODUCTION_DRV ) dc->debug = debug_defaults_drv;
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx