Skip to contentSkip to conversation

curl: disable C source code generator

PATCH In review Andre McCurdy 3 participants 7 messages Jul 17, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 curl: disable C source code generator

The --libcurl command line option causes curl to generate C source code which, when compiled and linked with libcurl, creates a binary which behaves in the same way as curl when run with the other options passed on the curl command line.

https://curl.haxx.se/docs/manpage.html#--libcurl

It's a development tool and not generally useful on the target, especially if the target doesn't contain a toolchain etc.

---
 meta/recipes-support/curl/curl_7.61.0.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-support/curl/curl_7.61.0.bb +1 -0
index 03d627e..cc983fd 100644
@@ -49,6 +49,7 @@ PACKAGECONFIG[verbose] = "--enable-verbose,--disable-verbose"
 PACKAGECONFIG[zlib] = "--with-zlib=${STAGING_LIBDIR}/../,--without-zlib,zlib"
 
 EXTRA_OECONF = " \
+    --disable-libcurl-option \
     --disable-ntlm-wb \
     --enable-crypto-auth \
     --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt \
Signature · 1 line
1.9.1
#1 lore raw
Quoted 11 lines · Andre McCurdy

The --libcurl command line option causes curl to generate C source code which, when compiled and linked with libcurl, creates a binary which behaves in the same way as curl when run with the other options passed on the curl command line.

https://curl.haxx.se/docs/manpage.html#--libcurl

It's a development tool and not generally useful on the target, especially if the target doesn't contain a toolchain etc.

probably better to have it controlled via packageconfig knob

Quoted 25 lines
---
 meta/recipes-support/curl/curl_7.61.0.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-support/curl/curl_7.61.0.bb +1 -1
index 03d627e..cc983fd 100644
@@ -49,6 +49,7 @@ PACKAGECONFIG[verbose] = "--enable-verbose,--disable-verbose"
 PACKAGECONFIG[zlib] = "--with-zlib=${STAGING_LIBDIR}/../,--without-zlib,zlib"
 
 EXTRA_OECONF = " \
+    --disable-libcurl-option \
     --disable-ntlm-wb \
     --enable-crypto-auth \
     --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt \
--

1.9.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw
Quoted 7 lines · Khem Raj
Quoted 6 lines · Andre McCurdy

The --libcurl command line option causes curl to generate C source code which, when compiled and linked with libcurl, creates a binary which behaves in the same way as curl when run with the other options passed on the curl command line.

Quoted 7 lines
Quoted 5 lines

https://curl.haxx.se/docs/manpage.html#--libcurl

It's a development tool and not generally useful on the target, especially if the target doesn't contain a toolchain etc.

probably better to have it controlled via packageconfig knob

Really? Why?

Quoted 25 lines
Quoted 25 lines
---
 meta/recipes-support/curl/curl_7.61.0.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-support/curl/curl_7.61.0.bb +1 -1
index 03d627e..cc983fd 100644
@@ -49,6 +49,7 @@ PACKAGECONFIG[verbose] = "--enable-verbose,--disable-verbose"
 PACKAGECONFIG[zlib] = "--with-zlib=${STAGING_LIBDIR}/../,--without-zlib,zlib"
 
 EXTRA_OECONF = " \
+    --disable-libcurl-option \
     --disable-ntlm-wb \
     --enable-crypto-auth \
     --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt \
--

1.9.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw
Quoted 11 lines · Andre McCurdy
Quoted 9 lines · Khem Raj
Quoted 8 lines · Andre McCurdy

The --libcurl command line option causes curl to generate C source code which, when compiled and linked with libcurl, creates a binary which behaves in the same way as curl when run with the other options passed on the curl command line.

https://curl.haxx.se/docs/manpage.html#--libcurl

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

It's a development tool and not generally useful on the target, especially if the target doesn't contain a toolchain etc.

probably better to have it controlled via packageconfig knob

Really? Why?

We do have people building SDKs for SBCs which ship development environments on targets and I believe
it does not hurt to use packageconfig. Do you see downsides ?

Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
---
 meta/recipes-support/curl/curl_7.61.0.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-support/curl/curl_7.61.0.bb +1 -1
index 03d627e..cc983fd 100644
@@ -49,6 +49,7 @@ PACKAGECONFIG[verbose] = "--enable-verbose,--disable-verbose"
 PACKAGECONFIG[zlib] = "--with-zlib=${STAGING_LIBDIR}/../,--without-zlib,zlib"
 
 EXTRA_OECONF = " \
+    --disable-libcurl-option \
     --disable-ntlm-wb \
     --enable-crypto-auth \
     --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt \
--

1.9.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw
Quoted 16 lines · Khem Raj
Quoted 15 lines · Andre McCurdy
Quoted 13 lines · Khem Raj
Quoted 11 lines · Andre McCurdy

The --libcurl command line option causes curl to generate C source code which, when compiled and linked with libcurl, creates a binary which behaves in the same way as curl when run with the other options passed on the curl command line.

https://curl.haxx.se/docs/manpage.html#--libcurl

It's a development tool and not generally useful on the target, especially if the target doesn't contain a toolchain etc.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

probably better to have it controlled via packageconfig knob

Really? Why?

We do have people building SDKs for SBCs which ship development environments on targets and I believe
it does not hurt to use packageconfig. Do you see downsides ?

It's an extremely obscure feature and I think PACKAGECONFIG options should be reserved for stuff which we want to advertise as being something a general user might want or need to control.

Of course there are targets which have toolchains, but I think the chance that someone wants or needs to develop fixed function curl replacement binaries on the target is close to zero.

Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
---
 meta/recipes-support/curl/curl_7.61.0.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-support/curl/curl_7.61.0.bb +1 -1
index 03d627e..cc983fd 100644
@@ -49,6 +49,7 @@ PACKAGECONFIG[verbose] = "--enable-verbose,--disable-verbose"
 PACKAGECONFIG[zlib] = "--with-zlib=${STAGING_LIBDIR}/../,--without-zlib,zlib"
 
 EXTRA_OECONF = " \
+    --disable-libcurl-option \
     --disable-ntlm-wb \
     --enable-crypto-auth \
     --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt \
--

1.9.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#5 lore raw
Quoted 26 lines · Andre McCurdy
Quoted 16 lines · Khem Raj
Quoted 15 lines · Andre McCurdy
Quoted 13 lines · Khem Raj
Quoted 11 lines · Andre McCurdy

The --libcurl command line option causes curl to generate C source code which, when compiled and linked with libcurl, creates a binary which behaves in the same way as curl when run with the other options passed on the curl command line.

https://curl.haxx.se/docs/manpage.html#--libcurl

It's a development tool and not generally useful on the target, especially if the target doesn't contain a toolchain etc.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

probably better to have it controlled via packageconfig knob

Really? Why?

We do have people building SDKs for SBCs which ship development environments on targets and I believe
it does not hurt to use packageconfig. Do you see downsides ?

Quoted 8 lines

It's an extremely obscure feature and I think PACKAGECONFIG options should be reserved for stuff which we want to advertise as being something a general user might want or need to control.

Of course there are targets which have toolchains, but I think the chance that someone wants or needs to develop fixed function curl replacement binaries on the target is close to zero.

Since we are disabling a feature, that concerns a bit.

Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
---
 meta/recipes-support/curl/curl_7.61.0.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-support/curl/curl_7.61.0.bb +1 -1
index 03d627e..cc983fd 100644
@@ -49,6 +49,7 @@ PACKAGECONFIG[verbose] = "--enable-verbose,--disable-verbose"
 PACKAGECONFIG[zlib] = "--with-zlib=${STAGING_LIBDIR}/../,--without-zlib,zlib"
 
 EXTRA_OECONF = " \
+    --disable-libcurl-option \
     --disable-ntlm-wb \
     --enable-crypto-auth \
     --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt \
--

1.9.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#6 lore raw
In reply to Andre McCurdy
Quoted 3 lines · Andre McCurdy

It's an extremely obscure feature and I think PACKAGECONFIG options should be reserved for stuff which we want to advertise as being something a general user might want or need to control.

FWIW, agreed.

Ross