drm/amdgpu: lock and unlock console only for amdgpu_fbdev_set_suspend [V3]
Subsystems (2)
PATCH 1/1 drm/amdgpu: lock and unlock console only for amdgpu_fbdev_set_suspend [V3]
[Why]
While the console_lock is held, console output will be buffered, till its unlocked it wont be emitted, hence its ideal to unlock sooner to enable debugging/detecting/fixing of any issue in the remaining sequence of events in resume path.
The concern here is about consoles other than fbcon on the device, e.g. a serial console
[How]
This patch restructures the console_lock, console_unlock around amdgpu_fbdev_set_suspend() and moves this new block appropriately.
V2: Kept amdgpu_fbdev_set_suspend after pci_set_power_state
V3: Updated the commit message to clarify the real concern that this patch
addresses.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +3 -9
@@ -2720,9 +2720,6 @@ int amdgpu_device_resume(struct drm_device *dev, bool resume, bool fbcon)if (dev->switch_power_state ==DRM_SWITCH_POWER_OFF )return 0 ; -if (fbcon) -console_lock (); -if (resume) {pci_set_power_state (dev->pdev,PCI_D0 );pci_restore_state (dev->pdev);
@@ -2784,6 +2781,9 @@ int amdgpu_device_resume(struct drm_device *dev, bool resume, bool fbcon) }drm_modeset_unlock_all (dev); } +console_lock (); +amdgpu_fbdev_set_suspend (adev,0 ); +console_unlock (); }drm_kms_helper_poll_enable (dev);
@@ -2808,13 +2808,7 @@ int amdgpu_device_resume(struct drm_device *dev, bool resume, bool fbcon) dev->dev->power.disable_depth--;#endif -if (fbcon) -amdgpu_fbdev_set_suspend (adev,0 ); - unlock: -if (fbcon) -console_unlock (); -return r; }
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1531992569-5849-1-git-send-email-shirish.s-5C7GfCeVMHo@public.gmane.org
Quoted 26 lines · Shirish S
[Why]
While theconsole_lockis held, console output will be buffered, till its unlocked it wont be emitted, hence its ideal to unlock sooner to enable debugging/detecting/fixing of any issue in the remaining sequence of events in resume path.
The concern here is about consoles other than fbcon on the device, e.g. a serial console[How]
This patch restructures theconsole_lock,console_unlockaroundamdgpu_fbdev_set_suspend()and moves this new block appropriately.V2: Kept
amdgpu_fbdev_set_suspendafterpci_set_power_state
V3: Updated the commit message to clarify the real concern that this patch
addresses.Signed-off-by Shirish S <[email protected]>Reviewed-by Michel Dänzer <[email protected]>[...]
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-0drm_kms_helper_poll_enable (dev);@@ -2808,13 +2808,7 @@ int amdgpu_device_resume(struct drm_device *dev, bool resume, bool fbcon) dev->dev->power.disable_depth--;#endif
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c int amdgpu_device_resume(struct drm_device *dev, bool resume, bool fbcon) · line 2814
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-6-if (fbcon) -amdgpu_fbdev_set_suspend (adev,0 ); - unlock: -if (fbcon) -console_unlock (); -return r; }
Oh, please remove the now useless unlock label as well. Sorry I missed that before.
Signature · 6 lines
Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx