drm/i915/dp: Remove unneeded mav_vswing_tries variable
Subsystems (2)
PATCH v4 2/2 drm/i915/dp: Remove unneeded mav_vswing_tries variable
max_vswing_tries variable was declared as an int but used as a bool and not even needed because we can just check the return of intel_dp_link_max_vswing_reached.
Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Marc Herbert <[email protected]>
Signed-off-by Nathan Ciobanu <[email protected]>
--- drivers/gpu/drm/i915/intel_dp_link_training.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/intel_dp_link_training.c +5 -9
@@ -129,7 +129,7 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) intel_dp_link_training_clock_recovery(struct intel_dp *intel_dp) {uint8_t voltage; -int voltage_tries, max_vswing_tries, cr_tries, max_cr_tries; +int voltage_tries, cr_tries, max_cr_tries;uint8_t link_config[2 ];uint8_t link_bw, rate_select;
@@ -181,7 +181,6 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) max_cr_tries =80 ; voltage_tries =1 ; - max_vswing_tries =0 ;for (cr_tries =0 ; cr_tries < max_cr_tries; ++cr_tries) {uint8_t link_status[DP_LINK_STATUS_SIZE ];
@@ -202,11 +201,6 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp)return false; } -if (max_vswing_tries ==1 ) { -DRM_DEBUG_KMS ("Max Voltage Swing reached\n" ); -return false; - } - voltage = intel_dp->train_set[0 ] &DP_TRAIN_VOLTAGE_SWING_MASK ;/* Update training set as requested by target */
@@ -222,8 +216,10 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp)else voltage_tries =1 ; -if (intel_dp_link_max_vswing_reached (intel_dp)) - ++max_vswing_tries; +if (intel_dp_link_max_vswing_reached (intel_dp)) { +DRM_DEBUG_KMS ("Max Voltage Swing reached\n" ); +return false; + } }DRM_ERROR ("Failed clock recovery %d times, giving up!\n" , max_cr_tries);
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx