patch "USB: serial: sierra: fix potential deadlock at close" added to usb-testing
Subsystems (3)
This is a note to let you know that I've just added the patch titled
USB: serial: sierra: fix potential deadlock at close
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will be merged to the usb-next branch sometime soon, after it passes testing, and the merge window is open.
If you have any questions about this process, please let me know.
Quoted 1 line
From
e60870012e5a35b1506d7b376fddfb30e9da0b27Mon Sep 17 00:00:00 2001
From: John Ogness <[email protected]>
Date: Sun, 24 Jun 2018 00:32:11 +0200
Subject: USB: serial: sierra: fix potential deadlock at close
The portdata spinlock can be taken in interrupt context (via sierra_outdat_callback()).
Disable interrupts when taking the portdata spinlock when discarding deferred URBs during close to prevent a possible deadlock.
--- drivers/usb/serial/sierra.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/serial/sierra.c +2 -2
@@ -770,9 +770,9 @@ static void sierra_close(struct usb_serial_port *port)kfree (urb->transfer_buffer);usb_free_urb (urb);usb_autopm_put_interface_async (serial->interface); -spin_lock (&portdata->lock); +spin_lock_irq (&portdata->lock); portdata->outstanding_urbs--; -spin_unlock (&portdata->lock); +spin_unlock_irq (&portdata->lock); }sierra_stop_rx_urbs (port);
Signature · 1 line
2.18.0