Skip to contentSkip to conversation

cpu/hotplug: Fix cpuhp_step name for timers

PATCH Superseded Mukesh Ojha 1 participant 2 messages Jul 24, 2018 CPU hotplug

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpu/hotplug: Fix cpuhp_step name for timers

After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE instead of CPUHP_TIMERS_DEAD the cpuhp_step name "timers:dead" for timer looks to invalid. So, better to name it as "timers:prepare".

Cc Thomas Gleixner <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Lai Jiangshan <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Brendan Jackman <[email protected]>
Cc Mathieu Malaterre <[email protected]>
---
 kernel/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/cpu.c +1 -1
index 0db8938..8e6606a 100644
@@ -1274,7 +1274,7 @@ static int __init cpu_hotplug_pm_sync_init(void)
 	 * otherwise a RCU stall occurs.
 	 */
 	[CPUHP_TIMERS_PREPARE] = {
-		.name			= "timers:dead",
+		.name			= "timers:prepare",
 		.startup.single		= timers_prepare_cpu,
 		.teardown.single	= timers_dead_cpu,
 	},
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
#1 lore raw

Hi All,

Please review V2 where i will be updating(minor) commit text.

Thanks.
Mukesh

Quoted 30 lines · Mukesh Ojha

After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE instead of CPUHP_TIMERS_DEAD the cpuhp_step name "timers:dead" for timer looks to invalid. So, better to name it as "timers:prepare".

Cc Thomas Gleixner <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Lai Jiangshan <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Brendan Jackman <[email protected]>
Cc Mathieu Malaterre <[email protected]>
---
  kernel/cpu.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
kernel/cpu.c +1 -1
index 0db8938..8e6606a 100644
@@ -1274,7 +1274,7 @@ static int __init cpu_hotplug_pm_sync_init(void)
  	 * otherwise a RCU stall occurs.
  	 */
  	[CPUHP_TIMERS_PREPARE] = {
-		.name			= "timers:dead",
+		.name			= "timers:prepare",
  		.startup.single		= timers_prepare_cpu,
  		.teardown.single	= timers_dead_cpu,
  	},