Skip to contentSkip to conversation

Driver for MaxLinear/Exar USB (UART) Serial Adapters

DISCUSSION Oliver Neukum 1 participant 1 message Jul 25, 2018 USB

lore
Share & tools
lore
#0 lore raw

Review

Quoted 12 lines · Patong Yang
(quoted diff) +12 -0
+static int xrusb_ctrl_msg(struct xrusb *xrusb,
+               int request, int value, void *buf, int len)
+{
+       int rv = usb_control_msg(xrusb->dev,
+               usb_sndctrlpipe(xrusb->dev, 0),
+               request,
+               USB_RT_XRUSB,
+               value,
+               xrusb->control->altsetting[0].desc.bInterfaceNumber,
+               buf,
+               len,
+               5000);

Please use the symbolic constant.

Review

Quoted 2 lines
(quoted diff) +2 -0
+       return rv < 0 ? rv : 0;
+}

Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html