Skip to contentSkip to conversation

Patch "kvm, mm: account shadow page tables to kmemcg" has been added to the 4.4-stable tree

DISCUSSION Shakeel Butt 2 participants 2 messages Jul 30, 2018 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 9 lines · On Sat, Jul 28, 2018 at 1:11 AM <[email protected]> wrote:

This is a note to let you know that I've just added the patch titled

kvm, mm: account shadow page tables to kmemcg

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 7 lines

The filename of the patch is:
kvm-mm-account-shadow-page-tables-to-kmemcg.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Hi Greg, this patch requires some more changes to be effective on 4.4 kernel as kmem charging is still not in the generic page allocator code path in 4.4.

Shakeel

Quoted 54 lines

From d97e5e6160c0e0a23963ec198c7cb1c69e6bf9e8 Mon Sep 17 00:00:00 2001
From: Shakeel Butt <[email protected]>
Date: Thu, 26 Jul 2018 16:37:45 -0700
Subject: kvm, mm: account shadow page tables to kmemcg
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Shakeel Butt <[email protected]>

commit d97e5e6160c0e0a23963ec198c7cb1c69e6bf9e8 upstream.

The size of kvm's shadow page tables corresponds to the size of the guest virtual machines on the system. Large VMs can spend a significant amount of memory as shadow page tables which can not be left as system memory overhead. So, account shadow page tables to the kmemcg.

---
 arch/x86/kvm/mmu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/mmu.c +1 -1
@@ -692,7 +692,7 @@ static int mmu_topup_memory_cache_page(s
        if (cache->nobjs >= min)
                return 0;
        while (cache->nobjs < ARRAY_SIZE(cache->objects)) {
-               page = (void *)__get_free_page(GFP_KERNEL);
+               page = (void *)__get_free_page(GFP_KERNEL_ACCOUNT);
                if (!page)
                        return -ENOMEM;
                cache->objects[cache->nobjs++] = page;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/kvm-mm-account-shadow-page-tables-to-kmemcg.patch

maintainer
#2 lore raw
Quoted 14 lines · Shakeel Butt
Quoted 13 lines · On Sat, Jul 28, 2018 at 1:11 AM <[email protected]> wrote:

This is a note to let you know that I've just added the patch titled

kvm, mm: account shadow page tables to kmemcg

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
kvm-mm-account-shadow-page-tables-to-kmemcg.patch
and it can be found in the queue-4.4 subdirectory.

Quoted 7 lines
Quoted 3 lines

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Hi Greg, this patch requires some more changes to be effective on 4.4 kernel as kmem charging is still not in the generic page allocator code path in 4.4.

It is dropped from the 4.4 stable queue as it broke the build, sorry for not mentioning it here.

greg k-h