Skip to contentSkip to conversation

openssl_1.0: drop unnecessary dependency on makedepend-native

PATCH In review Andre McCurdy 3 participants 7 messages Jul 31, 2018 – Aug 2, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 openssl_1.0: drop unnecessary dependency on makedepend-native

The openssl Configure script will only select standalone makedepend (vs running "$CC -M") when building with gcc < 3.x or with an Apple Xcode version which predates the switch to clang (in approx 2010?). Neither of these cases are possible when building under OE, therefore the dependency on makedepend-native can be dropped (ie align the openssl 1.0 recipe with the 1.1 recipe, which has dropped the makedepend-native dependency already).

---
 meta/recipes-connectivity/openssl/openssl_1.0.2o.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-connectivity/openssl/openssl_1.0.2o.bb +1 -1
index f5d3274..78c8552 100644
@@ -8,7 +8,7 @@ SECTION = "libs/network"
 LICENSE = "openssl"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=f475368924827d06d4b416111c8bdb77"
 
-DEPENDS = "makedepend-native hostperl-runtime-native"
+DEPENDS = "hostperl-runtime-native"
 DEPENDS_append_class-target = " openssl-native"
 
 PROVIDES += "openssl10"
Signature · 1 line
1.9.1
#1 lore raw
Quoted 23 lines · Andre McCurdy

The openssl Configure script will only select standalone makedepend (vs running "$CC -M") when building with gcc < 3.x or with an Apple Xcode version which predates the switch to clang (in approx 2010?). Neither of these cases are possible when building under OE, therefore the dependency on makedepend-native can be dropped (ie align the openssl 1.0 recipe with the 1.1 recipe, which has dropped the makedepend-native dependency already).

---
 meta/recipes-connectivity/openssl/openssl_1.0.2o.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-connectivity/openssl/openssl_1.0.2o.bb +0 -0
index f5d3274..78c8552 100644
@@ -8,7 +8,7 @@ SECTION = "libs/network"
 LICENSE = "openssl"
 LIC_FILES_CHKSUM =

"file://LICENSE;md5=f475368924827d06d4b416111c8bdb77"

meta/recipes-connectivity/openssl/openssl_1.0.2o.bb SECTION = "libs/network" · line 14

Quoted 5 lines
meta/recipes-connectivity/openssl/openssl_1.0.2o.bb +1 -1
-DEPENDS = "makedepend-native hostperl-runtime-native"
+DEPENDS = "hostperl-runtime-native"
 DEPENDS_append_class-target = " openssl-native"
 
 PROVIDES += "openssl10"

This was added quite 'recently' in:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=50c23e6c26a64b0c04e99abacb61ec00d1abace9

I've cc'd Andrej in case he can tell us why that was needed?

Cheers,

Richard

#2 lore raw

This program is required for "oe_runmake depend" command. It runs command in MAKEDEPPROG variable, which is set to makedepend. Makedepend consists from makedepend-native package.

Cheers,
Andrej

Quoted 40 lines · Richard Purdie
Quoted 23 lines · Andre McCurdy

The openssl Configure script will only select standalone makedepend (vs running "$CC -M") when building with gcc < 3.x or with an Apple Xcode version which predates the switch to clang (in approx 2010?). Neither of these cases are possible when building under OE, therefore the dependency on makedepend-native can be dropped (ie align the openssl 1.0 recipe with the 1.1 recipe, which has dropped the makedepend-native dependency already).

---
 meta/recipes-connectivity/openssl/openssl_1.0.2o.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-connectivity/openssl/openssl_1.0.2o.bb +0 -0
index f5d3274..78c8552 100644
@@ -8,7 +8,7 @@ SECTION = "libs/network"
 LICENSE = "openssl"
 LIC_FILES_CHKSUM =

"file://LICENSE;md5=f475368924827d06d4b416111c8bdb77"

meta/recipes-connectivity/openssl/openssl_1.0.2o.bb SECTION = "libs/network" · line 14

Quoted 5 lines
meta/recipes-connectivity/openssl/openssl_1.0.2o.bb +1 -1
-DEPENDS = "makedepend-native hostperl-runtime-native"
+DEPENDS = "hostperl-runtime-native"
 DEPENDS_append_class-target = " openssl-native"
 
 PROVIDES += "openssl10"

This was added quite 'recently' in:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=50c23e6c26a64b0c04e99abacb61ec00d1abace9

I've cc'd Andrej in case he can tell us why that was needed?

Cheers,

Richard

#3 lore raw
Quoted 3 lines · Andrej Valek

This program is required for "oe_runmake depend" command. It runs command in MAKEDEPPROG variable, which is set to makedepend. Makedepend consists from makedepend-native package.

That's what you might guess from casually reading the Makefile. It's not what actually happens.

Quoted 44 lines

Cheers,
Andrej

Quoted 40 lines · Richard Purdie
Quoted 23 lines · Andre McCurdy

The openssl Configure script will only select standalone makedepend (vs running "$CC -M") when building with gcc < 3.x or with an Apple Xcode version which predates the switch to clang (in approx 2010?). Neither of these cases are possible when building under OE, therefore the dependency on makedepend-native can be dropped (ie align the openssl 1.0 recipe with the 1.1 recipe, which has dropped the makedepend-native dependency already).

---
 meta/recipes-connectivity/openssl/openssl_1.0.2o.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-connectivity/openssl/openssl_1.0.2o.bb +0 -0
index f5d3274..78c8552 100644
@@ -8,7 +8,7 @@ SECTION = "libs/network"
 LICENSE = "openssl"
 LIC_FILES_CHKSUM =

"file://LICENSE;md5=f475368924827d06d4b416111c8bdb77"

meta/recipes-connectivity/openssl/openssl_1.0.2o.bb SECTION = "libs/network" · line 14

Quoted 5 lines
meta/recipes-connectivity/openssl/openssl_1.0.2o.bb +1 -1
-DEPENDS = "makedepend-native hostperl-runtime-native"
+DEPENDS = "hostperl-runtime-native"
 DEPENDS_append_class-target = " openssl-native"
 
 PROVIDES += "openssl10"

This was added quite 'recently' in:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=50c23e6c26a64b0c04e99abacb61ec00d1abace9

I've cc'd Andrej in case he can tell us why that was needed?

Cheers,

Richard

#4 lore raw

If you are pretty sure, that makedepend command will available after makedepend-native package dropping, I am fine with that.

Cheers,
Andrej

Quoted 52 lines · Andre McCurdy
Quoted 3 lines · Andrej Valek

This program is required for "oe_runmake depend" command. It runs command in MAKEDEPPROG variable, which is set to makedepend. Makedepend consists from makedepend-native package.

That's what you might guess from casually reading the Makefile. It's not what actually happens.

Quoted 44 lines

Cheers,
Andrej

Quoted 40 lines · Richard Purdie
Quoted 23 lines · Andre McCurdy

The openssl Configure script will only select standalone makedepend (vs running "$CC -M") when building with gcc < 3.x or with an Apple Xcode version which predates the switch to clang (in approx 2010?). Neither of these cases are possible when building under OE, therefore the dependency on makedepend-native can be dropped (ie align the openssl 1.0 recipe with the 1.1 recipe, which has dropped the makedepend-native dependency already).

---
 meta/recipes-connectivity/openssl/openssl_1.0.2o.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-connectivity/openssl/openssl_1.0.2o.bb +0 -0
index f5d3274..78c8552 100644
@@ -8,7 +8,7 @@ SECTION = "libs/network"
 LICENSE = "openssl"
 LIC_FILES_CHKSUM =

"file://LICENSE;md5=f475368924827d06d4b416111c8bdb77"

meta/recipes-connectivity/openssl/openssl_1.0.2o.bb SECTION = "libs/network" · line 14

Quoted 5 lines
meta/recipes-connectivity/openssl/openssl_1.0.2o.bb +1 -1
-DEPENDS = "makedepend-native hostperl-runtime-native"
+DEPENDS = "hostperl-runtime-native"
 DEPENDS_append_class-target = " openssl-native"
 
 PROVIDES += "openssl10"

This was added quite 'recently' in:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=50c23e6c26a64b0c04e99abacb61ec00d1abace9

I've cc'd Andrej in case he can tell us why that was needed?

Cheers,

Richard

#5 lore raw
Quoted 2 lines · Andrej Valek

If you are pretty sure, that makedepend command will available after makedepend-native package dropping, I am fine with that.

I am sure that the makedepend command will NOT be available after removing the makedepend-native dependency.

Perhaps the explanation I tried to give in the git commit wasn't as clear as I thought... could you please read it and let me know which part doesn't make sense?

Quoted 56 lines

Cheers,
Andrej

Quoted 52 lines · Andre McCurdy
Quoted 3 lines · Andrej Valek

This program is required for "oe_runmake depend" command. It runs command in MAKEDEPPROG variable, which is set to makedepend. Makedepend consists from makedepend-native package.

That's what you might guess from casually reading the Makefile. It's not what actually happens.

Quoted 44 lines

Cheers,
Andrej

Quoted 40 lines · Richard Purdie
Quoted 23 lines · Andre McCurdy

The openssl Configure script will only select standalone makedepend (vs running "$CC -M") when building with gcc < 3.x or with an Apple Xcode version which predates the switch to clang (in approx 2010?). Neither of these cases are possible when building under OE, therefore the dependency on makedepend-native can be dropped (ie align the openssl 1.0 recipe with the 1.1 recipe, which has dropped the makedepend-native dependency already).

---
 meta/recipes-connectivity/openssl/openssl_1.0.2o.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-connectivity/openssl/openssl_1.0.2o.bb +0 -0
index f5d3274..78c8552 100644
@@ -8,7 +8,7 @@ SECTION = "libs/network"
 LICENSE = "openssl"
 LIC_FILES_CHKSUM =

"file://LICENSE;md5=f475368924827d06d4b416111c8bdb77"

meta/recipes-connectivity/openssl/openssl_1.0.2o.bb SECTION = "libs/network" · line 14

Quoted 5 lines
meta/recipes-connectivity/openssl/openssl_1.0.2o.bb +1 -1
-DEPENDS = "makedepend-native hostperl-runtime-native"
+DEPENDS = "hostperl-runtime-native"
 DEPENDS_append_class-target = " openssl-native"
 
 PROVIDES += "openssl10"

This was added quite 'recently' in:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=50c23e6c26a64b0c04e99abacb61ec00d1abace9

I've cc'd Andrej in case he can tell us why that was needed?

Cheers,

Richard

#6 lore raw

I have checked it, and it works. MAKEDEPPROG was set to cross-tool and on native site it's set to gcc. So it looks like, that the dependency to makedepend-native package is unneeded.

Quoted 67 lines · Andre McCurdy
Quoted 2 lines · Andrej Valek

If you are pretty sure, that makedepend command will available after makedepend-native package dropping, I am fine with that.

I am sure that the makedepend command will NOT be available after removing the makedepend-native dependency.

Perhaps the explanation I tried to give in the git commit wasn't as clear as I thought... could you please read it and let me know which part doesn't make sense?

Quoted 56 lines

Cheers,
Andrej

Quoted 52 lines · Andre McCurdy
Quoted 3 lines · Andrej Valek

This program is required for "oe_runmake depend" command. It runs command in MAKEDEPPROG variable, which is set to makedepend. Makedepend consists from makedepend-native package.

That's what you might guess from casually reading the Makefile. It's not what actually happens.

Quoted 44 lines

Cheers,
Andrej

Quoted 40 lines · Richard Purdie
Quoted 23 lines · Andre McCurdy

The openssl Configure script will only select standalone makedepend (vs running "$CC -M") when building with gcc < 3.x or with an Apple Xcode version which predates the switch to clang (in approx 2010?). Neither of these cases are possible when building under OE, therefore the dependency on makedepend-native can be dropped (ie align the openssl 1.0 recipe with the 1.1 recipe, which has dropped the makedepend-native dependency already).

---
 meta/recipes-connectivity/openssl/openssl_1.0.2o.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-connectivity/openssl/openssl_1.0.2o.bb +0 -0
index f5d3274..78c8552 100644
@@ -8,7 +8,7 @@ SECTION = "libs/network"
 LICENSE = "openssl"
 LIC_FILES_CHKSUM =

"file://LICENSE;md5=f475368924827d06d4b416111c8bdb77"

meta/recipes-connectivity/openssl/openssl_1.0.2o.bb SECTION = "libs/network" · line 14

Quoted 5 lines
meta/recipes-connectivity/openssl/openssl_1.0.2o.bb +1 -1
-DEPENDS = "makedepend-native hostperl-runtime-native"
+DEPENDS = "hostperl-runtime-native"
 DEPENDS_append_class-target = " openssl-native"
 
 PROVIDES += "openssl10"

This was added quite 'recently' in:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=50c23e6c26a64b0c04e99abacb61ec00d1abace9

I've cc'd Andrej in case he can tell us why that was needed?

Cheers,

Richard