Patch "usb/phy: fix PPC64 build errors in phy-fsl-usb.c" has been added to the 3.18-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
usb/phy: fix PPC64 build errors in phy-fsl-usb.c
to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-phy-fix-ppc64-build-errors-in-phy-fsl-usb.c.patch
and it can be found in the queue-3.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Tue Aug 28 16:08:28 CEST 2018
From: Randy Dunlap <[email protected]>
Date: Sun, 15 Jul 2018 10:37:37 -0700
Subject: usb/phy: fix PPC64 build errors in phy-fsl-usb.c
From: Randy Dunlap <[email protected]>
[ Upstream commit a39ba90a1cc7010edb0a7132e1b67f3d80b994e9 ]
Fix build errors when built for PPC64:
These variables are only used on PPC32 so they don't need to be initialized for PPC64.
../drivers/usb/phy/phy-fsl-usb.c: In function 'usb_otg_start':../drivers/usb/phy/phy-fsl-usb.c:865:3: error: '_fsl_readl' undeclared (first use in this function); did you mean 'fsl_readl'?
_fsl_readl = _fsl_readl_be;../drivers/usb/phy/phy-fsl-usb.c:865:16: error: '_fsl_readl_be' undeclared (first use in this function); did you mean 'fsl_readl'?
_fsl_readl = _fsl_readl_be;../drivers/usb/phy/phy-fsl-usb.c:866:3: error: '_fsl_writel' undeclared (first use in this function); did you mean 'fsl_writel'?
_fsl_writel = _fsl_writel_be;../drivers/usb/phy/phy-fsl-usb.c:866:17: error: '_fsl_writel_be' undeclared (first use in this function); did you mean 'fsl_writel'?
_fsl_writel = _fsl_writel_be;../drivers/usb/phy/phy-fsl-usb.c:868:16: error: '_fsl_readl_le' undeclared (first use in this function); did you mean 'fsl_readl'?
_fsl_readl = _fsl_readl_le;../drivers/usb/phy/phy-fsl-usb.c:869:17: error: '_fsl_writel_le' undeclared (first use in this function); did you mean 'fsl_writel'?
_fsl_writel = _fsl_writel_le;
and the sysfs "show" function return type should be ssize_t, not int:
../drivers/usb/phy/phy-fsl-usb.c:1042:49: error: initialization of 'ssize_t (*)(struct device *, struct device_attribute *, char *)' {aka 'long int (*)(struct device *, struct device_attribute *, char *)'} from incompatible pointer type 'int (*)(struct device *, struct device_attribute *, char *)' [-Werror=incompatible-pointer-types]
static DEVICE_ATTR(fsl_usb2_otg_state, S_IRUGO, show_fsl_usb2_otg_state, NULL);
--- drivers/usb/phy/phy-fsl-usb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/phy/phy-fsl-usb.c +3 -1
@@ -913,6 +913,7 @@ int usb_otg_start(struct platform_deviceif (pdata->init && pdata->init (pdev) !=0 )return -EINVAL ; +#ifdef CONFIG_PPC32 if (pdata->big_endian_mmio) { _fsl_readl = _fsl_readl_be; _fsl_writel = _fsl_writel_be;
@@ -920,6 +921,7 @@ int usb_otg_start(struct platform_device _fsl_readl = _fsl_readl_le; _fsl_writel = _fsl_writel_le; } +#endif /* request irq */ p_otg->irq =platform_get_irq (pdev,0 );
@@ -1010,7 +1012,7 @@ int usb_otg_start(struct platform_device/* * state file in sysfs */ -static int show_fsl_usb2_otg_state (struct device *dev, +static ssize_t show_fsl_usb2_otg_state (struct device *dev,struct device_attribute *attr,char *buf) {struct otg_fsm *fsm = &fsl_otg_dev->fsm;
Patches currently in stable-queue which might be from [email protected] are
queue-3.18/usb-phy-fix-ppc64-build-errors-in-phy-fsl-usb.c.patch queue-3.18/arc-fix-build-errors-in-arc-include-asm-delay.h.patch queue-3.18/media-staging-omap4iss-include-asm-cacheflush.h-after-generic-includes.patch queue-3.18/arc-fix-type-warnings-in-arc-mm-cache.c.patch