FAILED: patch "[PATCH] ASoC: wm8994: Fix missing break in switch" failed to apply to 4.18-stable tree
Subsystems (4)
[email protected]
maintainerThe patch below does not apply to the 4.18-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
Quoted 1 line
From
ad0eaee6195db1db1749dd46b9e6f4466793d178Mon Sep 17 00:00:00 2001
From: "Gustavo A. R. Silva" <[email protected]>
Date: Mon, 6 Aug 2018 07:14:51 -0500
Subject: [PATCH] ASoC: wm8994: Fix missing break in switch
Add missing break statement in order to prevent the code from falling through to the default case.
Addresses-Coverity-ID: 115050 ("Missing break in switch")
sound/soc/codecs/wm8994.c +1 -1
@@ -2432,7 +2432,7 @@ static int wm8994_set_dai_sysclk(struct snd_soc_dai *dai,snd_soc_component_update_bits (component,WM8994_POWER_MANAGEMENT_2 ,WM8994_OPCLK_ENA ,0 ); } -/* fall through */ +break ;default :return -EINVAL ;
Hi all,
I got this.
--
Gustavo
Quoted 41 lines · On 9/2/18 12:52 PM, [email protected] wrote:
The patch below does not apply to the 4.18-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From
ad0eaee6195db1db1749dd46b9e6f4466793d178Mon Sep 17 00:00:00 2001
From: "Gustavo A. R. Silva" <[email protected]>
Date: Mon, 6 Aug 2018 07:14:51 -0500
Subject: [PATCH] ASoC: wm8994: Fix missing break in switchAdd missing break statement in order to prevent the code from falling through to the default case.
Addresses-Coverity-ID: 115050 ("Missing break in switch")
Reported-by Valdis Kletnieks <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>Acked-by Charles Keepax <[email protected]>Signed-off-by Mark Brown <[email protected]>sound/soc/codecs/wm8994.c +1
-1@@ -2432,7 +2432,7 @@ static int wm8994_set_dai_sysclk(struct snd_soc_dai *dai,snd_soc_component_update_bits (component,WM8994_POWER_MANAGEMENT_2 ,WM8994_OPCLK_ENA ,0 ); } -/* fall through */ +break ;default :return -EINVAL ;