Skip to contentSkip to conversation

USB: change dev_WARN to dev_err triggerable from user space

DISCUSSION Oliver Neukum 1 participant 1 message Sep 4, 2018 USB

lore
Share & tools
lore
#0 lore raw
Quoted 8 lines · Johan Hovold
Quoted 2 lines · Oliver Neukum

For those people who run with panic_on_warn a WARN() triggered from user space is a DOS. It is worth returning to dev_err()

I think this should be dev_warn() unless you want to bring back the returning of errors on these conditions as well (i.e. as was the case prior to 0cb54a3e47cb ("USB: debugging code shouldn't alter control flow")).

Should I? A warning in syslog is pretty hardcore, so I have no idea whether dev_warn() is enough.

Regards
Oliver