Skip to contentSkip to conversation

x86/intel_rdt: Show missing resctrl mount options

PATCH New Fenghua Yu 2 participants 3 messages Sep 12, 2018 – Oct 3, 2018 x86

lore
Share & tools
lore

Fenghua Yu

author
#0 lore raw

PATCH v2 1/1 x86/intel_rdt: Show missing resctrl mount options

From: Xiaochen Shen <[email protected]>

In resctrl filesystem, we have some mount options to enable L3/L2 CDP and MBA Software Controller features if platform supports them:
mount -t resctrl resctrl [-o cdp[,cdpl2][,mba_MBps]] /sys/fs/resctrl

But currently only "cdp" option can be displayed. "cdpl2" and "mba_MBps" options are not showed even when they are active mount options.

Before this patch:
#mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl #grep resctrl /proc/mounts
/sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp 0 0
After this patch:
#mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl #grep resctrl /proc/mountts
/sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp,mba_MBps 0 0

---
 arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 7 +++++++
 1 file changed, 7 insertions(+)
arch/x86/kernel/cpu/intel_rdt_rdtgroup.c +7 -0
index b799c00bef09..82459a41fa84 100644
@@ -2760,6 +2760,13 @@ static int rdtgroup_show_options(struct seq_file *seq, struct kernfs_root *kf)
 {
 	if (rdt_resources_all[RDT_RESOURCE_L3DATA].alloc_enabled)
 		seq_puts(seq, ",cdp");
+
+	if (rdt_resources_all[RDT_RESOURCE_L2DATA].alloc_enabled)
+		seq_puts(seq, ",cdpl2");
+
+	if (is_mba_sc(&rdt_resources_all[RDT_RESOURCE_MBA]))
+		seq_puts(seq, ",mba_MBps");
+
 	return 0;
 }
 
Signature · 1 line
2.19.0
#1 lore raw
x86/intel_rdt: Show missing resctrl mount options
Commit-ID:  32ece95d3052e0778eab98fd9c2ffde92c599ce9
Gitweb:     https://git.kernel.org/tip/32ece95d3052e0778eab98fd9c2ffde92c599ce9
Author:     Xiaochen Shen <[email protected]>
AuthorDate: Wed, 12 Sep 2018 16:48:38 -0700
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Wed, 3 Oct 2018 16:19:36 +0200

x86/intel_rdt: Show missing resctrl mount options

In resctrl filesystem, mount options exist to enable L3/L2 CDP and MBA Software Controller features if the platform supports them:

mount -t resctrl resctrl [-o cdp[,cdpl2][,mba_MBps]] /sys/fs/resctrl

But currently only "cdp" option is displayed in /proc/mounts. "cdpl2" and "mba_MBps" options are not shown even when they are active.

Before:

 # mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl
 # grep resctrl /proc/mounts
 /sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp 0 0

After:

 # mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl
 # grep resctrl /proc/mounts
 /sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp,mba_MBps 0 0
---
 arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 7 +++++++
 1 file changed, 7 insertions(+)
arch/x86/kernel/cpu/intel_rdt_rdtgroup.c +7 -0
index 1b8e86a5d5e1..82a487840eb2 100644
@@ -2795,6 +2795,13 @@ static int rdtgroup_show_options(struct seq_file *seq, struct kernfs_root *kf)
 {
 	if (rdt_resources_all[RDT_RESOURCE_L3DATA].alloc_enabled)
 		seq_puts(seq, ",cdp");
+
+	if (rdt_resources_all[RDT_RESOURCE_L2DATA].alloc_enabled)
+		seq_puts(seq, ",cdpl2");
+
+	if (is_mba_sc(&rdt_resources_all[RDT_RESOURCE_MBA]))
+		seq_puts(seq, ",mba_MBps");
+
 	return 0;
 }
 
#2 lore raw
In reply to Fenghua Yu
x86/intel_rdt: Show missing resctrl mount options
Commit-ID:  2cc81c6992248ea37d0241bc325977bab310bc3b
Gitweb:     https://git.kernel.org/tip/2cc81c6992248ea37d0241bc325977bab310bc3b
Author:     Xiaochen Shen <[email protected]>
AuthorDate: Wed, 12 Sep 2018 16:48:38 -0700
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Wed, 3 Oct 2018 21:53:49 +0200

x86/intel_rdt: Show missing resctrl mount options

In resctrl filesystem, mount options exist to enable L3/L2 CDP and MBA Software Controller features if the platform supports them:

mount -t resctrl resctrl [-o cdp[,cdpl2][,mba_MBps]] /sys/fs/resctrl

But currently only "cdp" option is displayed in /proc/mounts. "cdpl2" and "mba_MBps" options are not shown even when they are active.

Before:

 # mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl
 # grep resctrl /proc/mounts
 /sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp 0 0

After:

 # mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl
 # grep resctrl /proc/mounts
 /sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp,mba_MBps 0 0
---
 arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 7 +++++++
 1 file changed, 7 insertions(+)
arch/x86/kernel/cpu/intel_rdt_rdtgroup.c +7 -0
index 1b8e86a5d5e1..82a487840eb2 100644
@@ -2795,6 +2795,13 @@ static int rdtgroup_show_options(struct seq_file *seq, struct kernfs_root *kf)
 {
 	if (rdt_resources_all[RDT_RESOURCE_L3DATA].alloc_enabled)
 		seq_puts(seq, ",cdp");
+
+	if (rdt_resources_all[RDT_RESOURCE_L2DATA].alloc_enabled)
+		seq_puts(seq, ",cdpl2");
+
+	if (is_mba_sc(&rdt_resources_all[RDT_RESOURCE_MBA]))
+		seq_puts(seq, ",mba_MBps");
+
 	return 0;
 }