Skip to contentSkip to conversation

bus: fsl-mc: use match_string() helper to simplify the code

PATCH New zhong jiang 1 participant 1 message Sep 14, 2018 QorIQ DPAA2 fsl-mc bus driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bus: fsl-mc: use match_string() helper to simplify the code

match_string() returns the index of an array for a matching string, which can be used intead of open coded implementation.

---
 drivers/bus/fsl-mc/fsl-mc-allocator.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/bus/fsl-mc/fsl-mc-allocator.c +7 -7
index e906ecfe..7ecc89c 100644
@@ -160,16 +160,16 @@ static int __must_check object_type_to_pool_type(const char *object_type,
 						 enum fsl_mc_pool_type
 								*pool_type)
 {
-	unsigned int i;
+	int ret;
 
-	for (i = 0; i < ARRAY_SIZE(fsl_mc_pool_type_strings); i++) {
-		if (strcmp(object_type, fsl_mc_pool_type_strings[i]) == 0) {
-			*pool_type = i;
-			return 0;
-		}
+	ret = match_string(fsl_mc_pool_type_strings,
+			     ARRAY_SIZE(fsl_mc_pool_type_strings), object_type);
+	if (ret >= 0) {
+		*pool_type = ret;
+		return 0;
 	}
 
-	return -EINVAL;
+	return ret;
 }
 
 int __must_check fsl_mc_resource_allocate(struct fsl_mc_bus *mc_bus,
Signature · 1 line
1.7.12.4