ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/2 ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string
According to Documentation/devicetree/bindings/rtc/rtc-ds1307.txt the original compatible "maxim,ds1341" is not a valid entry.
Switch to the documented "dallas,ds1341" compatible.
--- arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx51-zii-rdu1.dts +1 -1
@@ -508,7 +508,7 @@ }; ds1341: rtc at 68 { - compatible = "maxim,ds1341"; + compatible = "dallas,ds1341"; reg = <0x68>; };
Signature · 1 line
2.7.4
Fabio Estevam
reviewerPATCH 2/2 ARM: dts: imx6qdl-zii-rdu2: Disable the internal RTC
On the imx6qdl-zii-rdu2 board the RTC functionality is provided via a DS1341 RTC connected via I2C bus, so we can safely disable the internal one.
--- arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +4 -0
@@ -813,6 +813,10 @@ status = "okay"; }; +&snvs_rtc { + status = "disabled"; +}; + &ssi1 { status = "okay"; };
Signature · 1 line
2.7.4
PATCH 1/2 ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string
In reply to Fabio EstevamAm Dienstag, den 18.09.2018, 08:43 -0300 schrieb Fabio Estevam:
Quoted 7 lines
According to
Documentation/devicetree/bindings/rtc/rtc-ds1307.txtthe original compatible "maxim,ds1341" is not a valid entry.Switch to the documented "dallas,ds1341" compatible.
Reported-by Chris Healy <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Quoted 17 lines
---
?arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
?1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/imx51-zii-rdu1.dts +0
-0@@ -508,7 +508,7 @@ > ? };?
Quoted 5 lines
Quoted 1 line
? ds1341: rtc at 68 {
arch/arm/boot/dts/imx51-zii-rdu1.dts +1
-1- compatible = "maxim,ds1341"; + compatible = "dallas,ds1341";? reg = <
0x68>;
? };?
PATCH 2/2 ARM: dts: imx6qdl-zii-rdu2: Disable the internal RTC
In reply to Fabio EstevamAm Dienstag, den 18.09.2018, 08:43 -0300 schrieb Fabio Estevam:
Quoted 6 lines
On the imx6qdl-zii-rdu2 board the RTC functionality is provided via a DS1341 RTC connected via I2C bus, so we can safely disable the internal one.?
Reported-by Chris Healy <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Quoted 19 lines
---
?arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++++
?1 file changed, 4 insertions(+)arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +0
-0@@ -813,6 +813,10 @@ > ? status = "okay"; ?};?
+&snvs_rtc {Quoted 1 line
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +1
-0+ status = "disabled";arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +2
-0+}; +?&ssi1 {
Quoted 1 line
? status = "okay";
?};
PATCH 1/2 ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string
In reply to Fabio EstevamQuoted 4 lines
According to
Documentation/devicetree/bindings/rtc/rtc-ds1307.txtthe original compatible "maxim,ds1341" is not a valid entry.Switch to the documented "dallas,ds1341" compatible.
PATCH 2/2 ARM: dts: imx6qdl-zii-rdu2: Disable the internal RTC
In reply to Fabio EstevamQuoted 3 lines
On the imx6qdl-zii-rdu2 board the RTC functionality is provided via a DS1341 RTC connected via I2C bus, so we can safely disable the internal one.
Shawn Guo
AppliedPATCH 1/2 ARM: dts: imx51-zii-rdu1: Fix the rtc compatible string
In reply to Fabio EstevamQuoted 7 lines · Fabio Estevam
According to
Documentation/devicetree/bindings/rtc/rtc-ds1307.txtthe original compatible "maxim,ds1341" is not a valid entry.Switch to the documented "dallas,ds1341" compatible.
Reported-by Chris Healy <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Applied both, thanks.