Skip to contentSkip to conversation

layoutcommit space reservation for the objlayout driver

DISCUSSION Daniel Gryniewicz 2 participants 2 messages Sep 15, 2014 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 17 lines · ----- "Christoph Hellwig
Quoted 1 line · Boaz Harrosh

I do not understand. This used to work just fine. Please point me

to

Quoted 2 lines

the patch that broke it?
(And since when are we allowed to brake old code?)

I bet it still works the same way it does as commited, which doesn't make it right. The way the NFS XDR buffer allocations work seems to be
that you can actually slightly overun it without things falling apart,
but that doesn't make it right. E.g. it took a fairly larger overrun in the block layout driver to finally find the issues, and most of the
time it was just silent truncations, real corruption happened less often.

Quoted 3 lines

But to make sure things work properly in the long run you'd really want
to have the proper allocation.

This is probably the case, then. The object layout layoutupdate is only 16 bytes long and is fixed size, so it wouldn't take much extra space for it to never hit.

Daniel

#2 lore raw
Quoted 1 line · Daniel Gryniewicz

This is probably the case, then. The object layout layoutupdate is only 16 bytes long and is fixed size, so it wouldn't take much extra space for it to never hit.

Yes, I suspect at the moment we just overallocate the XDR buffer due to slab or nfs implementation details, which are bound to chance as some point without notice.