mpc83xx: New board support SIMPC8313
PATCH v2 1/1 mpc83xx: New board support SIMPC8313
Quoted 4 lines
Marvell 88E1118 PHY, and PCI host support. The board also has a FPGA connected to the eLBC providing glue logic to a TMS320C67xx DSP.
Please split (80 chars max)
I'm not sure why this happened. I did everything using git and did it the same as last time, and last time appropriate line wrapping was applied.
Quoted 3 lines
Quoted 2 lines
-#!/bin/sh
+8#!/bin/sh?????
That was an error that I caught immediately and resolve with the third version of my patch which was sent briefly after the second one.
Quoted 1 line
why not create a
nand_spl_fixed_sdram()?
I can. I hadn't really considered it. I am concerned however that this will increase the size of my nand_spl section and might perhaps spill over the 4K limit. I'll try and see what happens.
Quoted 1 line
why not split this file in two and do the conditinal compile via
Makefile?
I haven't seen that done with other boards utilizing the nand_spl parts of the code. It seems that other boards all use the files that already exist in the main board directory and have #define's to differentiate the builds. If splitting the file in two is what should actually be done, I can do that as well.
Quoted 1 line
please use $@ and $< to simplify it
I am in the process of working on this one.
Thanks for the feedback.
Ron