media: venus: add support for USERPTR to queue

PATCH In review Malathi Gottam 3 participants 3 messages Oct 9, 2018 – Nov 1, 2018

Subsystems (4)

Media (V4L/DVB) Arm Qualcomm mailing list Qualcomm media platform Qualcomm venus video accelerator driver

lore

Share & tools

lore

Malathi Gottam

author

2018-10-09 07:52 UTC #0 lore raw

PATCH 1/1 media: venus: add support for USERPTR to queue

Add USERPTR to queue access methods by adding this support to io_modes on both the planes.

Signed-off-by Malathi Gottam <[email protected]>

---
 drivers/media/platform/qcom/venus/venc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/media/platform/qcom/venus/venc.c +2 -2

index 754c19a..b86994c 100644
@@ -1096,7 +1096,7 @@ static int m2m_queue_init(void *priv, struct vb2_queue *src_vq,
 	int ret;
 
 	src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
-	src_vq->io_modes = VB2_MMAP | VB2_DMABUF;
+	src_vq->io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF;
 	src_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
 	src_vq->ops = &venc_vb2_ops;
 	src_vq->mem_ops = &vb2_dma_sg_memops;

@@ -1112,7 +1112,7 @@ static int m2m_queue_init(void *priv, struct vb2_queue *src_vq,
 		return ret;
 
 	dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
-	dst_vq->io_modes = VB2_MMAP | VB2_DMABUF;
+	dst_vq->io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF;
 	dst_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
 	dst_vq->ops = &venc_vb2_ops;
 	dst_vq->mem_ops = &vb2_dma_sg_memops;

Signature · 1 line

1.9.1

Alexandre Courbot

Tested-by on v1 1/1

2018-10-11 06:56 UTC #1 lore raw

Quoted 5 lines · Malathi Gottam

Add USERPTR to queue access methods by adding this support to io_modes on both the planes.
Signed-off-by Malathi Gottam <[email protected]>

Tested-by Alexandre Courbot <[email protected]>

Stanimir Varbanov

Acked-by on v1 1/1

2018-11-01 12:38 UTC #2 lore raw

In reply to Malathi Gottam

Hi Malathi,

Thanks for the patch!

Quoted 23 lines · Malathi Gottam

Add USERPTR to queue access methods by adding this support to io_modes on both the planes.

Signed-off-by Malathi Gottam <[email protected]>

---
 drivers/media/platform/qcom/venus/venc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/media/platform/qcom/venus/venc.c +1 -1

index 754c19a..b86994c 100644
@@ -1096,7 +1096,7 @@ static int m2m_queue_init(void *priv, struct vb2_queue *src_vq,
 	int ret;
 
 	src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
-	src_vq->io_modes = VB2_MMAP | VB2_DMABUF;
+	src_vq->io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF;
 	src_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
 	src_vq->ops = &venc_vb2_ops;
 	src_vq->mem_ops = &vb2_dma_sg_memops;

drivers/media/platform/qcom/venus/venc.c static int m2m_queue_init(void *priv, struct vb2_queue *src_vq, · line 1118

Quoted 8 lines

drivers/media/platform/qcom/venus/venc.c +1 -1

@@ -1112,7 +1112,7 @@ static int m2m_queue_init(void *priv, struct vb2_queue *src_vq,
 		return ret;
 
 	dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
-	dst_vq->io_modes = VB2_MMAP | VB2_DMABUF;
+	dst_vq->io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF;
 	dst_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
 	dst_vq->ops = &venc_vb2_ops;
 	dst_vq->mem_ops = &vb2_dma_sg_memops;

Acked-by Stanimir Varbanov <[email protected]>

Signature · 2 lines

regards,
Stan