Skip to contentSkip to conversation

drm/msm/dsi: fix dsi clock names in DSI 10nm PLL driver

PATCH In review Abhinav Kumar 2 participants 2 messages Oct 11, 2018 – Oct 24, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/msm/dsi: fix dsi clock names in DSI 10nm PLL driver

Fix the dsi clock names in the DSI 10nm PLL driver to match the names in the dispcc driver as those are according to the clock plan of the chipset.

Changes in v2:
- Update the clock diagram with the new clock name

---
 drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c +4 -4
index 41bec57..3120562 100644
@@ -17,7 +17,7 @@
  *                              |                |
  *                              |                |
  *                 +---------+  |  +----------+  |  +----+
- *  dsi0vco_clk ---| out_div |--o--| divl_3_0 |--o--| /8 |-- dsi0pllbyte
+ *  dsi0vco_clk ---| out_div |--o--| divl_3_0 |--o--| /8 |-- dsi0_phy_pll_out_byteclk
  *                 +---------+  |  +----------+  |  +----+
  *                              |                |
  *                              |                |         dsi0_pll_by_2_bit_clk
@@ -25,7 +25,7 @@
  *                              |                |  +----+  |  |\  dsi0_pclk_mux
  *                              |                |--| /2 |--o--| \   |
  *                              |                |  +----+     |  \  |  +---------+
- *                              |                --------------|  |--o--| div_7_4 |-- dsi0pll
+ *                              |                --------------|  |--o--| div_7_4 |-- dsi0_phy_pll_out_dsiclk
  *                              |------------------------------|  /     +---------+
  *                              |          +-----+             | /
  *                              -----------| /4? |--o----------|/
@@ -690,7 +690,7 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm)
 
 	hws[num++] = hw;
 
-	snprintf(clk_name, 32, "dsi%dpllbyte", pll_10nm->id);
+	snprintf(clk_name, 32, "dsi%d_phy_pll_out_byteclk", pll_10nm->id);
 	snprintf(parent, 32, "dsi%d_pll_bit_clk", pll_10nm->id);
 
 	/* DSI Byte clock = VCO_CLK / OUT_DIV / BIT_DIV / 8 */
@@ -739,7 +739,7 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm)
 
 	hws[num++] = hw;
 
-	snprintf(clk_name, 32, "dsi%dpll", pll_10nm->id);
+	snprintf(clk_name, 32, "dsi%d_phy_pll_out_dsiclk", pll_10nm->id);
 	snprintf(parent, 32, "dsi%d_pclk_mux", pll_10nm->id);
 
 	/* PIX CLK DIV : DIV_CTRL_7_4*/
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
reviewer Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · Abhinav Kumar

Fix the dsi clock names in the DSI 10nm PLL driver to match the names in the dispcc driver as those are according to the clock plan of the chipset.

Changes in v2:
- Update the clock diagram with the new clock name

(On mobile, apologies for html email)

---

Quoted 53 lines
 drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c +1 -1
index 41bec57..3120562 100644
@@ -17,7 +17,7 @@
  *                              |                |
  *                              |                |
  *                 +---------+  |  +----------+  |  +----+
- *  dsi0vco_clk ---| out_div |--o--| divl_3_0 |--o--| /8 |-- dsi0pllbyte
+ *  dsi0vco_clk ---| out_div |--o--| divl_3_0 |--o--| /8 |--

dsi0_phy_pll_out_byteclk

  *                 +---------+  |  +----------+  |  +----+
  *                              |                |
  *                              |                |

dsi0_pll_by_2_bit_clk

drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c +0 -0
@@ -25,7 +25,7 @@
  *                              |                |  +----+  |  |\

dsi0_pclk_mux

  *                              |                |--| /2 |--o--| \   |
  *                              |                |  +----+     |  \  |
+---------+
- *                              |                --------------|  |--o--|
div_7_4 |-- dsi0pll
+ *                              |                --------------|  |--o--|
div_7_4 |-- dsi0_phy_pll_out_dsiclk
  *                              |------------------------------|  /
 +---------+
  *                              |          +-----+             | /
  *                              -----------| /4? |--o----------|/
drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c +1 -1
@@ -690,7 +690,7 @@ static int pll_10nm_register(struct dsi_pll_10nm
 *pll_10nm)
 
        hws[num++] = hw;
 
-       snprintf(clk_name, 32, "dsi%dpllbyte", pll_10nm->id);
+       snprintf(clk_name, 32, "dsi%d_phy_pll_out_byteclk", pll_10nm->id);
        snprintf(parent, 32, "dsi%d_pll_bit_clk", pll_10nm->id);
 
        /* DSI Byte clock = VCO_CLK / OUT_DIV / BIT_DIV / 8 */
drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c +1 -1
@@ -739,7 +739,7 @@ static int pll_10nm_register(struct dsi_pll_10nm
 *pll_10nm)
 
        hws[num++] = hw;
 
-       snprintf(clk_name, 32, "dsi%dpll", pll_10nm->id);
+       snprintf(clk_name, 32, "dsi%d_phy_pll_out_dsiclk", pll_10nm->id);
        snprintf(parent, 32, "dsi%d_pclk_mux", pll_10nm->id);
 
        /* PIX CLK DIV : DIV_CTRL_7_4*/
Quoted 5 lines

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel