patch "serial: sh-sci: Fix could not remove dev_attr_rx_fifo_timeout" added to tty-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
serial: sh-sci: Fix could not remove dev_attr_rx_fifo_timeout
to my tty git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
in the tty-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
641a41dbba217ee5bd26abe6be77f8cead9cd00eMon Sep 17 00:00:00 2001
From: Yoshihiro Shimoda <[email protected]>
Date: Tue, 30 Oct 2018 15:13:35 +0900
Subject: serial: sh-sci: Fix could not remove dev_attr_rx_fifo_timeout
This patch fixes an issue that the sci_remove() could not remove dev_attr_rx_fifo_timeout because uart_remove_one_port() set the port->port.type to PORT_UNKNOWN.
--- drivers/tty/serial/sh-sci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/serial/sh-sci.c +2 -2
@@ -3102,6 +3102,7 @@ static struct uart_driver sci_uart_driver = {static int sci_remove (struct platform_device *dev) {struct sci_port *port =platform_get_drvdata (dev); +unsigned int type = port->port.type;/* uart_remove_... clears it */ sci_ports_in_use &= ~BIT (port->port.line);uart_remove_one_port (&sci_uart_driver, &port->port);
@@ -3112,8 +3113,7 @@ static int sci_remove(struct platform_device *dev)sysfs_remove_file (&dev->dev.kobj, &dev_attr_rx_fifo_trigger.attr); } -if (port->port.type ==PORT_SCIFA || port->port.type ==PORT_SCIFB || - port->port.type ==PORT_HSCIF ) { +if (type ==PORT_SCIFA || type ==PORT_SCIFB || type ==PORT_HSCIF ) {sysfs_remove_file (&dev->dev.kobj, &dev_attr_rx_fifo_timeout.attr); }
Signature · 1 line
2.19.1