Skip to contentSkip to conversation

Patch "net: ethernet: ti: cpsw: unsync mcast entries while switch promisc mode" has been added to the 4.19-stable tree

DISCUSSION Greg KH 3 participants 3 messages Nov 11, 2018 – Nov 12, 2018 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

On Sat, Nov 10, 2018 at 11:16:15AM -0800, [email protected] wrote:

It shouldn't be added to 4.19

Quoted 59 lines

This is a note to let you know that I've just added the patch titled

net: ethernet: ti: cpsw: unsync mcast entries while switch promisc mode

to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
net-ethernet-ti-cpsw-unsync-mcast-entries-while-switch-promisc-mode.patch
and it can be found in the queue-4.19 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Sat Nov 10 10:51:03 PST 2018

From: Ivan Khoronzhuk <[email protected]>
Date: Mon, 22 Oct 2018 21:51:36 +0300
Subject: net: ethernet: ti: cpsw: unsync mcast entries while switch promisc mode

From: Ivan Khoronzhuk <[email protected]>

[ Upstream commit 9737cc99dd14b5b8b9d267618a6061feade8ea68 ]

After flushing all mcast entries from the table, the ones contained in mc list of ndev are not restored when promisc mode is toggled off, because they are considered as synched with ALE, thus, in order to restore them after promisc mode - reset syncing info. This fix touches only switch mode devices, including single port boards like Beagle Bone.

Fixes commit 5da1948969bc

("net: ethernet: ti: cpsw: fix lost of mcast packets while rx_mode update")

---
drivers/net/ethernet/ti/cpsw.c | 1 +

1 file changed, 1 insertion(+)
drivers/net/ethernet/ti/cpsw.c +1 -0
@@ -642,6 +642,7 @@ static void cpsw_set_promiscious(struct
 
 			/* Clear all mcast from ALE */
 			cpsw_ale_flush_multicast(ale, ALE_ALL_PORTS, -1);
+			__dev_mc_unsync(ndev, NULL);
 
 			/* Flood All Unicast Packets to Host port */
 			cpsw_ale_control_set(ale, 0, ALE_P0_UNI_FLOOD, 1);

Patches currently in stable-queue which might be from [email protected] are

queue-4.19/net-ethernet-ti-cpsw-unsync-mcast-entries-while-switch-promisc-mode.patch

Signature · 2 lines
Regards,
Ivan Khoronzhuk
author maintainer
#2 lore raw
Quoted 3 lines · Ivan Khoronzhuk

On Sat, Nov 10, 2018 at 11:16:15AM -0800, [email protected] wrote:

It shouldn't be added to 4.19

Thanks, now dropped from everywhere.

Sasha, something went wrong with your scripts to pick this one, it had a
Fixes: tag for something that went into 4.20-rc1 :(

thanks,

greg k-h

maintainer
#3 lore raw
Quoted 9 lines · Greg KH
Quoted 3 lines · Ivan Khoronzhuk

On Sat, Nov 10, 2018 at 11:16:15AM -0800, [email protected] wrote:

It shouldn't be added to 4.19

Thanks, now dropped from everywhere.

Sasha, something went wrong with your scripts to pick this one, it had a
Fixes: tag for something that went into 4.20-rc1 :(

Yes, the word "commit" in the fixes line threw it off. I'll fix my script, sorry :(

--
Thanks,
Sasha