FAILED: patch "[PATCH] acpi/nfit, x86/mce: Handle only uncorrectable machine checks" failed to apply to 4.14-stable tree
Subsystems (5)
Greg Kroah-Hartman
maintainerThe patch below does not apply to the 4.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 5d96c9342c23ee1d084802dcf064caa67ecaa45b Mon Sep 17 00:00:00 2001
From: Vishal Verma <[email protected]>
Date: Thu, 25 Oct 2018 18:37:28 -0600
Subject: [PATCH] acpi/nfit, x86/mce: Handle only uncorrectable machine checks
The MCE handler for nfit devices is called for memory errors on a Non-Volatile DIMM and adds the error location to a 'badblocks' list. This list is used by the various NVDIMM drivers to avoid consuming known poison locations during IO.
The MCE handler gets called for both corrected and uncorrectable errors. Until now, both kinds of errors have been added to the badblocks list. However, corrected memory errors indicate that the problem has already been fixed by hardware, and the resulting interrupt is merely a notification to Linux.
As far as future accesses to that location are concerned, it is perfectly fine to use, and thus doesn't need to be included in the above badblocks list.
Add a check in the nfit MCE handler to filter out corrected mce events, and only process uncorrectable errors.
arch/x86/include/asm/mce.h +1 -0
@@ -221,6 +221,7 @@ static inline void mce_hygon_feature_init(struct cpuinfo_x86 *c) { return mce_amint mce_available (struct cpuinfo_x86 *c);bool mce_is_memory_error (struct mce *m); +bool mce_is_correctable (struct mce *m);DECLARE_PER_CPU (unsigned, mce_exception_count);DECLARE_PER_CPU (unsigned, mce_poll_count);
arch/x86/kernel/cpu/mcheck/mce.c +2 -1
@@ -534,7 +534,7 @@ bool mce_is_memory_error(struct mce *m) }EXPORT_SYMBOL_GPL (mce_is_memory_error); -static bool mce_is_correctable (struct mce *m) +bool mce_is_correctable (struct mce *m) {if (m->cpuvendor ==X86_VENDOR_AMD && m->status &MCI_STATUS_DEFERRED )return false;
@@ -547,6 +547,7 @@ static bool mce_is_correctable(struct mce *m)return true; } +EXPORT_SYMBOL_GPL (mce_is_correctable);static bool cec_add_mce (struct mce *m) {
drivers/acpi/nfit/mce.c +2 -2
@@ -25,8 +25,8 @@ static int nfit_handle_mce(struct notifier_block *nb, unsigned long val,struct acpi_nfit_desc *acpi_desc;struct nfit_spa *nfit_spa; -/* We only care about memory errors */ -if (!mce_is_memory_error (mce)) +/* We only care about uncorrectable memory errors */ +if (!mce_is_memory_error (mce) ||mce_is_correctable (mce))return NOTIFY_DONE ;/*