drm/amdgpu: Remove dead static variable
Subsystems (2)
PATCH 1/1 drm/amdgpu: Remove dead static variable
The static struct drm_driver *driver was
not used because drm_pci_init was deprecated
--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1 -3
@@ -1235,7 +1235,6 @@ static int amdgpu_flush(struct file *f, fl_owner_t id) .patchlevel = KMS_DRIVER_PATCHLEVEL, }; -static struct drm_driver *driver;static struct pci_driver *pdriver;static struct pci_driver amdgpu_kms_pci_driver = {
@@ -1267,9 +1266,8 @@ static int __init amdgpu_init(void) goto error_fence;DRM_INFO ("amdgpu kernel modesetting enabled.\n" ); - driver = &kms_driver; pdriver = &amdgpu_kms_pci_driver; - driver->num_ioctls = amdgpu_max_kms_ioctl; + kms_driver.num_ioctls = amdgpu_max_kms_ioctl;amdgpu_register_atpx_handler ();/* Ignore KFD init failures. Normal when CONFIG_HSA_AMD is not set. */
Signature · 6 lines
1.9.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1542625660-29454-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org
Christian König
Reviewed-byAm 19.11.18 um 12:07 schrieb Rex Zhu:
Quoted 4 lines
The static struct
drm_driver*driver was
not used becausedrm_pci_initwas deprecatedSigned-off-by Rex Zhu <[email protected]>
Can you of hand see what "pdriver" is used for? That looks suspicious like something deprecated as well.
Regards,
Christian.
Quoted 17 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0
-1@@ -1235,7 +1235,6 @@ static int amdgpu_flush(struct file *f, fl_owner_t id) .patchlevel = KMS_DRIVER_PATCHLEVEL, }; -static struct drm_driver *driver;static struct pci_driver *pdriver;static struct pci_driver amdgpu_kms_pci_driver = {
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c static int __init amdgpu_init(void) · line 1273
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1
-2@@ -1267,9 +1266,8 @@ static int __init amdgpu_init(void) goto error_fence;DRM_INFO ("amdgpu kernel modesetting enabled.\n" ); - driver = &kms_driver; pdriver = &amdgpu_kms_pci_driver; - driver->num_ioctls = amdgpu_max_kms_ioctl; + kms_driver.num_ioctls = amdgpu_max_kms_ioctl;amdgpu_register_atpx_handler ();/* Ignore KFD init failures. Normal when CONFIG_HSA_AMD is not set. */
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 30a11ff7-0cc1-970c-6f48-4a955a2883aa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Quoted 5 lines · Christian König
Am 19.11.18 um 12:07 schrieb Rex Zhu:
Quoted 3 lines
The static struct
drm_driver*driver was
not used becausedrm_pci_initwas deprecated
Quoted 7 lines
Quoted 1 line
Signed-off-by Rex Zhu <[email protected]>Reviewed-by Christian König <[email protected]>Can you of hand see what "pdriver" is used for? That looks suspicious like something deprecated as well.
Seeming copy/paste from the radeon driver. The latter used to support UMS and KMS at some point in the past.
HTH
-Emil
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CACvgo51knZSiwkHoaJK=jcHTz8A34fR0E3UJMduX+_xk20RHNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Am 20.11.18 um 11:48 schrieb Emil Velikov:
Quoted 6 lines
Quoted 4 lines · Christian König
Am 19.11.18 um 12:07 schrieb Rex Zhu:
Quoted 3 lines
The static struct
drm_driver*driver was
not used becausedrm_pci_initwas deprecated
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Signed-off-by Rex Zhu <[email protected]>Reviewed-by Christian König <[email protected]>Can you of hand see what "pdriver" is used for? That looks suspicious like something deprecated as well.
Seeming copy/paste from the radeon driver. The latter used to support UMS and KMS at some point in the past.
Yeah, thought so. Rex cam up with a V2 where both variables are removed.
Thanks,
Christian.
Quoted 3 lines
HTH
-Emil
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx