Skip to contentSkip to conversation

MAINTAINERS: Assign some more files in the hw/arm/ directory

PATCH Superseded Thomas Huth 3 participants 4 messages Nov 19, 2018 – Nov 20, 2018

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Assign some more files in the hw/arm/ directory

I apparently missed some more files and even a complete machine (the "imx25-pdk") in my previous patch... but now we should hopefully have a completely coverage for all available ARM boards.

Fixes 95a5db3ae5698b49c63144610ad02913e780c828
---
 MAINTAINERS | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
MAINTAINERS +16 -0
index 1032406..ac20dc8 100644
@@ -533,6 +533,18 @@ L: [email protected]
 S: Odd Fixes
 F: hw/arm/gumstix.c
 
+i.MX25 PDK
+M: Peter Maydell <[email protected]>
+R: Jean-Christophe Dubois <[email protected]>
+L: [email protected]
+S: Odd Fixes
+F: hw/arm/fsl-imx25.c
+F: hw/arm/imx25_pdk.c
+F: hw/misc/imx25_ccm.c
+F: include/hw/arm/fsl-imx25.h
+F: include/hw/misc/imx25_ccm.h
+F: tests/ds1338-test.c
+
 i.MX31 (kzm)
 M: Peter Chubb <[email protected]>
 M: Peter Maydell <[email protected]>
@@ -615,6 +627,7 @@ R: Andrew Baumann <[email protected]>
 R: Philippe Mathieu-Daudé <[email protected]>
 L: [email protected]
 S: Odd Fixes
+F: hw/arm/raspi.c
 F: hw/arm/raspi_platform.h
 F: hw/*/bcm283*
 F: include/hw/arm/raspi*
@@ -641,6 +654,7 @@ F: hw/arm/z2.c
 F: hw/*/pxa2xx*
 F: hw/misc/mst_fpga.c
 F: include/hw/arm/pxa.h
+F: include/hw/arm/sharpsl.h
 
 SABRELITE / i.MX6
 M: Peter Maydell <[email protected]>
@@ -686,7 +700,9 @@ M: Peter Maydell <[email protected]>
 L: [email protected]
 S: Maintained
 F: hw/arm/virt*
+F: hw/arm/smmu*
 F: include/hw/arm/virt.h
+F: include/hw/arm/smmu*
 
 Xilinx Zynq
 M: Edgar E. Iglesias <[email protected]>
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 3 lines · Thomas Huth

I apparently missed some more files and even a complete machine (the "imx25-pdk") in my previous patch... but now we should hopefully have a completely coverage for all available ARM boards.

Hi; looks like you forgot to cc qemu-devel.

Quoted 46 lines
Fixes 95a5db3ae5698b49c63144610ad02913e780c828
---
 MAINTAINERS | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
MAINTAINERS +14 -0
index 1032406..ac20dc8 100644
@@ -533,6 +533,18 @@ L: [email protected]
 S: Odd Fixes
 F: hw/arm/gumstix.c
 
+i.MX25 PDK
+M: Peter Maydell <[email protected]>
+R: Jean-Christophe Dubois <[email protected]>
+L: [email protected]
+S: Odd Fixes
+F: hw/arm/fsl-imx25.c
+F: hw/arm/imx25_pdk.c
+F: hw/misc/imx25_ccm.c
+F: include/hw/arm/fsl-imx25.h
+F: include/hw/misc/imx25_ccm.h
+F: tests/ds1338-test.c
+
 i.MX31 (kzm)
 M: Peter Chubb <[email protected]>
 M: Peter Maydell <[email protected]>
@@ -615,6 +627,7 @@ R: Andrew Baumann <[email protected]>
 R: Philippe Mathieu-Daudé <[email protected]>
 L: [email protected]
 S: Odd Fixes
+F: hw/arm/raspi.c
 F: hw/arm/raspi_platform.h
 F: hw/*/bcm283*
 F: include/hw/arm/raspi*
@@ -641,6 +654,7 @@ F: hw/arm/z2.c
 F: hw/*/pxa2xx*
 F: hw/misc/mst_fpga.c
 F: include/hw/arm/pxa.h
+F: include/hw/arm/sharpsl.h
 
 SABRELITE / i.MX6
 M: Peter Maydell <[email protected]>

MAINTAINERS M: Peter Maydell <[email protected]> · line 705

Quoted 6 lines
MAINTAINERS +2 -0
@@ -686,7 +700,9 @@ M: Peter Maydell <[email protected]>
 L: [email protected]
 S: Maintained
 F: hw/arm/virt*
+F: hw/arm/smmu*
 F: include/hw/arm/virt.h
+F: include/hw/arm/smmu*

The SMMU files aren't part of the virt board, they're the SMMUv3 device model. They should go in a section that lets us mark Eric Auger as their maintainer.

Quoted 5 lines
MAINTAINERS +0 -1
 Xilinx Zynq
 M: Edgar E. Iglesias <[email protected]>
--

1.8.3.1

thanks
-- PMM

#2 lore raw
Quoted 6 lines · Peter Maydell
Quoted 3 lines · Thomas Huth

I apparently missed some more files and even a complete machine (the "imx25-pdk") in my previous patch... but now we should hopefully have a completely coverage for all available ARM boards.

Hi; looks like you forgot to cc qemu-devel.

Oops, sorry about that.

Quoted 43 lines
Quoted 43 lines
Fixes 95a5db3ae5698b49c63144610ad02913e780c828
---
 MAINTAINERS | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
MAINTAINERS +14 -0
index 1032406..ac20dc8 100644
@@ -533,6 +533,18 @@ L: [email protected]
 S: Odd Fixes
 F: hw/arm/gumstix.c
 
+i.MX25 PDK
+M: Peter Maydell <[email protected]>
+R: Jean-Christophe Dubois <[email protected]>
+L: [email protected]
+S: Odd Fixes
+F: hw/arm/fsl-imx25.c
+F: hw/arm/imx25_pdk.c
+F: hw/misc/imx25_ccm.c
+F: include/hw/arm/fsl-imx25.h
+F: include/hw/misc/imx25_ccm.h
+F: tests/ds1338-test.c
+
 i.MX31 (kzm)
 M: Peter Chubb <[email protected]>
 M: Peter Maydell <[email protected]>
@@ -615,6 +627,7 @@ R: Andrew Baumann <[email protected]>
 R: Philippe Mathieu-Daudé <[email protected]>
 L: [email protected]
 S: Odd Fixes
+F: hw/arm/raspi.c
 F: hw/arm/raspi_platform.h
 F: hw/*/bcm283*
 F: include/hw/arm/raspi*
@@ -641,6 +654,7 @@ F: hw/arm/z2.c
 F: hw/*/pxa2xx*
 F: hw/misc/mst_fpga.c
 F: include/hw/arm/pxa.h
+F: include/hw/arm/sharpsl.h
 
Quoted 13 lines

MAINTAINERS M: Peter Maydell <[email protected]> · line 705

Quoted 9 lines
MAINTAINERS +2 -0
 SABRELITE / i.MX6
 M: Peter Maydell <[email protected]>
@@ -686,7 +700,9 @@ M: Peter Maydell <[email protected]>
 L: [email protected]
 S: Maintained
 F: hw/arm/virt*
+F: hw/arm/smmu*
 F: include/hw/arm/virt.h
+F: include/hw/arm/smmu*

The SMMU files aren't part of the virt board, they're the SMMUv3 device model. They should go in a section that lets us mark Eric Auger as their maintainer.

Ok, I'll send a v2 without the smmu* files. Eric, could you please take care of sending a patch for a new SMMU section?

Thomas

#3 lore raw

Hi Thomas,

Quoted 67 lines · Thomas Huth
Quoted 6 lines · Peter Maydell
Quoted 3 lines · Thomas Huth

I apparently missed some more files and even a complete machine (the "imx25-pdk") in my previous patch... but now we should hopefully have a completely coverage for all available ARM boards.

Hi; looks like you forgot to cc qemu-devel.

Oops, sorry about that.

Quoted 43 lines
Quoted 43 lines
Fixes 95a5db3ae5698b49c63144610ad02913e780c828
---
 MAINTAINERS | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
MAINTAINERS +14 -0
index 1032406..ac20dc8 100644
@@ -533,6 +533,18 @@ L: [email protected]
 S: Odd Fixes
 F: hw/arm/gumstix.c
 
+i.MX25 PDK
+M: Peter Maydell <[email protected]>
+R: Jean-Christophe Dubois <[email protected]>
+L: [email protected]
+S: Odd Fixes
+F: hw/arm/fsl-imx25.c
+F: hw/arm/imx25_pdk.c
+F: hw/misc/imx25_ccm.c
+F: include/hw/arm/fsl-imx25.h
+F: include/hw/misc/imx25_ccm.h
+F: tests/ds1338-test.c
+
 i.MX31 (kzm)
 M: Peter Chubb <[email protected]>
 M: Peter Maydell <[email protected]>
@@ -615,6 +627,7 @@ R: Andrew Baumann <[email protected]>
 R: Philippe Mathieu-Daudé <[email protected]>
 L: [email protected]
 S: Odd Fixes
+F: hw/arm/raspi.c
 F: hw/arm/raspi_platform.h
 F: hw/*/bcm283*
 F: include/hw/arm/raspi*
@@ -641,6 +654,7 @@ F: hw/arm/z2.c
 F: hw/*/pxa2xx*
 F: hw/misc/mst_fpga.c
 F: include/hw/arm/pxa.h
+F: include/hw/arm/sharpsl.h
 
Quoted 13 lines

MAINTAINERS M: Peter Maydell <[email protected]> · line 705

Quoted 9 lines
MAINTAINERS +2 -0
 SABRELITE / i.MX6
 M: Peter Maydell <[email protected]>
@@ -686,7 +700,9 @@ M: Peter Maydell <[email protected]>
 L: [email protected]
 S: Maintained
 F: hw/arm/virt*
+F: hw/arm/smmu*
 F: include/hw/arm/virt.h
+F: include/hw/arm/smmu*

The SMMU files aren't part of the virt board, they're the SMMUv3 device model. They should go in a section that lets us mark Eric Auger as their maintainer.

Quoted 2 lines

Ok, I'll send a v2 without the smmu* files. Eric, could you please take care of sending a patch for a new SMMU section?

Yes sure.

Thanks

Eric

Quoted 3 lines

Thomas