Skip to contentSkip to conversation

dm: MIGRATION: Add migration plan for DM_MMC

PATCH Superseded Tom Rini 6 participants 19 messages Nov 29, 2018 – Dec 20, 2018 Kbuild

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH v3 1/4 dm: MIGRATION: Add migration plan for DM_MMC

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

---
Changes in v3:
- Ensure CONFIG_MMC is set
Changes in v2:
- Note that failure to migration may lead to removal.

---
 Makefile                       | 10 ++++++++++
 doc/driver-model/MIGRATION.txt |  9 +++++++++
 2 files changed, 19 insertions(+)
Makefile +10 -0
index a4b1d1db5241..53046e763e0b 100644
@@ -920,6 +920,16 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
 	@echo "before sending patches to the mailing list."
 	@echo "===================================================="
 endif
+ifeq ($(CONFIG_MMC),y)
+ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
+	@echo "===================== WARNING ======================"
+	@echo "This board does not use CONFIG_DM_MMC. Please update"
+	@echo "the board to use CONFIG_DM_MMC before the v2019.04 release."
+	@echo "Failure to update by the deadline may result in board removal."
+	@echo "See doc/driver-model/MIGRATION.txt for more info."
+	@echo "===================================================="
+endif
+endif
 	@# Check that this build does not use CONFIG options that we do not
 	@# know about unless they are in Kconfig. All the existing CONFIG
 	@# options are whitelisted, so new ones should not be added.
doc/driver-model/MIGRATION.txt +9 -0
index 5ebefd608b99..71c26571828a 100644
@@ -5,6 +5,15 @@ U-Boot has been migrating to a new driver model since its introduction in
 2014. This file describes the schedule for deprecation of pre-driver-model
 features.
 
+CONFIG_DM_MMC
+-------------
+
+Status: In progress
+Deadline: 2019.04
+
+The subsystem itself has been converted and maintainers should submit patches
+switching over to using CONFIG_DM_MMC and other base driver model options in
+time for inclusion in the 2019.04 rerelease.
 
 CONFIG_BLK
 ----------
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v3 1/4 dm: MIGRATION: Add migration plan for DM_MMC

Quoted 9 lines · Tom Rini

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181203/0cd4d9e6/attachment.sig>
#2 lore raw

PATCH v3 1/4 dm: MIGRATION: Add migration plan for DM_MMC

Hi Tom,

Quoted 7 lines · Tom Rini
Quoted 4 lines · Tom Rini

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Quoted 7 lines
Quoted 5 lines

Applied to u-boot/master, thanks!

I have finally found the time to test current mainline on all our board configs and now I still get the warning "This board does not use CONFIG_DM_MMC". Supposedly this is because I have CONFIG_BLK disabled (because of size limitations: this U-Boot image runs from FPGA and just configures the eMMC without loading files from it).

Would it make sense to change the test like this:

Makefile +1 -1
index 0d11ff9797..41bde15b74 100644
@@ -920,7 +920,7 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
        @echo "before sending patches to the mailing list."
        @echo "===================================================="
 endif
-ifeq ($(CONFIG_MMC),y)
+ifeq ($(CONFIG_MMC)$(CONFIG_BLK),yy)
 ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
        @echo "===================== WARNING ======================"
        @echo "This board does not use CONFIG_DM_MMC. Please update"

Is it intentional that CONFIG_BLK needs to be enabled?

Regards,
Simon

#3 lore raw

PATCH v3 1/4 dm: MIGRATION: Add migration plan for DM_MMC

Hi Simon,

Quoted 41 lines · Simon Goldschmidt

Hi Tom,

Quoted 7 lines · Tom Rini
Quoted 4 lines · Tom Rini

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Quoted 7 lines
Quoted 5 lines

Applied to u-boot/master, thanks!

I have finally found the time to test current mainline on all our board configs and now I still get the warning "This board does not use CONFIG_DM_MMC". Supposedly this is because I have CONFIG_BLK disabled (because of size limitations: this U-Boot image runs from FPGA and just configures the eMMC without loading files from it).

Would it make sense to change the test like this:

Makefile +1 -1
index 0d11ff9797..41bde15b74 100644
@@ -920,7 +920,7 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
        @echo "before sending patches to the mailing list."
        @echo "===================================================="
 endif
-ifeq ($(CONFIG_MMC),y)
+ifeq ($(CONFIG_MMC)$(CONFIG_BLK),yy)
 ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
        @echo "===================== WARNING ======================"
        @echo "This board does not use CONFIG_DM_MMC. Please update"
Quoted 1 line

Is it intentional that CONFIG_BLK needs to be enabled?

Yes it is, unless you don't actually use block devices. What is the goal of initing eMMC without using it?

Regards,
Simon

#4 lore raw

PATCH v3 1/4 dm: MIGRATION: Add migration plan for DM_MMC

Am Fr., 14. Dez. 2018, 04:10 hat Simon Glass <[email protected]> geschrieben:

Quoted 45 lines

Hi Simon,

Quoted 41 lines · Simon Goldschmidt

Hi Tom,

Quoted 7 lines · Tom Rini
Quoted 4 lines · Tom Rini

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Quoted 7 lines
Quoted 5 lines

Applied to u-boot/master, thanks!

I have finally found the time to test current mainline on all our board configs and now I still get the warning "This board does not use CONFIG_DM_MMC". Supposedly this is because I have CONFIG_BLK disabled (because of size limitations: this U-Boot image runs from FPGA and just configures the eMMC without loading files from it).

Would it make sense to change the test like this:

Makefile +1 -1
index 0d11ff9797..41bde15b74 100644
@@ -920,7 +920,7 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
        @echo "before sending patches to the mailing list."
        @echo "===================================================="
 endif
-ifeq ($(CONFIG_MMC),y)
+ifeq ($(CONFIG_MMC)$(CONFIG_BLK),yy)
 ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
        @echo "===================== WARNING ======================"
        @echo "This board does not use CONFIG_DM_MMC. Please update"
Quoted 5 lines
Quoted 1 line

Is it intentional that CONFIG_BLK needs to be enabled?

Yes it is, unless you don't actually use block devices. What is the goal of initing eMMC without using it?

We're only initializing pSLC mode in that configuration. The boot flow is via tftp. I know this might be a rare use case but I'm more or less forced to disable block devices because I only have ~200KiB for U-Boot when running from FPGA.

Regards,
Simon

Quoted 1 line
#5 lore raw

PATCH v3 1/4 dm: MIGRATION: Add migration plan for DM_MMC

Hi Simon,

Quoted 50 lines · Simon Goldschmidt

Am Fr., 14. Dez. 2018, 04:10 hat Simon Glass <[email protected]> geschrieben:

Quoted 46 lines

Hi Simon,

Quoted 41 lines · Simon Goldschmidt

Hi Tom,

Quoted 7 lines · Tom Rini
Quoted 4 lines · Tom Rini

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Quoted 7 lines
Quoted 5 lines

Applied to u-boot/master, thanks!

I have finally found the time to test current mainline on all our board configs and now I still get the warning "This board does not use CONFIG_DM_MMC". Supposedly this is because I have CONFIG_BLK disabled (because of size limitations: this U-Boot image runs from FPGA and just configures the eMMC without loading files from it).

Would it make sense to change the test like this:

Makefile +1 -1
index 0d11ff9797..41bde15b74 100644
@@ -920,7 +920,7 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
        @echo "before sending patches to the mailing list."
        @echo "===================================================="
 endif
-ifeq ($(CONFIG_MMC),y)
+ifeq ($(CONFIG_MMC)$(CONFIG_BLK),yy)
 ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
        @echo "===================== WARNING ======================"
        @echo "This board does not use CONFIG_DM_MMC. Please update"
Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Is it intentional that CONFIG_BLK needs to be enabled?

Yes it is, unless you don't actually use block devices. What is the goal of initing eMMC without using it?

We're only initializing pSLC mode in that configuration. The boot flow is via tftp. I know this might be a rare use case but I'm more or less forced to disable block devices because I only have ~200KiB for U-Boot when running from FPGA.

Maybe disabling HAVE_BLOCK_DEVICE would provide a means to avoid the warning?

Regards,
Simon

#6 lore raw

PATCH v3 1/4 dm: MIGRATION: Add migration plan for DM_MMC

Am 20.12.2018 um 22:17 schrieb Simon Glass:

Quoted 60 lines

Hi Simon,

Quoted 56 lines · Simon Goldschmidt

Am Fr., 14. Dez. 2018, 04:10 hat Simon Glass <[email protected]> geschrieben:

Quoted 50 lines

Hi Simon,

Quoted 41 lines · Simon Goldschmidt

Hi Tom,

Quoted 7 lines · Tom Rini
Quoted 4 lines · Tom Rini

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Quoted 7 lines
Quoted 5 lines

Applied to u-boot/master, thanks!

I have finally found the time to test current mainline on all our board configs and now I still get the warning "This board does not use CONFIG_DM_MMC". Supposedly this is because I have CONFIG_BLK disabled (because of size limitations: this U-Boot image runs from FPGA and just configures the eMMC without loading files from it).

Would it make sense to change the test like this:

Makefile +1 -1
index 0d11ff9797..41bde15b74 100644
@@ -920,7 +920,7 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
         @echo "before sending patches to the mailing list."
         @echo "===================================================="
  endif
-ifeq ($(CONFIG_MMC),y)
+ifeq ($(CONFIG_MMC)$(CONFIG_BLK),yy)
  ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
         @echo "===================== WARNING ======================"
         @echo "This board does not use CONFIG_DM_MMC. Please update"
Quoted 1 line

Is it intentional that CONFIG_BLK needs to be enabled?

Yes it is, unless you don't actually use block devices. What is the goal of initing eMMC without using it?

Quoted 3 lines
Quoted 1 line

We're only initializing pSLC mode in that configuration. The boot flow is via tftp. I know this might be a rare use case but I'm more or less forced to disable block devices because I only have ~200KiB for U-Boot when running from FPGA.

Maybe disabling HAVE_BLOCK_DEVICE would provide a means to avoid the warning?

Hmm, it might well be that I haven't disabled everything I can in that config. I'll check that next year ;-)

Regards,
Simon

author
#7 lore raw

PATCH v3 2/4 dm: MIGRATION: Add migration plan for DM_USB

In reply to Tom Rini

As much of the USB system has been migrated to DM now, formalize a deadline for migration.

---
Changes in v3:
- Ensure CONFIG_USB is set.
Changes in v2:
- Note that failure to migration may lead to removal.

---
 Makefile                       | 10 ++++++++++
 doc/driver-model/MIGRATION.txt | 10 ++++++++++
 2 files changed, 20 insertions(+)
Makefile +10 -0
index 53046e763e0b..373939ddad94 100644
@@ -930,6 +930,16 @@ ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
 	@echo "===================================================="
 endif
 endif
+ifeq ($(CONFIG_USB),y)
+ifneq ($(CONFIG_DM_USB)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
+	@echo "===================== WARNING ======================"
+	@echo "This board does not use CONFIG_DM_USB. Please update"
+	@echo "the board to use CONFIG_DM_USB before the v2019.07 release."
+	@echo "Failure to update by the deadline may result in board removal."
+	@echo "See doc/driver-model/MIGRATION.txt for more info."
+	@echo "===================================================="
+endif
+endif
 	@# Check that this build does not use CONFIG options that we do not
 	@# know about unless they are in Kconfig. All the existing CONFIG
 	@# options are whitelisted, so new ones should not be added.
doc/driver-model/MIGRATION.txt +10 -0
index 71c26571828a..0b763f72a453 100644
@@ -15,6 +15,16 @@ The subsystem itself has been converted and maintainers should submit patches
 switching over to using CONFIG_DM_MMC and other base driver model options in
 time for inclusion in the 2019.04 rerelease.
 
+CONFIG_DM_USB
+-------------
+
+Status: In progress
+Deadline: 2019.07
+
+The subsystem itself has been converted along with many of the host controller
+and maintainers should submit patches switching over to using CONFIG_DM_USB and
+other base driver model options in time for inclusion in the 2019.07 rerelease.
+
 CONFIG_BLK
 ----------
 
Signature · 1 line
2.7.4
author
#8 lore raw

PATCH v3 2/4 dm: MIGRATION: Add migration plan for DM_USB

Quoted 6 lines · Tom Rini

As much of the USB system has been migrated to DM now, formalize a deadline for migration.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181203/e5b5595a/attachment.sig>
#9 lore raw

PATCH v3 2/4 dm: MIGRATION: Add migration plan for DM_USB

Hi Tom,

Quoted 10 lines · Tom Rini
Quoted 6 lines · Tom Rini

As much of the USB system has been migrated to DM now, formalize a deadline for migration.

Applied to u-boot/master, thanks!

Just a quick note on this, since I just tested compiling current mainline on MVEBU "theadorable_debug". Here I get:

===================== WARNING ======================
This board does not use CONFIG_DM_USB. Please update
the board to use CONFIG_DM_USB before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================
===================== WARNING ======================
This board does not use CONFIG_DM_SCSI. Please update
the storage controller to use CONFIG_DM_SCSI before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================

The DM_SCSI warning seems to be okay, because of the not converted ATA driver sata_mv.c (the controller is unfortunately not AHCI compatible). I hope to find some time shortly to work on this.

But the board definitely uses DM_USB:

$ gg DM_USB configs/theadorable_debug_defconfig
configs/theadorable_debug_defconfig:CONFIG_DM_USB=y

So the DM_USB warning seems to be wrong here.

Thanks,
Stefan

author
#10 lore raw

PATCH v3 2/4 dm: MIGRATION: Add migration plan for DM_USB

Quoted 34 lines · Stefan Roese

Hi Tom,

Quoted 10 lines · Tom Rini
Quoted 6 lines · Tom Rini

As much of the USB system has been migrated to DM now, formalize a deadline for migration.

Applied to u-boot/master, thanks!

Just a quick note on this, since I just tested compiling current mainline on MVEBU "theadorable_debug". Here I get:

===================== WARNING ======================
This board does not use CONFIG_DM_USB. Please update
the board to use CONFIG_DM_USB before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================
===================== WARNING ======================
This board does not use CONFIG_DM_SCSI. Please update
the storage controller to use CONFIG_DM_SCSI before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================

The DM_SCSI warning seems to be okay, because of the not converted ATA driver sata_mv.c (the controller is unfortunately not AHCI compatible). I hope to find some time shortly to work on this.

Quoted 6 lines

But the board definitely uses DM_USB:

$ gg DM_USB configs/theadorable_debug_defconfig
configs/theadorable_debug_defconfig:CONFIG_DM_USB=y

So the DM_USB warning seems to be wrong here.

I think you're "stuck" here because you can't turn on CONFIG_BLK to silence the CONFIG_DM_USB warning without then breaking sata_mv.c. The CONFIG_DM_USB migration isn't complete until you're also using CONFIG_BLK.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181205/391ef117/attachment.sig>
#11 lore raw

PATCH v3 2/4 dm: MIGRATION: Add migration plan for DM_USB

Quoted 41 lines · Tom Rini
Quoted 39 lines · Stefan Roese

Hi Tom,

Quoted 10 lines · Tom Rini
Quoted 6 lines · Tom Rini

As much of the USB system has been migrated to DM now, formalize a deadline for migration.

Applied to u-boot/master, thanks!

Just a quick note on this, since I just tested compiling current mainline on MVEBU "theadorable_debug". Here I get:

===================== WARNING ======================
This board does not use CONFIG_DM_USB. Please update
the board to use CONFIG_DM_USB before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================
===================== WARNING ======================
This board does not use CONFIG_DM_SCSI. Please update
the storage controller to use CONFIG_DM_SCSI before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================

The DM_SCSI warning seems to be okay, because of the not converted ATA driver sata_mv.c (the controller is unfortunately not AHCI compatible). I hope to find some time shortly to work on this.

But the board definitely uses DM_USB:

$ gg DM_USB configs/theadorable_debug_defconfig
configs/theadorable_debug_defconfig:CONFIG_DM_USB=y
Quoted 6 lines
Quoted 1 line

So the DM_USB warning seems to be wrong here.

I think you're "stuck" here because you can't turn on CONFIG_BLK to silence the CONFIG_DM_USB warning without then breaking sata_mv.c. The CONFIG_DM_USB migration isn't complete until you're also using CONFIG_BLK.

On a related note. I'm looking at adding a new board and have CONFIG_DM_USB and CONFIG_USB_STORAGE enabled but I trip over the same warning. This board doesn't enable SATA so I'm not trapped like the theadorable boards but enabling CONFIG_BLK just to silence the warning seems a bit wrong. Am I missing something?

author
#12 lore raw

PATCH v3 2/4 dm: MIGRATION: Add migration plan for DM_USB

Quoted 49 lines · Chris Packham
Quoted 41 lines · Tom Rini
Quoted 39 lines · Stefan Roese

Hi Tom,

Quoted 10 lines · Tom Rini
Quoted 6 lines · Tom Rini

As much of the USB system has been migrated to DM now, formalize a deadline for migration.

Applied to u-boot/master, thanks!

Just a quick note on this, since I just tested compiling current mainline on MVEBU "theadorable_debug". Here I get:

===================== WARNING ======================
This board does not use CONFIG_DM_USB. Please update
the board to use CONFIG_DM_USB before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================
===================== WARNING ======================
This board does not use CONFIG_DM_SCSI. Please update
the storage controller to use CONFIG_DM_SCSI before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================

The DM_SCSI warning seems to be okay, because of the not converted ATA driver sata_mv.c (the controller is unfortunately not AHCI compatible). I hope to find some time shortly to work on this.

But the board definitely uses DM_USB:

$ gg DM_USB configs/theadorable_debug_defconfig
configs/theadorable_debug_defconfig:CONFIG_DM_USB=y
Quoted 6 lines
Quoted 1 line

So the DM_USB warning seems to be wrong here.

I think you're "stuck" here because you can't turn on CONFIG_BLK to silence the CONFIG_DM_USB warning without then breaking sata_mv.c. The CONFIG_DM_USB migration isn't complete until you're also using CONFIG_BLK.

Quoted 5 lines

On a related note. I'm looking at adding a new board and have CONFIG_DM_USB and CONFIG_USB_STORAGE enabled but I trip over the same warning. This board doesn't enable SATA so I'm not trapped like the theadorable boards but enabling CONFIG_BLK just to silence the warning seems a bit wrong. Am I missing something?

No, enabling CONFIG_BLK is what's needed. We can't select/depend on it in all cases that we would like yet but enabling it enables other functionality.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181206/12c3592f/attachment.sig>
author
#13 lore raw

PATCH v3 3/4 dm: MIGRATION: Add migration plan for CONFIG_SATA

In reply to Tom Rini

As the core of the subsystem has been converted along with some of the drivers, formalize a deadline for migration.

Cc Akshay Bhat <[email protected]>
Cc Andreas Geisreiter <[email protected]>
Cc Bin Meng <[email protected]>
Cc Christian Gmeiner <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Jason Liu <[email protected]>
Cc Ken Lin <[email protected]>
Cc Ludwig Zenz <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Max Krummenacher <[email protected]>
Cc Nikita Kiryanov <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Peng Fan <[email protected]>
Cc Soeren Moch <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Tim Harvey <[email protected]>
Cc Troy Kisky <[email protected]>
Cc Tuomas Tynkkynen <[email protected]>
Cc York Sun <[email protected]>

---
Changes in v2:
- Note that failure to migration may lead to removal.
- Even more Ccs

Apologies for the scattershot CC list here. A problem with this particular migration is we have a number of drivers for older platforms without clear ownership. Please feel free to loop in other people you know that might have interest here. Thanks!

---
 Makefile                       |  8 ++++++++
 doc/driver-model/MIGRATION.txt | 10 ++++++++++
 2 files changed, 18 insertions(+)
Makefile +8 -0
index 373939ddad94..5e377c3fd5a6 100644
@@ -940,6 +940,14 @@ ifneq ($(CONFIG_DM_USB)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
 	@echo "===================================================="
 endif
 endif
+ifeq ($(CONFIG_LIBATA)$(CONFIG_DM_SCSI)$(CONFIG_MVSATA_IDE),y)
+	@echo "===================== WARNING ======================"
+	@echo "This board does not use CONFIG_DM_SCSI. Please update"
+	@echo "the storage controller to use CONFIG_DM_SCSI before the v2019.07 release."
+	@echo "Failure to update by the deadline may result in board removal."
+	@echo "See doc/driver-model/MIGRATION.txt for more info."
+	@echo "===================================================="
+endif
 	@# Check that this build does not use CONFIG options that we do not
 	@# know about unless they are in Kconfig. All the existing CONFIG
 	@# options are whitelisted, so new ones should not be added.
doc/driver-model/MIGRATION.txt +10 -0
index 0b763f72a453..6df7e02a63de 100644
@@ -25,6 +25,16 @@ The subsystem itself has been converted along with many of the host controller
 and maintainers should submit patches switching over to using CONFIG_DM_USB and
 other base driver model options in time for inclusion in the 2019.07 rerelease.
 
+CONFIG_SATA
+-----------
+
+Status: In progress
+Deadline: 2019.07
+
+The subsystem itself has been converted along with many of the host controller
+and maintainers should submit patches switching over to using CONFIG_AHCI and
+other base driver model options in time for inclusion in the 2019.07 rerelease.
+
 CONFIG_BLK
 ----------
 
Signature · 1 line
2.7.4
author
#14 lore raw

PATCH v3 3/4 dm: MIGRATION: Add migration plan for CONFIG_SATA

Quoted 17 lines · Tom Rini

As the core of the subsystem has been converted along with some of the drivers, formalize a deadline for migration.

Cc Akshay Bhat <[email protected]>
Cc Andreas Geisreiter <[email protected]>
Cc Bin Meng <[email protected]>
Cc Christian Gmeiner <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Jason Liu <[email protected]>
Cc Ken Lin <[email protected]>
Cc Ludwig Zenz <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Max Krummenacher <[email protected]>
Cc Nikita Kiryanov <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Peng Fan <[email protected]>
Quoted 8 lines
Cc Soeren Moch <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Tim Harvey <[email protected]>
Cc Troy Kisky <[email protected]>
Cc Tuomas Tynkkynen <[email protected]>
Cc York Sun <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181203/c74d4ee3/attachment.sig>
#15 lore raw

PATCH v3 1/4 dm: MIGRATION: Add migration plan for DM_MMC

In reply to Tom Rini
Quoted 8 lines · Tom Rini

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Quoted 58 lines

---
Changes in v3:
- Ensure CONFIG_MMC is set
Changes in v2:
- Note that failure to migration may lead to removal.

---
 Makefile                       | 10 ++++++++++
 doc/driver-model/MIGRATION.txt |  9 +++++++++
 2 files changed, 19 insertions(+)
Makefile +10 -0
index a4b1d1db5241..53046e763e0b 100644
@@ -920,6 +920,16 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
        @echo "before sending patches to the mailing list."
        @echo "===================================================="
 endif
+ifeq ($(CONFIG_MMC),y)
+ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
+       @echo "===================== WARNING ======================"
+       @echo "This board does not use CONFIG_DM_MMC. Please update"
+       @echo "the board to use CONFIG_DM_MMC before the v2019.04 release."
+       @echo "Failure to update by the deadline may result in board removal."
+       @echo "See doc/driver-model/MIGRATION.txt for more info."
+       @echo "===================================================="
+endif
+endif
        @# Check that this build does not use CONFIG options that we do not
        @# know about unless they are in Kconfig. All the existing CONFIG
        @# options are whitelisted, so new ones should not be added.
doc/driver-model/MIGRATION.txt +9 -1
index 5ebefd608b99..71c26571828a 100644
@@ -5,6 +5,15 @@ U-Boot has been migrating to a new driver model since its introduction in
 2014. This file describes the schedule for deprecation of pre-driver-model
 features.
 
+CONFIG_DM_MMC
+-------------
+
+Status: In progress
+Deadline: 2019.04
+
+The subsystem itself has been converted and maintainers should submit patches
+switching over to using CONFIG_DM_MMC and other base driver model options in
+time for inclusion in the 2019.04 rerelease.
 
 CONFIG_BLK
 ----------
--

2.7.4

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

#16 lore raw

PATCH v3 1/4 dm: MIGRATION: Add migration plan for DM_MMC

Quoted 10 lines · Simon Goldschmidt
Quoted 5 lines · On Fri, Nov 30, 2018 at 12:21 AM Tom Rini <trini at konsulko.com…

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Quoted 5 lines
Quoted 3 lines
Reviewed-by Simon Glass <sjg at chromium.org <mailto:[email protected]>>
Cc Jaehoon Chung <jh80.chung at samsung.com <mailto:[email protected]>>
Signed-off-by Tom Rini <trini at konsulko.com <mailto:[email protected]>>
Reviewed-by Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com <mailto:[email protected]>>
author
#17 lore raw

PATCH v3 4/4 dm: MIGRATION: Update migration plan for BLK

In reply to Tom Rini

The biggest part of migration to using CONFIG_BLK is that we need to have the various subsystems migrated first, so reword the plan here to reference the new deadlines.

---
 doc/driver-model/MIGRATION.txt | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)
doc/driver-model/MIGRATION.txt +5 -7
index 6df7e02a63de..6b691338b4e7 100644
@@ -39,14 +39,12 @@ CONFIG_BLK
 ----------
 
 Status: In progress
-Deadline: 2018.05
-
-Maintainers should submit patches for enabling CONFIG_BLK on all boards in
-time for inclusion in the 2018.05 release. Boards not converted by this
-time may be removed in a subsequent release.
+Deadline: 2019.07
 
-Note that this implies use of driver model for all block devices (e.g.
-MMC, USB, SCSI, SATA).
+In concert with maintainers migrating their block device usage to the
+appropriate DM driver, CONFIG_BLK needs to be set as well.  The final deadline
+here coincides with the final deadline for migration of the various block
+subsystems.
 
 CONFIG_DM_SPI
 CONFIG_DM_SPI_FLASH
Signature · 1 line
2.7.4
author
#18 lore raw

PATCH v3 4/4 dm: MIGRATION: Update migration plan for BLK

Quoted 6 lines · Tom Rini

The biggest part of migration to using CONFIG_BLK is that we need to have the various subsystems migrated first, so reword the plan here to reference the new deadlines.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181203/a8997c79/attachment.sig>