coreboot: only init usb if necessary
PATCH 1/2 coreboot: only init usb if necessary
From: Thomas RIENOESSL <[email protected]>
Up until now the call to initialize the USB subsystem was hardcoded for U-Boot running as a coreboot payload. This was used to enable the use of a USB keyboard in the U-Boot shell. However not all boards might need this functionality. As initializing the USB subsystem can take a considerable amount of time (several seconds on some boards), we now initialize the USB subsystem only if U-Boot is configured to use USB keyboards.
---
arch/x86/cpu/coreboot/coreboot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/x86/cpu/coreboot/coreboot.c +2 -1
@@ -77,7 +77,8 @@ int last_stage_init(void)timestamp_add_to_bootstage ();/* start usb so that usb keyboard can be used as input device */ -usb_init (); +if (CONFIG_IS_ENABLED (USB_KEYBOARD )) +usb_init ();board_final_cleanup ();
Signature · 1 line
2.7.4
PATCH 2/2 efi: payload: only init usb if necessary
Up until now the call to initialize the USB subsystem was hardcoded for U-Boot running as an EFI payload. This was used to enable the use of a USB keyboard in the U-Boot shell. However not all boards might need this functionality. As initializing the USB subsystem can take a considerable amount of time (several seconds on some boards), we now initialize the USB subsystem only if U-Boot is configured to use USB keyboards.
---
arch/x86/cpu/efi/payload.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/x86/cpu/efi/payload.c +2 -1
@@ -166,7 +166,8 @@ int reserve_arch(void)int last_stage_init (void ) {/* start usb so that usb keyboard can be used as input device */ -usb_init (); +if (CONFIG_IS_ENABLED (USB_KEYBOARD )) +usb_init ();return 0 ; }
Signature · 1 line
2.7.4
PATCH 2/2 efi: payload: only init usb if necessary
Am Fr., 30. Nov. 2018 um 05:02 Uhr schrieb Bin Meng <[email protected]>:
Quoted 10 lines
Up until now the call to initialize the USB subsystem was hardcoded for U-Boot running as an EFI payload. This was used to enable the use of a USB keyboard in the U-Boot shell. However not all boards might need this functionality. As initializing the USB subsystem can take a considerable amount of time (several seconds on some boards), we now initialize the USB subsystem only if U-Boot is configured to use USB keyboards.
Signed-off-by Bin Meng <[email protected]>
Quoted 22 lines
---
arch/x86/cpu/efi/payload.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/x86/cpu/efi/payload.c +2
-2@@ -166,7 +166,8 @@ int reserve_arch(void)int last_stage_init (void ) {/* start usb so that usb keyboard can be used as input device */ -usb_init (); +if (CONFIG_IS_ENABLED (USB_KEYBOARD )) +usb_init ();return 0 ; } --2.7.4
Signature · 5 lines
greets -- Christian Gmeiner, MSc https://christian-gmeiner.info
PATCH 2/2 efi: payload: only init usb if necessary
Quoted 11 lines · Christian Gmeiner
Am Fr., 30. Nov. 2018 um 05:02 Uhr schrieb Bin Meng <[email protected]>:
Quoted 9 lines
Up until now the call to initialize the USB subsystem was hardcoded for U-Boot running as an EFI payload. This was used to enable the use of a USB keyboard in the U-Boot shell. However not all boards might need this functionality. As initializing the USB subsystem can take a considerable amount of time (several seconds on some boards), we now initialize the USB subsystem only if U-Boot is configured to use USB keyboards.
Quoted 3 lines
Quoted 1 line
Signed-off-by Bin Meng <[email protected]>Reviewed-by Christian Gmeiner <[email protected]>
applied to u-boot-x86, thanks!
PATCH 1/2 coreboot: only init usb if necessary
In reply to Bin MengAm Fr., 30. Nov. 2018 um 05:02 Uhr schrieb Bin Meng <[email protected]>:
Quoted 11 lines
From: Thomas RIENOESSL <[email protected]>
Up until now the call to initialize the USB subsystem was hardcoded for U-Boot running as a coreboot payload. This was used to enable the use of a USB keyboard in the U-Boot shell. However not all boards might need this functionality. As initializing the USB subsystem can take a considerable amount of time (several seconds on some boards), we now initialize the USB subsystem only if U-Boot is configured to use USB keyboards.
Quoted 3 lines
Signed-off-by Thomas RIENOESSL <[email protected]>Reviewed-by Bin Meng <[email protected]>Signed-off-by Bin Meng <[email protected]>
I totally forgot to send an updated version of this patch - thanks for doing this Bin!
Signature · 5 lines
greets -- Christian Gmeiner, MSc https://christian-gmeiner.info
PATCH 1/2 coreboot: only init usb if necessary
Quoted 13 lines · Christian Gmeiner
Am Fr., 30. Nov. 2018 um 05:02 Uhr schrieb Bin Meng <[email protected]>:
Quoted 11 lines
From: Thomas RIENOESSL <[email protected]>
Up until now the call to initialize the USB subsystem was hardcoded for U-Boot running as a coreboot payload. This was used to enable the use of a USB keyboard in the U-Boot shell. However not all boards might need this functionality. As initializing the USB subsystem can take a considerable amount of time (several seconds on some boards), we now initialize the USB subsystem only if U-Boot is configured to use USB keyboards.
Quoted 9 lines
Quoted 3 lines
Signed-off-by Thomas RIENOESSL <[email protected]>Reviewed-by Bin Meng <[email protected]>Signed-off-by Bin Meng <[email protected]>I totally forgot to send an updated version of this patch - thanks for doing this Bin!
Reviewed-by Christian Gmeiner <[email protected]>
applied to u-boot-x86, thanks!