Patch "powerpc/function_graph: Simplify with function_graph_enter()" has been added to the 4.19-stable tree
[email protected]
AppliedThis is a note to let you know that I've just added the patch titled
powerpc/function_graph: Simplify with function_graph_enter()
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
powerpc-function_graph-simplify-with-function_graph_enter.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
From fe60522ec60082a1dd735691b82c64f65d4ad15e Mon Sep 17 00:00:00 2001
From: "Steven Rostedt (VMware)" <[email protected]>
Date: Sun, 18 Nov 2018 17:28:53 -0500
Subject: powerpc/function_graph: Simplify with function_graph_enter()
From: Steven Rostedt (VMware) <[email protected]>
commit fe60522ec60082a1dd735691b82c64f65d4ad15e upstream.
The function_graph_enter() function does the work of calling the function graph hook function and the management of the shadow stack, simplifying the work done in the architecture dependent prepare_ftrace_return().
Have powerpc use the new code, and remove the shadow stack management as well as having to set up the trace structure.
This is needed to prepare for a fix of a design bug on how the curr_ret_stack is used.
--- arch/powerpc/kernel/trace/ftrace.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
arch/powerpc/kernel/trace/ftrace.c +2 -13
@@ -697,7 +697,6 @@ int ftrace_disable_ftrace_graph_caller(v*/ unsigned long prepare_ftrace_return (unsigned long parent,unsigned long ip) { -struct ftrace_graph_ent trace;unsigned long return_hooker;if (unlikely (ftrace_graph_is_dead ()))
@@ -708,18 +707,8 @@ unsigned long prepare_ftrace_return(unsi return_hooker =ppc_function_entry (return_to_handler); - trace.func = ip; - trace.depth = current->curr_ret_stack +1 ; - -/* Only trace if the calling function expects to */ -if (!ftrace_graph_entry (&trace)) - goto out; - -if (ftrace_push_return_trace (parent, ip, &trace.depth,0 , -NULL ) == -EBUSY ) - goto out; - - parent = return_hooker; +if (!function_graph_enter (parent, ip,0 ,NULL )) + parent = return_hooker; out:return parent; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.19/function_graph-create-function_graph_enter-to-consolidate-architecture-code.patch queue-4.19/sh-function_graph-simplify-with-function_graph_enter.patch queue-4.19/function_graph-move-return-callback-before-update-of-curr_ret_stack.patch queue-4.19/nds32-function_graph-simplify-with-function_graph_enter.patch queue-4.19/function_graph-use-new-curr_ret_depth-to-manage-depth-instead-of-curr_ret_stack.patch queue-4.19/sparc-function_graph-simplify-with-function_graph_enter.patch queue-4.19/parisc-function_graph-simplify-with-function_graph_enter.patch queue-4.19/x86-function_graph-simplify-with-function_graph_enter.patch queue-4.19/powerpc-function_graph-simplify-with-function_graph_enter.patch queue-4.19/function_graph-reverse-the-order-of-pushing-the-ret_stack-and-the-callback.patch queue-4.19/arm-function_graph-simplify-with-function_graph_enter.patch queue-4.19/mips-function_graph-simplify-with-function_graph_enter.patch queue-4.19/function_graph-make-ftrace_push_return_trace-static.patch queue-4.19/arm64-function_graph-simplify-with-function_graph_enter.patch queue-4.19/riscv-function_graph-simplify-with-function_graph_enter.patch queue-4.19/s390-function_graph-simplify-with-function_graph_enter.patch queue-4.19/microblaze-function_graph-simplify-with-function_graph_enter.patch queue-4.19/function_graph-have-profiler-use-curr_ret_stack-and-not-depth.patch
kbuild test robot
build botI love your patch! Yet something to improve:
Hi gregkh,
I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[cannot apply to v4.20-rc5 next-20181205]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/gregkh-linuxfoundation-org/Patch-powerpc-function_graph-Simplify-with-function_graph_enter-has-been-added-to-the-4-19-stable-tree/20181204-171923 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-defconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=powerpc
All errors (new ones prefixed by >>):
arch/powerpc/kernel/trace/ftrace.c: In function 'prepare_ftrace_return':
>> arch/powerpc/kernel/trace/ftrace.c:963:7: error: implicit declaration of function 'function_graph_enter'; did you mean 'ftrace_graph_entry'? [-Werror=implicit-function-declaration]
if (!function_graph_enter(parent, ip, 0, NULL))
^~~~~~~~~~~~~~~~~~~~ ftrace_graph_entry
cc1: all warnings being treated as errors
vim +963 arch/powerpc/kernel/trace/ftrace.c
946
947 /*
948 * Hook the return address and push it in the stack of return addrs
949 * in current thread info. Return the address we want to divert to.
950 */
951 unsigned long prepare_ftrace_return(unsigned long parent, unsigned long ip)
952 {
953 unsigned long return_hooker;
954
955 if (unlikely(ftrace_graph_is_dead()))
956 goto out;
957
958 if (unlikely(atomic_read(¤t->tracing_graph_pause)))
959 goto out;
960
961 return_hooker = ppc_function_entry(return_to_handler);
962
> 963 if (!function_graph_enter(parent, ip, 0, NULL))
964 parent = return_hooker;
965 out:
966 return parent;
967 }
968 #endif /* CONFIG_FUNCTION_GRAPH_TRACER */
969
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation