patch "staging: rtl8712: Fix possible buffer overrun" added to staging-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
staging: rtl8712: Fix possible buffer overrun
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
300cd664865bed5d50ae0a42fb4e3a6f415e8a10Mon Sep 17 00:00:00 2001
From: Young Xiao <[email protected]>
Date: Wed, 28 Nov 2018 08:06:53 +0000
Subject: staging: rtl8712: Fix possible buffer overrun
In commit 8b7a13c3f404 ("staging: r8712u: Fix possible buffer overrun") we fix a potential off by one by making the limit smaller. The better fix is to make the buffer larger. This makes it match up with the similar code in other drivers.
--- drivers/staging/rtl8712/mlme_linux.c | 2 +- drivers/staging/rtl8712/rtl871x_mlme.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8712/mlme_linux.c +1 -1
@@ -146,7 +146,7 @@ void r8712_report_sec_ie(struct _adapter *adapter, u8 authmode, u8 *sec_ie) p = buff; p +=sprintf (p,"ASSOCINFO(ReqIEs=" ); len = sec_ie[1 ] +2 ; - len = (len <IW_CUSTOM_MAX ) ? len :IW_CUSTOM_MAX -1 ; + len = (len <IW_CUSTOM_MAX ) ? len :IW_CUSTOM_MAX ;for (i =0 ; i < len; i++) p +=sprintf (p,"%02x" , sec_ie[i]); p +=sprintf (p,")" );
drivers/staging/rtl8712/rtl871x_mlme.c +1 -1
@@ -1346,7 +1346,7 @@ sint r8712_restruct_sec_ie(struct _adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_len) {u8 authmode =0 , match; -u8 sec_ie[255 ], uncst_oui[4 ], bkup_ie[255 ]; +u8 sec_ie[IW_CUSTOM_MAX ], uncst_oui[4 ], bkup_ie[255 ];u8 wpa_oui[4 ] = {0x0 ,0x50 ,0xf2 ,0x01 };uint ielength, cnt, remove_cnt;int iEntry;
Signature · 1 line
2.19.2