Staging: iio: adis16203: fixed a SPDX identifier tag mistake
Subsystems (4)
PATCH 2/2 Staging: iio: adis16203: fixed a SPDX identifier tag mistake
Fixed a coding style mistake by adding the SPDX identifier tag to the first line of the code
Signed-off-by Amir Mahdi Ghorbanian <[email protected]>
--- drivers/staging/iio/accel/adis16203.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/accel/adis16203.c +1 -1
@@ -1,9 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0+ /* * ADIS16203 Programmable 360 Degrees Inclinometer * * Copyright 2010 Analog Devices Inc. * -* Licensed under the GPL-2 or later. */ #include <linux/delay.h>
Signature · 1 line
2.7.4
Jonathan Cameron
maintainerQuoted 4 lines · On Thu, 20 Dec 2018 15:46:53 -0800 Amir Mahdi Ghorbanian…
Fixed a coding style mistake by adding the SPDX identifier tag to the first line of the code
Signed-off-by Amir Mahdi Ghorbanian <[email protected]>
Two things. It's not a 'mistake' as this driver massively predates the use of SPDX tags! Also, there is a problem here as it's current licensing is inconsistent. The MODULE_LICENSE is GPL-2.0 which would be GPL-2.0 (no +) but the original comment was +.
Michael, do you want to take a view on this one? Copyright is Analog's so should be fine if you say what is preferred.
Thanks,
Jonathan
Quoted 19 lines
--- drivers/staging/iio/accel/adis16203.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/iio/accel/adis16203.c +1
-1@@ -1,9 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0+ /* * ADIS16203 Programmable 360 Degrees Inclinometer * * Copyright 2010 Analog Devices Inc. * -* Licensed under the GPL-2 or later. */ #include <linux/delay.h>