Skip to contentSkip to conversation

MAINTAINERS: Add some missing SPARC-related files

PATCH In review Thomas Huth 3 participants 5 messages Jan 2, 2019 – Jan 3, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Add some missing SPARC-related files

These files / devices are only used by SPARC machines, so we can sort them into the corresponding categories in the MAINTAINERS file.

---
 MAINTAINERS | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
MAINTAINERS +5 -1
index b6c2645..e897963 100644
@@ -1069,9 +1069,11 @@ M: Mark Cave-Ayland <[email protected]>
 S: Maintained
 F: hw/sparc/sun4m.c
 F: hw/sparc/sun4m_iommu.c
+F: hw/display/cg3.c
+F: hw/display/tcx.c
 F: hw/dma/sparc32_dma.c
 F: hw/misc/eccmemctl.c
-F: hw/misc/slavio_misc.c
+F: hw/*/slavio_*.c
 F: include/hw/sparc/sparc32_dma.h
 F: pc-bios/openbios-sparc32
 F: include/hw/sparc/sun4m_iommu.h
@@ -1083,6 +1085,8 @@ F: hw/sparc64/sun4u.c
 F: pc-bios/openbios-sparc64
 F: hw/pci-host/sabre.c
 F: include/hw/pci-host/sabre.h
+F: include/hw/sparc/sun4u_iommu.h
+F: include/hw/nvram/sun_nvram.h
 
 Sun4v
 M: Artyom Tarasenko <[email protected]>
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Thomas,

Quoted 26 lines · Thomas Huth

These files / devices are only used by SPARC machines, so we can sort them into the corresponding categories in the MAINTAINERS file.

---
 MAINTAINERS | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
MAINTAINERS +3 -1
index b6c2645..e897963 100644
@@ -1069,9 +1069,11 @@ M: Mark Cave-Ayland <[email protected]>
 S: Maintained
 F: hw/sparc/sun4m.c
 F: hw/sparc/sun4m_iommu.c
+F: hw/display/cg3.c
+F: hw/display/tcx.c
 F: hw/dma/sparc32_dma.c
 F: hw/misc/eccmemctl.c
-F: hw/misc/slavio_misc.c
+F: hw/*/slavio_*.c
 F: include/hw/sparc/sparc32_dma.h
 F: pc-bios/openbios-sparc32
 F: include/hw/sparc/sun4m_iommu.h

MAINTAINERS F: hw/sparc64/sun4u.c · line 1088

Quoted 4 lines
MAINTAINERS +1 -0
@@ -1083,6 +1085,8 @@ F: hw/sparc64/sun4u.c
 F: pc-bios/openbios-sparc64
 F: hw/pci-host/sabre.c
 F: include/hw/pci-host/sabre.h
+F: include/hw/sparc/sun4u_iommu.h

I sent a patch to trivial@ with other sun4u changes, reviewed by Mark:
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04467.html

Neither mine nor your are complete :)
Can I include your patch when respining the series? (Not sure I need to respin although).

MAINTAINERS F: hw/sparc64/sun4u.c · line 1089

Quoted 1 line
MAINTAINERS +1 -0
+F: include/hw/nvram/sun_nvram.h

sun_nvram.h is also used by sun4m (the previous section this patch updates).

MAINTAINERS F: hw/sparc64/sun4u.c

Quoted 4 lines
MAINTAINERS +0 -0
 Sun4v
 M: Artyom Tarasenko <[email protected]>
 
#2 lore raw
Quoted 28 lines · Philippe Mathieu-Daudé

Hi Thomas,

Quoted 25 lines · Thomas Huth

These files / devices are only used by SPARC machines, so we can sort them into the corresponding categories in the MAINTAINERS file.

---
 MAINTAINERS | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
MAINTAINERS +3 -1
index b6c2645..e897963 100644
@@ -1069,9 +1069,11 @@ M: Mark Cave-Ayland <[email protected]>
 S: Maintained
 F: hw/sparc/sun4m.c
 F: hw/sparc/sun4m_iommu.c
+F: hw/display/cg3.c
+F: hw/display/tcx.c
 F: hw/dma/sparc32_dma.c
 F: hw/misc/eccmemctl.c
-F: hw/misc/slavio_misc.c
+F: hw/*/slavio_*.c
 F: include/hw/sparc/sparc32_dma.h
 F: pc-bios/openbios-sparc32
 F: include/hw/sparc/sun4m_iommu.h
Quoted 8 lines

MAINTAINERS F: hw/sparc64/sun4u.c · line 1088

Quoted 5 lines
MAINTAINERS +1 -0
@@ -1083,6 +1085,8 @@ F: hw/sparc64/sun4u.c
 F: pc-bios/openbios-sparc64
 F: hw/pci-host/sabre.c
 F: include/hw/pci-host/sabre.h
+F: include/hw/sparc/sun4u_iommu.h

I sent a patch to trivial@ with other sun4u changes, reviewed by Mark:
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04467.html

Oh, right, sorry!

Quoted 3 lines

Neither mine nor your are complete :)
Can I include your patch when respining the series? (Not sure I need to respin although).

Sure!

Quoted 3 lines

MAINTAINERS F: hw/sparc64/sun4u.c · line 1089

Quoted 1 line
MAINTAINERS +1 -0
+F: include/hw/nvram/sun_nvram.h

sun_nvram.h is also used by sun4m (the previous section this patch updates).

Right. So it should maybe be listed twice... (but since the maintainer of sun4u and sun4m is the same, it likely does not really matter)

Thomas

#3 lore raw
Quoted 38 lines · Thomas Huth
Quoted 28 lines · Philippe Mathieu-Daudé

Hi Thomas,

Quoted 25 lines · Thomas Huth

These files / devices are only used by SPARC machines, so we can sort them into the corresponding categories in the MAINTAINERS file.

---
 MAINTAINERS | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
MAINTAINERS +3 -1
index b6c2645..e897963 100644
@@ -1069,9 +1069,11 @@ M: Mark Cave-Ayland <[email protected]>
 S: Maintained
 F: hw/sparc/sun4m.c
 F: hw/sparc/sun4m_iommu.c
+F: hw/display/cg3.c
+F: hw/display/tcx.c
 F: hw/dma/sparc32_dma.c
 F: hw/misc/eccmemctl.c
-F: hw/misc/slavio_misc.c
+F: hw/*/slavio_*.c
 F: include/hw/sparc/sparc32_dma.h
 F: pc-bios/openbios-sparc32
 F: include/hw/sparc/sun4m_iommu.h
Quoted 8 lines

MAINTAINERS F: hw/sparc64/sun4u.c · line 1088

Quoted 5 lines
MAINTAINERS +1 -0
@@ -1083,6 +1085,8 @@ F: hw/sparc64/sun4u.c
 F: pc-bios/openbios-sparc64
 F: hw/pci-host/sabre.c
 F: include/hw/pci-host/sabre.h
+F: include/hw/sparc/sun4u_iommu.h

I sent a patch to trivial@ with other sun4u changes, reviewed by Mark:
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04467.html

Quoted 7 lines

Oh, right, sorry!

Quoted 3 lines

Neither mine nor your are complete :)
Can I include your patch when respining the series? (Not sure I need to respin although).

Sure!

Certainly these extra files look correct to me - Philippe, I think I already gave R-B tags for these, so feel free to keep them when you re-post the series with Thomas's changes.

ATB,

Mark.

#4 lore raw
In reply to Thomas Huth
Quoted 1 line · Thomas Huth

On 2019-01-02 20:34, Philippe Mathieu-Daudé wrote:

[...]

Quoted 10 lines
Quoted 2 lines

I sent a patch to trivial@ with other sun4u changes, reviewed by Mark:
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04467.html

Oh, right, sorry!

Quoted 3 lines

Neither mine nor your are complete :)
Can I include your patch when respining the series? (Not sure I need to respin although).

Sure!

Thanks :)

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

+F: include/hw/nvram/sun_nvram.h

sun_nvram.h is also used by sun4m (the previous section this patch updates).

Right. So it should maybe be listed twice... (but since the maintainer of sun4u and sun4m is the same, it likely does not really matter)

Yes, this is true as of today, but maybe tomorrow the current maintainer will give over one of these sections to someone else...