Skip to contentSkip to conversation

imx: video: Fix return value issue

PATCH New Ye Li 3 participants 3 messages Jan 4, 2019 – Jan 28, 2019

Subsystems (3)
lore
Share & tools
lore

Ye Li

author
#0 lore raw

PATCH 1/1 imx: video: Fix return value issue

When framebuffer driver init is failed, we should return the err value not 0. So the video init can exit immediately.

---
 arch/arm/mach-imx/video.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-imx/video.c +2 -2
index b40ce53..953fe53 100644
@@ -7,7 +7,7 @@
 int board_video_skip(void)
 {
 	int i;
-	int ret;
+	int ret = 0;
 	char const *panel = env_get("panel");
 
 	if (!panel) {
@@ -50,7 +50,7 @@ int board_video_skip(void)
 		return -EINVAL;
 	}
 
-	return 0;
+	return ret;
 }
 
 #ifdef CONFIG_IMX_HDMI
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 imx: video: Fix return value issue

Quoted 32 lines

-----Original Message-----
From: Ye Li
Sent: 2019年1月4日 17:11
To: sbabic at denx.de; u-boot at lists.denx.de
Cc: Fabio Estevam <[email protected]>; Peng Fan <[email protected]>; dl-uboot-imx <[email protected]>
Subject: [PATCH] imx: video: Fix return value issue

When framebuffer driver init is failed, we should return the err value not 0. So the video init can exit immediately.

---
 arch/arm/mach-imx/video.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-imx/video.c index renamed from arch/arm/mach-imx/video.c +0 -0

b40ce53..953fe53 100644

arch/arm/mach-imx/video.c +1 -1
@@ -7,7 +7,7 @@
 int board_video_skip(void)
 {
 	int i;
-	int ret;
+	int ret = 0;
 	char const *panel = env_get("panel");
 
 	if (!panel) {

arch/arm/mach-imx/video.c int board_video_skip(void) · line 56

Quoted 8 lines
arch/arm/mach-imx/video.c +1 -1
@@ -50,7 +50,7 @@ int board_video_skip(void)
 		return -EINVAL;
 	}
 
-	return 0;
+	return ret;
 }
 
 #ifdef CONFIG_IMX_HDMI
Quoted 2 lines

--
2.7.4

#2 lore raw

PATCH 1/1 imx: video: Fix return value issue

In reply to Ye Li
Quoted 7 lines · On Fri, 4 Jan 2019 09:11:05 +0000 Ye Li ye.li at nxp.com wrote:

When framebuffer driver init is failed, we should return the err value not 0. So the video init can exit immediately.

---
 arch/arm/mach-imx/video.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to u-boot-video/master, thanks!

--
Anatolij