trivial: Don't include isa.h if it is not really necessary
PATCH 1/1 trivial: Don't include isa.h if it is not really necessary
These files don't seem to do anything related to ISA directly, so there is no need to include isa.h here.
Signed-off-by Thomas Huth <[email protected]>
--- hw/display/ramfb-standalone.c | 1 - hw/ide/pci.c | 1 - hw/ide/piix.c | 1 - hw/ide/via.c | 1 - hw/misc/macio/mac_dbdma.c | 1 - hw/moxie/moxiesim.c | 1 - hw/nvram/fw_cfg.c | 1 - hw/sparc/sun4m.c | 1 - hw/timer/i8254.c | 1 - 9 files changed, 9 deletions(-)
hw/display/ramfb-standalone.c +0 -1
@@ -1,7 +1,6 @@#include "qemu/osdep.h" #include "qapi/error.h" #include "hw/loader.h" -#include "hw/isa/isa.h" #include "hw/display/ramfb.h" #include "ui/console.h" #include "sysemu/sysemu.h"
hw/ide/pci.c +0 -1
@@ -25,7 +25,6 @@#include "qemu/osdep.h" #include "hw/hw.h" #include "hw/pci/pci.h" -#include "hw/isa/isa.h" #include "sysemu/dma.h" #include "qemu/error-report.h" #include "hw/ide/pci.h"
hw/ide/piix.c +0 -1
@@ -26,7 +26,6 @@#include "qemu/osdep.h" #include "hw/hw.h" #include "hw/pci/pci.h" -#include "hw/isa/isa.h" #include "sysemu/block-backend.h" #include "sysemu/sysemu.h" #include "sysemu/blockdev.h"
hw/ide/via.c +0 -1
@@ -26,7 +26,6 @@#include "qemu/osdep.h" #include "hw/hw.h" #include "hw/pci/pci.h" -#include "hw/isa/isa.h" #include "sysemu/sysemu.h" #include "sysemu/dma.h"
hw/misc/macio/mac_dbdma.c +0 -1
@@ -38,7 +38,6 @@*/ #include "qemu/osdep.h" #include "hw/hw.h" -#include "hw/isa/isa.h" #include "hw/ppc/mac_dbdma.h" #include "qemu/main-loop.h" #include "qemu/log.h"
hw/moxie/moxiesim.c +0 -1
@@ -31,7 +31,6 @@#include "cpu.h" #include "hw/sysbus.h" #include "hw/hw.h" -#include "hw/isa/isa.h" #include "net/net.h" #include "sysemu/sysemu.h" #include "hw/boards.h"
hw/nvram/fw_cfg.c +0 -1
@@ -27,7 +27,6 @@#include "sysemu/sysemu.h" #include "sysemu/dma.h" #include "hw/boards.h" -#include "hw/isa/isa.h" #include "hw/nvram/fw_cfg.h" #include "hw/sysbus.h" #include "trace.h"
hw/sparc/sun4m.c +0 -1
@@ -37,7 +37,6 @@#include "net/net.h" #include "hw/boards.h" #include "hw/scsi/esp.h" -#include "hw/isa/isa.h" #include "hw/nvram/sun_nvram.h" #include "hw/nvram/chrp_nvram.h" #include "hw/nvram/fw_cfg.h"
hw/timer/i8254.c +0 -1
@@ -23,7 +23,6 @@*/ #include "qemu/osdep.h" #include "hw/hw.h" -#include "hw/isa/isa.h" #include "qemu/timer.h" #include "hw/timer/i8254.h" #include "hw/timer/i8254_internal.h"
Signature · 1 line
1.8.3.1
Laurent Vivier
AppliedQuoted 4 lines · Thomas Huth
These files don't seem to do anything related to ISA directly, so there is no need to include
isa.hhere.Signed-off-by Thomas Huth <[email protected]>
Quoted 12 lines
--- hw/display/ramfb-standalone.c | 1 - hw/ide/pci.c | 1 - hw/ide/piix.c | 1 - hw/ide/via.c | 1 - hw/misc/macio/mac_dbdma.c | 1 - hw/moxie/moxiesim.c | 1 - hw/nvram/fw_cfg.c | 1 - hw/sparc/sun4m.c | 1 - hw/timer/i8254.c | 1 - 9 files changed, 9 deletions(-)
Applied to my trivial-patches branch.
Thanks,
Laurent