Skip to contentSkip to conversation

arm: ti: boot: Fix am57xx evm fdtfile name

PATCH New Praneeth Bajjuri 3 participants 3 messages Jan 9, 2019 – Jan 10, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: ti: boot: Fix am57xx evm fdtfile name

am57xx evm uses am57xx-evm-reva3.dtb.
update findfdt to pick the correct default dtb

---
 include/environment/ti/boot.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/environment/ti/boot.h +1 -1
index 86ff6d3ea7c6..c9ad3046acaa 100644
@@ -125,7 +125,7 @@
 		"if test $board_name = am57xx_evm; then " \
 			"setenv fdtfile am57xx-beagle-x15.dtb; fi;" \
 		"if test $board_name = am57xx_evm_reva3; then " \
-			"setenv fdtfile am57xx-beagle-x15.dtb; fi;" \
+			"setenv fdtfile am57xx-evm-reva3.dtb; fi;" \
 		"if test $board_name = am571x_idk; then " \
 			"setenv fdtfile am571x-idk.dtb; fi;" \
 		"if test $fdtfile = undefined; then " \
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 arm: ti: boot: Fix am57xx evm fdtfile name

Quoted 13 lines · Praneeth Bajjuri

am57xx evm uses am57xx-evm-reva3.dtb.
update findfdt to pick the correct default dtb

---
 include/environment/ti/boot.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/environment/ti/boot.h +0 -0
index 86ff6d3ea7c6..c9ad3046acaa 100644

include/environment/ti/boot.h line 128

Quoted 5 lines
include/environment/ti/boot.h +1 -1
@@ -125,7 +125,7 @@
 		"if test $board_name = am57xx_evm; then " \
 			"setenv fdtfile am57xx-beagle-x15.dtb; fi;" \
 		"if test $board_name = am57xx_evm_reva3; then " \
-			"setenv fdtfile am57xx-beagle-x15.dtb; fi;" \
+			"setenv fdtfile am57xx-evm-reva3.dtb; fi;" \

I do not see this dts in kernel. Either it is not upstream or we are suposed to use overlays in this case.

Thanks and regards,
Lokesh

Quoted 4 lines
include/environment/ti/boot.h +0 -0
 		"if test $board_name = am571x_idk; then " \
 			"setenv fdtfile am571x-idk.dtb; fi;" \
 		"if test $fdtfile = undefined; then " \
#2 lore raw

PATCH 1/1 arm: ti: boot: Fix am57xx evm fdtfile name

Hi Lokesh,

Quoted 12 lines · Lokesh Vutla
Quoted 8 lines · Praneeth Bajjuri

am57xx evm uses am57xx-evm-reva3.dtb.
update findfdt to pick the correct default dtb

---
 include/environment/ti/boot.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines

include/environment/ti/boot.h line 128

Quoted 10 lines
include/environment/ti/boot.h +1 -1
index 86ff6d3ea7c6..c9ad3046acaa 100644
@@ -125,7 +125,7 @@
              "if test $board_name = am57xx_evm; then " \
                      "setenv fdtfile am57xx-beagle-x15.dtb; fi;" \
              "if test $board_name = am57xx_evm_reva3; then " \
-                     "setenv fdtfile am57xx-beagle-x15.dtb; fi;" \
+                     "setenv fdtfile am57xx-evm-reva3.dtb; fi;" \

I do not see this dts in kernel. Either it is not upstream or we are suposed to use overlays in this case.

Agreed. We should target upstream kernel in upstream U-Boot. So we should either:
1. Add corresponding dtb/dtbo files for AM57x EVM in upstream kernel first
2. Or drop this patch and continue using X15 dtb for EVM.

As I understand, (1) is not going to happen any time soon (though I would prefer this solution, as EVM already happened and being used). So we should probably stick to (2).

Quoted 7 lines

Thanks and regards,
Lokesh

Quoted 4 lines
include/environment/ti/boot.h +0 -0
              "if test $board_name = am571x_idk; then " \
                      "setenv fdtfile am571x-idk.dtb; fi;" \
              "if test $fdtfile = undefined; then " \