Skip to contentSkip to conversation

fsi: sbefifo: Don't fail operations when in SBE IPL state

PATCH In review Eddie James 4 participants 5 messages Jan 21, 2019 – Jun 25, 2019 FSI

lore
Share & tools
lore

Eddie James

author maintainer
#0 lore raw

PATCH 1/1 fsi: sbefifo: Don't fail operations when in SBE IPL state

SBE fifo operations should be allowed while the SBE is in any of the "IPL" states. Operations should succeed in this state.

---
 drivers/fsi/fsi-sbefifo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/fsi/fsi-sbefifo.c +2 -2
index c7d13ac..f7665b3 100644
@@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo *sbefifo)
 	switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >> CFAM_SBM_SBE_STATE_SHIFT) {
 	case SBE_STATE_UNKNOWN:
 		return -ESHUTDOWN;
+	case SBE_STATE_DMT:
+		return -EBUSY;
 	case SBE_STATE_IPLING:
 	case SBE_STATE_ISTEP:
 	case SBE_STATE_MPIPL:
-	case SBE_STATE_DMT:
-		return -EBUSY;
 	case SBE_STATE_RUNTIME:
 	case SBE_STATE_DUMP: /* Not sure about that one */
 		break;
Signature · 1 line
1.8.3.1
Tested-by on v1 1/1
#1 lore raw

This fixed the problem I was having trying to issue istep operations to the SBE.

Quoted 26 lines · AEST Eddie James

SBE fifo operations should be allowed while the SBE is in any of the "IPL" states. Operations should succeed in this state.

---
 drivers/fsi/fsi-sbefifo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/fsi/fsi-sbefifo.c +0 -0
index c7d13ac..f7665b3 100644
@@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo
 *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >>

CFAM_SBM_SBE_STATE_SHIFT) { case SBE_STATE_UNKNOWN:

drivers/fsi/fsi-sbefifo.c +2 -2
 		return -ESHUTDOWN;
+	case SBE_STATE_DMT:
+		return -EBUSY;
 	case SBE_STATE_IPLING:
 	case SBE_STATE_ISTEP:
 	case SBE_STATE_MPIPL:
-	case SBE_STATE_DMT:
-		return -EBUSY;
 	case SBE_STATE_RUNTIME:
 	case SBE_STATE_DUMP: /* Not sure about that one */
 		break;
Reviewed-by
#2 lore raw
Quoted 11 lines · Alistair Popple
Quoted 4 lines · AEST Eddie James

SBE fifo operations should be allowed while the SBE is in any of the "IPL" states. Operations should succeed in this state.

This fixed the problem I was having trying to issue istep operations to the SBE.

This one slipped through the cracks.

Fixes 9f4a8a2d7f9d fsi/sbefifo: Add driver for the SBE FIFO

Greg, can you please queue this one up for 5.3?

Cheers,

Joel

Quoted 24 lines
Quoted 22 lines
---
 drivers/fsi/fsi-sbefifo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/fsi/fsi-sbefifo.c +0 -0
index c7d13ac..f7665b3 100644
@@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo
 *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >>

CFAM_SBM_SBE_STATE_SHIFT) { case SBE_STATE_UNKNOWN:

              return -ESHUTDOWN;
drivers/fsi/fsi-sbefifo.c +2 -2
+     case SBE_STATE_DMT:
+             return -EBUSY;
      case SBE_STATE_IPLING:
      case SBE_STATE_ISTEP:
      case SBE_STATE_MPIPL:
-     case SBE_STATE_DMT:
-             return -EBUSY;
      case SBE_STATE_RUNTIME:
      case SBE_STATE_DUMP: /* Not sure about that one */
              break;
#3 lore raw

Hi Greg,

Quoted 12 lines · Joel Stanley
Quoted 10 lines · Alistair Popple
Quoted 4 lines · AEST Eddie James

SBE fifo operations should be allowed while the SBE is in any of the "IPL" states. Operations should succeed in this state.

This fixed the problem I was having trying to issue istep operations to the SBE.

Quoted 8 lines
Quoted 1 line

This one slipped through the cracks.

Fixes 9f4a8a2d7f9d fsi/sbefifo: Add driver for the SBE FIFO

Greg, can you please queue this one up for 5.3?

Ping?

Quoted 29 lines

Cheers,

Joel

Quoted 24 lines
Quoted 22 lines
---
 drivers/fsi/fsi-sbefifo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/fsi/fsi-sbefifo.c +0 -0
index c7d13ac..f7665b3 100644
@@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo
 *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >>

CFAM_SBM_SBE_STATE_SHIFT) { case SBE_STATE_UNKNOWN:

              return -ESHUTDOWN;
drivers/fsi/fsi-sbefifo.c +2 -2
+     case SBE_STATE_DMT:
+             return -EBUSY;
      case SBE_STATE_IPLING:
      case SBE_STATE_ISTEP:
      case SBE_STATE_MPIPL:
-     case SBE_STATE_DMT:
-             return -EBUSY;
      case SBE_STATE_RUNTIME:
      case SBE_STATE_DUMP: /* Not sure about that one */
              break;
#4 lore raw
Quoted 17 lines · Joel Stanley

Hi Greg,

Quoted 14 lines · Joel Stanley
Quoted 11 lines · Alistair Popple
Quoted 4 lines · AEST Eddie James

SBE fifo operations should be allowed while the SBE is in any of the "IPL" states. Operations should succeed in this state.

This fixed the problem I was having trying to issue istep operations to the SBE.

Quoted 8 lines
Quoted 6 lines

This one slipped through the cracks.

Fixes 9f4a8a2d7f9d fsi/sbefifo: Add driver for the SBE FIFO

Greg, can you please queue this one up for 5.3?

Ping?

I don't see this in my queue at all, sorry. Can someone resend it in a format that I can apply it in with the needed tested-by and reviewed-by added to it?

thanks,

greg k-h