fsi: sbefifo: Don't fail operations when in SBE IPL state
Eddie James
maintainerPATCH 1/1 fsi: sbefifo: Don't fail operations when in SBE IPL state
SBE fifo operations should be allowed while the SBE is in any of the "IPL" states. Operations should succeed in this state.
--- drivers/fsi/fsi-sbefifo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/fsi/fsi-sbefifo.c +2 -2
@@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo *sbefifo)switch ((sbm &CFAM_SBM_SBE_STATE_MASK ) >>CFAM_SBM_SBE_STATE_SHIFT ) {case SBE_STATE_UNKNOWN :return -ESHUTDOWN ; +case SBE_STATE_DMT : +return -EBUSY ;case SBE_STATE_IPLING :case SBE_STATE_ISTEP :case SBE_STATE_MPIPL : -case SBE_STATE_DMT : -return -EBUSY ;case SBE_STATE_RUNTIME :case SBE_STATE_DUMP :/* Not sure about that one */ break ;
Signature · 1 line
1.8.3.1
This fixed the problem I was having trying to issue istep operations to the SBE.
Quoted 26 lines · AEST Eddie James
SBE fifo operations should be allowed while the SBE is in any of the "IPL" states. Operations should succeed in this state.
Signed-off-by Eddie James <[email protected]>--- drivers/fsi/fsi-sbefifo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/fsi/fsi-sbefifo.c +0
-0@@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >>
CFAM_SBM_SBE_STATE_SHIFT) { caseSBE_STATE_UNKNOWN:drivers/fsi/fsi-sbefifo.c +2
-2return -ESHUTDOWN ; +case SBE_STATE_DMT : +return -EBUSY ;case SBE_STATE_IPLING :case SBE_STATE_ISTEP :case SBE_STATE_MPIPL : -case SBE_STATE_DMT : -return -EBUSY ;case SBE_STATE_RUNTIME :case SBE_STATE_DUMP :/* Not sure about that one */ break ;
Joel Stanley
Reviewed-byQuoted 11 lines · Alistair Popple
Quoted 4 lines · AEST Eddie James
SBE fifo operations should be allowed while the SBE is in any of the "IPL" states. Operations should succeed in this state.
Signed-off-by Eddie James <[email protected]>This fixed the problem I was having trying to issue istep operations to the SBE.
Tested-by Alistair Popple <[email protected]>
This one slipped through the cracks.
Greg, can you please queue this one up for 5.3?
Cheers,
Joel
Quoted 24 lines
Quoted 22 lines
--- drivers/fsi/fsi-sbefifo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/fsi/fsi-sbefifo.c +0
-0@@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >>
CFAM_SBM_SBE_STATE_SHIFT) { caseSBE_STATE_UNKNOWN:return -ESHUTDOWN;drivers/fsi/fsi-sbefifo.c +2
-2+case SBE_STATE_DMT : +return -EBUSY ;case SBE_STATE_IPLING :case SBE_STATE_ISTEP :case SBE_STATE_MPIPL : -case SBE_STATE_DMT : -return -EBUSY ;case SBE_STATE_RUNTIME :case SBE_STATE_DUMP :/* Not sure about that one */ break ;
Hi Greg,
Quoted 12 lines · Joel Stanley
Quoted 10 lines · Alistair Popple
Quoted 4 lines · AEST Eddie James
SBE fifo operations should be allowed while the SBE is in any of the "IPL" states. Operations should succeed in this state.
Signed-off-by Eddie James <[email protected]>This fixed the problem I was having trying to issue istep operations to the SBE.
Quoted 8 lines
Quoted 1 line
Tested-by Alistair Popple <[email protected]>This one slipped through the cracks.
Fixes 9f4a8a2d7f9d fsi/sbefifo: Add driver for the SBE FIFOReviewed-by Joel Stanley <[email protected]>Greg, can you please queue this one up for 5.3?
Ping?
Quoted 29 lines
Cheers,
Joel
Quoted 24 lines
Quoted 22 lines
--- drivers/fsi/fsi-sbefifo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/fsi/fsi-sbefifo.c +0
-0@@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >>
CFAM_SBM_SBE_STATE_SHIFT) { caseSBE_STATE_UNKNOWN:return -ESHUTDOWN;drivers/fsi/fsi-sbefifo.c +2
-2+case SBE_STATE_DMT : +return -EBUSY ;case SBE_STATE_IPLING :case SBE_STATE_ISTEP :case SBE_STATE_MPIPL : -case SBE_STATE_DMT : -return -EBUSY ;case SBE_STATE_RUNTIME :case SBE_STATE_DUMP :/* Not sure about that one */ break ;
Quoted 17 lines · Joel Stanley
Hi Greg,
Quoted 14 lines · Joel Stanley
Quoted 11 lines · Alistair Popple
Quoted 4 lines · AEST Eddie James
SBE fifo operations should be allowed while the SBE is in any of the "IPL" states. Operations should succeed in this state.
Signed-off-by Eddie James <[email protected]>This fixed the problem I was having trying to issue istep operations to the SBE.
Tested-by Alistair Popple <[email protected]>
Quoted 8 lines
Quoted 6 lines
This one slipped through the cracks.
Fixes 9f4a8a2d7f9d fsi/sbefifo: Add driver for the SBE FIFOReviewed-by Joel Stanley <[email protected]>Greg, can you please queue this one up for 5.3?
Ping?
I don't see this in my queue at all, sorry. Can someone resend it in a format that I can apply it in with the needed tested-by and reviewed-by added to it?
thanks,
greg k-h