Skip to contentSkip to conversation

MAINTAINERS: XIVE is an interrupt controller, not a machine

PATCH Applied Thomas Huth 4 participants 4 messages Jan 30, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: XIVE is an interrupt controller, not a machine

The "XIVE" section is currently listed in the "PowerPC Machines" section, which is weird, since this is an interrupt controller device. Move it to the "Devices" section instead.

---
 MAINTAINERS | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
MAINTAINERS +8 -8
index b334b53..eac36b6 100644
@@ -1038,14 +1038,6 @@ F: tests/libqos/*spapr*
 F: tests/rtas*
 F: tests/libqos/rtas*
 
-XIVE
-M: David Gibson <[email protected]>
-M: Cédric Le Goater <[email protected]>
-L: [email protected]
-S: Supported
-F: hw/*/*xive*
-F: include/hw/*/*xive*
-
 virtex_ml507
 M: Edgar E. Iglesias <[email protected]>
 L: [email protected]
@@ -1645,6 +1637,14 @@ F: tests/libqos/fw_cfg.c
 F: tests/fw_cfg-test.c
 T: git https://github.com/philmd/qemu.git fw_cfg-next
 
+XIVE
+M: David Gibson <[email protected]>
+M: Cédric Le Goater <[email protected]>
+L: [email protected]
+S: Supported
+F: hw/*/*xive*
+F: include/hw/*/*xive*
+
 Subsystems
 ----------
 Audio
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 29 lines · Thomas Huth

The "XIVE" section is currently listed in the "PowerPC Machines" section, which is weird, since this is an interrupt controller device. Move it to the "Devices" section instead.

---
 MAINTAINERS | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
MAINTAINERS +0 -8
index b334b53..eac36b6 100644
@@ -1038,14 +1038,6 @@ F: tests/libqos/*spapr*
 F: tests/rtas*
 F: tests/libqos/rtas*
 
-XIVE
-M: David Gibson <[email protected]>
-M: Cédric Le Goater <[email protected]>
-L: [email protected]
-S: Supported
-F: hw/*/*xive*
-F: include/hw/*/*xive*
-
 virtex_ml507
 M: Edgar E. Iglesias <[email protected]>
 L: [email protected]

MAINTAINERS F: tests/libqos/fw_cfg.c · line 1645

Quoted 9 lines
MAINTAINERS +6 -0
@@ -1645,6 +1637,14 @@ F: tests/libqos/fw_cfg.c
 F: tests/fw_cfg-test.c
 T: git https://github.com/philmd/qemu.git fw_cfg-next
 
+XIVE
+M: David Gibson <[email protected]>
+M: Cédric Le Goater <[email protected]>
+L: [email protected]
+S: Supported
+F: hw/*/*xive*

F: hw/intc/*xive*

MAINTAINERS F: tests/libqos/fw_cfg.c · line 1646

Quoted 1 line
MAINTAINERS +1 -0
+F: include/hw/*/*xive*

I'd expect them in /intc/ like the source, but they are in:

F: include/hw/ppc/*xive*

MAINTAINERS F: tests/libqos/fw_cfg.c · line 1650

Quoted 5 lines
MAINTAINERS +1 -0
+
 Subsystems
 ----------
 Audio

With or without the paths updated:

Reviewed-by on v1 1/1
#2 lore raw
In reply to Thomas Huth
Quoted 3 lines · Thomas Huth

The "XIVE" section is currently listed in the "PowerPC Machines" section, which is weird, since this is an interrupt controller device.

( I wonder how XIVE should be classified, the logic is as big as
a core on the POWER9 processor. )

Quoted 2 lines

Move it to the "Devices" section instead.

yes, looks good me.

Thanks,

C.

Quoted 39 lines
---
 MAINTAINERS | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
MAINTAINERS +8 -8
index b334b53..eac36b6 100644
@@ -1038,14 +1038,6 @@ F: tests/libqos/*spapr*
 F: tests/rtas*
 F: tests/libqos/rtas*
 
-XIVE
-M: David Gibson <[email protected]>
-M: Cédric Le Goater <[email protected]>
-L: [email protected]
-S: Supported
-F: hw/*/*xive*
-F: include/hw/*/*xive*
-
 virtex_ml507
 M: Edgar E. Iglesias <[email protected]>
 L: [email protected]
@@ -1645,6 +1637,14 @@ F: tests/libqos/fw_cfg.c
 F: tests/fw_cfg-test.c
 T: git https://github.com/philmd/qemu.git fw_cfg-next
 
+XIVE
+M: David Gibson <[email protected]>
+M: Cédric Le Goater <[email protected]>
+L: [email protected]
+S: Supported
+F: hw/*/*xive*
+F: include/hw/*/*xive*
+
 Subsystems
 ----------
 Audio
Applied
#3 lore raw
In reply to Thomas Huth
Quoted 5 lines · Thomas Huth

The "XIVE" section is currently listed in the "PowerPC Machines" section, which is weird, since this is an interrupt controller device. Move it to the "Devices" section instead.

Applied to ppc-for-4.0, thanks.

Quoted 38 lines
---
 MAINTAINERS | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
MAINTAINERS +8 -8
index b334b53..eac36b6 100644
@@ -1038,14 +1038,6 @@ F: tests/libqos/*spapr*
 F: tests/rtas*
 F: tests/libqos/rtas*
 
-XIVE
-M: David Gibson <[email protected]>
-M: Cédric Le Goater <[email protected]>
-L: [email protected]
-S: Supported
-F: hw/*/*xive*
-F: include/hw/*/*xive*
-
 virtex_ml507
 M: Edgar E. Iglesias <[email protected]>
 L: [email protected]
@@ -1645,6 +1637,14 @@ F: tests/libqos/fw_cfg.c
 F: tests/fw_cfg-test.c
 T: git https://github.com/philmd/qemu.git fw_cfg-next
 
+XIVE
+M: David Gibson <[email protected]>
+M: Cédric Le Goater <[email protected]>
+L: [email protected]
+S: Supported
+F: hw/*/*xive*
+F: include/hw/*/*xive*
+
 Subsystems
 ----------
 Audio
Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson