Skip to contentSkip to conversation

: net: hso: do not call unregister if not registered

PATCH In review Yavuz, Tuba 2 participants 3 messages Feb 5, 2019 – Feb 6, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : net: hso: do not call unregister if not registered

On an error path inside the hso_create_net_device function of the hso driver, hso_free_net_device gets called. This causes potentially a negative reference count in the net device if register_netdev has not been called yet as hso_free_net_device calls unregister_netdev regardless. I think the driver should distinguish these cases and call unregister_netdev only if register_netdev has been called.

---

drivers/net/usb/hso.c 2019-02-05 17:54:17.056496019 -0500 renamed from drivers/net/usb/hso.c.orig 2019-01-27 14:45:58.232683119 -0500 +3 -1
@@ -2377,7 +2377,9 @@ static void hso_free_net_device(struct h
 
        remove_net_device(hso_net->parent);
 
-       if (hso_net->net)
+       if (hso_net->net &&
+           hso_net->net->reg_state == NETREG_REGISTERED
+          )
                unregister_netdev(hso_net->net);
 
        /* start freeing */
maintainer
#1 lore raw

From: "Yavuz, Tuba" <[email protected]>
Date: Tue, 5 Feb 2019 23:01:25 +0000

Quoted 15 lines

On an error path inside the hso_create_net_device function of the hso driver, hso_free_net_device gets called. This causes potentially a negative reference count in the net device if register_netdev has not been called yet as hso_free_net_device calls unregister_netdev regardless. I think the driver should distinguish these cases and call unregister_netdev only if register_netdev has been called.

---

drivers/net/usb/hso.c 2019-02-05 17:54:17.056496019 -0500 static void hso_free_net_device(struct h · line 2382

Quoted 7 lines
drivers/net/usb/hso.c 2019-02-05 17:54:17.056496019 -0500 renamed from drivers/net/usb/hso.c.orig 2019-01-27 14:45:58.232683119 -0500 +3 -1
@@ -2377,7 +2377,9 @@ static void hso_free_net_device(struct h
 
        remove_net_device(hso_net->parent);
 
-       if (hso_net->net)
+       if (hso_net->net &&
+           hso_net->net->reg_state == NETREG_REGISTERED
+          )

This is not formatted correctly, the final closing ')' should end the previous line, like this:

       if (hso_net->net &&
           hso_net->net->reg_state == NETREG_REGISTERED)
#2 lore raw

This is surprising as I got total: 0 errors, 0 warnings, 0 checks, 10 lines checked.

Anyhow, I'll submit as suggested.

Best,

Tuba Yavuz, Ph.D.
Assistant Professor
Electrical and Computer Engineering Department
University of Florida
Gainesville, FL 32611
Webpage: http://www.tuba.ece.ufl.edu/
Email: [email protected]
Phone: (352) 846 0202

________________________________________
From: David Miller <[email protected]>
Sent: Tuesday, February 5, 2019 7:36 PM
To: Yavuz, Tuba
Cc: [email protected]
Subject: Re: [PATCH]: net: hso: do not call unregister if not registered

From: "Yavuz, Tuba" <[email protected]>
Date: Tue, 5 Feb 2019 23:01:25 +0000

Quoted 15 lines

On an error path inside the hso_create_net_device function of the hso driver, hso_free_net_device gets called. This causes potentially a negative reference count in the net device if register_netdev has not been called yet as hso_free_net_device calls unregister_netdev regardless. I think the driver should distinguish these cases and call unregister_netdev only if register_netdev has been called.

---

drivers/net/usb/hso.c 2019-02-05 17:54:17.056496019 -0500 static void hso_free_net_device(struct h · line 2382

Quoted 7 lines
drivers/net/usb/hso.c 2019-02-05 17:54:17.056496019 -0500 renamed from drivers/net/usb/hso.c.orig 2019-01-27 14:45:58.232683119 -0500 +3 -1
@@ -2377,7 +2377,9 @@ static void hso_free_net_device(struct h
 
        remove_net_device(hso_net->parent);
 
-       if (hso_net->net)
+       if (hso_net->net &&
+           hso_net->net->reg_state == NETREG_REGISTERED
+          )

This is not formatted correctly, the final closing ')' should end the previous line, like this:

       if (hso_net->net &&
           hso_net->net->reg_state == NETREG_REGISTERED)