Skip to contentSkip to conversation

doc: cgroup: correct the wrong information about measure of memory pressure

PATCH In review Yang Shi 3 participants 5 messages Feb 16, 2019 – Feb 21, 2019

Subsystems (3)
lore
Share & tools
lore

Yang Shi

author
#0 lore raw

PATCH 1/1 doc: cgroup: correct the wrong information about measure of memory pressure

Since PSI has implemented some kind of measure of memory pressure, the statement about lack of such measure is not true anymore.

Cc Tejun Heo <[email protected]>
Cc Johannes Weiner <[email protected]>
Cc Jonathan Corbet <[email protected]>
---
 Documentation/admin-guide/cgroup-v2.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Documentation/admin-guide/cgroup-v2.rst +1 -2
index 7bf3f12..9a92013 100644
@@ -1310,8 +1310,7 @@ network to a file can use all available memory but can also operate as
 performant with a small amount of memory.  A measure of memory
 pressure - how much the workload is being impacted due to lack of
 memory - is necessary to determine whether a workload needs more
-memory; unfortunately, memory pressure monitoring mechanism isn't
-implemented yet.
+memory.
 
 
 Memory Ownership
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw
Quoted 16 lines · Yang Shi

Since PSI has implemented some kind of measure of memory pressure, the statement about lack of such measure is not true anymore.

Cc Tejun Heo <[email protected]>
Cc Johannes Weiner <[email protected]>
Cc Jonathan Corbet <[email protected]>
---
 Documentation/admin-guide/cgroup-v2.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Documentation/admin-guide/cgroup-v2.rst +0 -0
index 7bf3f12..9a92013 100644

Documentation/admin-guide/cgroup-v2.rst network to a file can use all available memory but can also operate as · line 1313

Quoted 6 lines
Documentation/admin-guide/cgroup-v2.rst +1 -2
@@ -1310,8 +1310,7 @@ network to a file can use all available memory but can also operate as
 performant with a small amount of memory.  A measure of memory
 pressure - how much the workload is being impacted due to lack of
 memory - is necessary to determine whether a workload needs more
-memory; unfortunately, memory pressure monitoring mechanism isn't
-implemented yet.
+memory.

Maybe refer to PSI?

Thanks.

Signature · 1 line
tejun
#2 lore raw

Hi TeJun
I've built the 5.0.0-rc6 kernel with psi option, but I cannot find any cgroup.controllers when I mounted cgroup2.

[root@bogon /]# uname -r
[root@bogon /]# 5.0.0-rc6+
[root@bogon /]# mount -t cgroup2 none cgroup2/ [root@bogon /]# cat cgroup2/cgroup.controllers [root@bogon /]
[root@bogon /]# cat cgroup2/cgroup.subtree_control [root@bogon /]#

What's wrong with this kernel? Or maybe I lost some mount option?

Thanks
Yuzhoujian

Quoted 31 lines · Tejun Heo <[email protected]> 于2019年2月19日周二 上午10:32写道:
Quoted 16 lines · Yang Shi

Since PSI has implemented some kind of measure of memory pressure, the statement about lack of such measure is not true anymore.

Cc Tejun Heo <[email protected]>
Cc Johannes Weiner <[email protected]>
Cc Jonathan Corbet <[email protected]>
---
 Documentation/admin-guide/cgroup-v2.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Documentation/admin-guide/cgroup-v2.rst +0 -0
index 7bf3f12..9a92013 100644

Documentation/admin-guide/cgroup-v2.rst network to a file can use all available memory but can also operate as · line 1313

Quoted 6 lines
Documentation/admin-guide/cgroup-v2.rst +1 -2
@@ -1310,8 +1310,7 @@ network to a file can use all available memory but can also operate as
 performant with a small amount of memory.  A measure of memory
 pressure - how much the workload is being impacted due to lack of
 memory - is necessary to determine whether a workload needs more
-memory; unfortunately, memory pressure monitoring mechanism isn't
-implemented yet.
+memory.

Maybe refer to PSI?

Thanks.

--
tejun

author
#4 lore raw
In reply to Tejun Heo
Quoted 12 lines · Tejun Heo
Quoted 11 lines · Yang Shi

Since PSI has implemented some kind of measure of memory pressure, the statement about lack of such measure is not true anymore.

Cc Tejun Heo <[email protected]>
Cc Johannes Weiner <[email protected]>
Cc Jonathan Corbet <[email protected]>
---
  Documentation/admin-guide/cgroup-v2.rst | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
Quoted 12 lines

Documentation/admin-guide/cgroup-v2.rst network to a file can use all available memory but can also operate as · line 1313

Quoted 11 lines
Documentation/admin-guide/cgroup-v2.rst +1 -2
index 7bf3f12..9a92013 100644
@@ -1310,8 +1310,7 @@ network to a file can use all available memory but can also operate as
  performant with a small amount of memory.  A measure of memory
  pressure - how much the workload is being impacted due to lack of
  memory - is necessary to determine whether a workload needs more
-memory; unfortunately, memory pressure monitoring mechanism isn't
-implemented yet.
+memory.

Maybe refer to PSI?

I thought so too, but the above "memory.pressure" has already referred to PSI. So, I was not sure if we should duplicate PSI information.

Thanks,
Yang

Quoted 3 lines

Thanks.

author
#3 lore raw
In reply to 禹舟键
Quoted 12 lines · 禹舟键

Hi TeJun
I've built the 5.0.0-rc6 kernel with psi option, but I cannot find any cgroup.controllers when I mounted cgroup2.

[root@bogon /]# uname -r
[root@bogon /]# 5.0.0-rc6+
[root@bogon /]# mount -t cgroup2 none cgroup2/ [root@bogon /]# cat cgroup2/cgroup.controllers [root@bogon /]
[root@bogon /]# cat cgroup2/cgroup.subtree_control [root@bogon /]#

Quoted 1 line

What's wrong with this kernel? Or maybe I lost some mount option?

I'm not sure what you did before you mounted cgroup2, but if you have legacy controllers mounted, you have to unmount them, otherwise cgroup.controllers would show up as empty. Or you can pass "cgroup_no_v1=" in your kernel parameter.

Yang

Quoted 34 lines

Thanks
Yuzhoujian

Quoted 29 lines · Tejun Heo <[email protected]> 于2019年2月19日周二 上午10:32写道:
Quoted 16 lines · Yang Shi

Since PSI has implemented some kind of measure of memory pressure, the statement about lack of such measure is not true anymore.

Cc Tejun Heo <[email protected]>
Cc Johannes Weiner <[email protected]>
Cc Jonathan Corbet <[email protected]>
---
  Documentation/admin-guide/cgroup-v2.rst | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
Documentation/admin-guide/cgroup-v2.rst +0 -0
index 7bf3f12..9a92013 100644

Documentation/admin-guide/cgroup-v2.rst network to a file can use all available memory but can also operate as · line 1313

Quoted 6 lines
Documentation/admin-guide/cgroup-v2.rst +1 -2
@@ -1310,8 +1310,7 @@ network to a file can use all available memory but can also operate as
  performant with a small amount of memory.  A measure of memory
  pressure - how much the workload is being impacted due to lack of
  memory - is necessary to determine whether a workload needs more
-memory; unfortunately, memory pressure monitoring mechanism isn't
-implemented yet.
+memory.

Maybe refer to PSI?

Thanks.

--
tejun