Skip to contentSkip to conversation

cirrus.yml: Add macOS continuous integration task

PATCH Superseded Thomas Huth 5 participants 10 messages Mar 4, 2019 – Mar 8, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cirrus.yml: Add macOS continuous integration task

cirrus-ci.com also has the possibility to run CI tasks on macOS. Since most of the QEMU developers do not have access to macOS yet, let's add a CI pipeline for this operating system here, too.

---
You can see an example here: https://cirrus-ci.com/task/5099494325616640

 .cirrus.yml | 12 ++++++++++++
 1 file changed, 12 insertions(+)
.cirrus.yml +12 -0
index 303fe72..e3d375b 100644
@@ -14,3 +14,15 @@ freebsd_12_task:
     - ../configure || { cat config.log; exit 1; }
     - gmake -j8
     - gmake -j8 V=1 check
+
+macos_task:
+  osx_instance:
+    image: high-sierra-base
+  env:
+    CIRRUS_CLONE_DEPTH: 1
+  install_script:
+    - brew install pkg-config glib pixman make sdl2
+  script:
+    - ./configure || { cat config.log; exit 1; }
+    - gmake -j$(sysctl -n hw.ncpu)
+    - gmake check -j$(sysctl -n hw.ncpu)
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Thomas Huth

cirrus-ci.com also has the possibility to run CI tasks on macOS. Since most of the QEMU developers do not have access to macOS yet, let's add a CI pipeline for this operating system here, too.

Can we get report of failures? (IRC, mail to ML, patchew icon)

Quoted 2 lines
Quoted 27 lines

---
You can see an example here: https://cirrus-ci.com/task/5099494325616640

 .cirrus.yml | 12 ++++++++++++
 1 file changed, 12 insertions(+)
.cirrus.yml +12 -0
index 303fe72..e3d375b 100644
@@ -14,3 +14,15 @@ freebsd_12_task:
     - ../configure || { cat config.log; exit 1; }
     - gmake -j8
     - gmake -j8 V=1 check
+
+macos_task:
+  osx_instance:
+    image: high-sierra-base
+  env:
+    CIRRUS_CLONE_DEPTH: 1
+  install_script:
+    - brew install pkg-config glib pixman make sdl2
+  script:
+    - ./configure || { cat config.log; exit 1; }
+    - gmake -j$(sysctl -n hw.ncpu)
+    - gmake check -j$(sysctl -n hw.ncpu)
#2 lore raw
Quoted 6 lines · Philippe Mathieu-Daudé
Quoted 3 lines · Thomas Huth

cirrus-ci.com also has the possibility to run CI tasks on macOS. Since most of the QEMU developers do not have access to macOS yet, let's add a CI pipeline for this operating system here, too.

Can we get report of failures? (IRC, mail to ML, patchew icon)

Honestly, I've got no clue ... this is the only help text that I've found so far:

https://cirrus-ci.org/guide/notifications/

Thomas

#5 lore raw
Quoted 10 lines · Ed Maste
Quoted 8 lines · Philippe Mathieu-Daudé
Quoted 5 lines · Thomas Huth

cirrus-ci.com also has the possibility to run CI tasks on macOS. Since most of the QEMU developers do not have access to macOS yet, let's add a CI pipeline for this operating system here, too.

Thanks! I can take this patch through my qtest tree.

Thomas

#6 lore raw
Quoted 9 lines · Thomas Huth
Quoted 7 lines · Ed Maste
Quoted 6 lines · Philippe Mathieu-Daudé
Quoted 3 lines · Thomas Huth

cirrus-ci.com also has the possibility to run CI tasks on macOS. Since most of the QEMU developers do not have access to macOS yet, let's add a CI pipeline for this operating system here, too.

Quoted 5 lines
Quoted 3 lines
Quoted 2 lines
Quoted 1 line

Thanks! I can take this patch through my qtest tree.

Hi Thomas,

Sorry for the late reply, I checked and tested the patch, it works fine. BTW, may I suggest:

Quoted 1 line

From https://cirrus-ci.org/guide/macOS/ , the image high-sierra-base

is lasted as "Not maintained", how about change to mojave-base?

Also, perhaps we can put the common:

env:
CIRRUS_CLONE_DEPTH: 1

in the global area?

Thanks,
Li-wen

#7 lore raw
Quoted 16 lines · Li-Wen Hsu
Quoted 9 lines · Thomas Huth
Quoted 7 lines · Ed Maste
Quoted 6 lines · Philippe Mathieu-Daudé
Quoted 3 lines · Thomas Huth

cirrus-ci.com also has the possibility to run CI tasks on macOS. Since most of the QEMU developers do not have access to macOS yet, let's add a CI pipeline for this operating system here, too.

Quoted 5 lines
Quoted 3 lines
Quoted 2 lines
Quoted 1 line

Thanks! I can take this patch through my qtest tree.

Quoted 7 lines

Hi Thomas,

Sorry for the late reply, I checked and tested the patch, it works fine. BTW, may I suggest:

From https://cirrus-ci.org/guide/macOS/ , the image high-sierra-base is lasted as "Not maintained", how about change to mojave-base?

Definitely! Not sure how I could have missed that... I was either blind, or, how I remember it, the high-sierra-base image was not marked as unmaintained yet and marked as the only image that had the brew system pre-installed back then. Anyway, I've now switched to mojave-base and it seems to work fine, too.

Quoted 6 lines

Also, perhaps we can put the common:

env:
CIRRUS_CLONE_DEPTH: 1

in the global area?

Sure! I'll do that in v2.

Thanks for the review,
Thomas

#8 lore raw
In reply to Philippe Mathieu-Daudé

.cirrus.yml freebsd_12_task: · line 24

Quoted 7 lines · Philippe Mathieu-Daudé
.cirrus.yml +7 -0
+macos_task:
+  osx_instance:
+    image: high-sierra-base
+  env:
+    CIRRUS_CLONE_DEPTH: 1
+  install_script:
+    - brew install pkg-config glib pixman make sdl2

Could you also install Python 3 ("python" in Homebrew is 3.7) and avoid Apple's obsolete /usr/bin/python (also needs something like --python=/usr/local/bin/python3 in ./configure below).

Thanks,

Paolo

Quoted 4 lines
.cirrus.yml +4 -0
+  script:
+    - ./configure || { cat config.log; exit 1; }
+    - gmake -j$(sysctl -n hw.ncpu)
+    - gmake check -j$(sysctl -n hw.ncpu)
#9 lore raw
Quoted 9 lines · Paolo Bonzini

.cirrus.yml freebsd_12_task: · line 24

Quoted 7 lines · Philippe Mathieu-Daudé
.cirrus.yml +7 -0
+macos_task:
+  osx_instance:
+    image: high-sierra-base
+  env:
+    CIRRUS_CLONE_DEPTH: 1
+  install_script:
+    - brew install pkg-config glib pixman make sdl2
Quoted 3 lines

Could you also install Python 3 ("python" in Homebrew is 3.7) and avoid Apple's obsolete /usr/bin/python (also needs something like --python=/usr/local/bin/python3 in ./configure below).

Yes, can do.

Thomas